Skip to content

Commit 17d90ee

Browse files
committed
Silence byte compiler warnings
* jupyter-org-extensions.el (jupyter-org-edit-header): Do it. * jupyter-repl.el (jupyter-handle-error) (jupyter-repl-interaction-mode) (jupyter-repl-interaction-mode-line): Do it.
1 parent e89e528 commit 17d90ee

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

jupyter-org-extensions.el

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -460,9 +460,12 @@ Defaults to `jupyter-org-jump-to-block-context-lines'."
460460
(let* ((header-start (nth 5 src-info))
461461
(header-end (save-excursion (goto-char header-start)
462462
(line-end-position))))
463-
(setf (buffer-substring header-start header-end)
464-
(read-string "Header: "
465-
(buffer-substring header-start header-end))))))
463+
(let ((header (read-string "Header: "
464+
(buffer-substring header-start header-end))))
465+
(save-excursion
466+
(delete-region header-start header-end)
467+
(goto-char header-start)
468+
(insert header))))))
466469

467470
(defun jupyter-org-src-block-bounds ()
468471
"Return the region containing the current source block.

jupyter-repl.el

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -955,7 +955,7 @@ buffer to display TEXT."
955955
(when req
956956
(jupyter-with-message-content msg (traceback)
957957
(cond
958-
((eq (jupyter-message-parent-type msg) "comm_msg")
958+
((equal (jupyter-message-parent-type msg) "comm_msg")
959959
(jupyter-display-traceback traceback))
960960
(t
961961
(jupyter-repl-append-output client req
@@ -1349,6 +1349,8 @@ this method is called."
13491349
;; added after deleting text at the beginning of a cell.
13501350
(jupyter-repl-mark-as-cell-code beg (min (point-max) (+ beg 1))))
13511351

1352+
(defvar jupyter-repl-interaction-mode)
1353+
13521354
(defun jupyter-repl--deactivate-interaction-buffers ()
13531355
(cl-loop
13541356
with client = jupyter-current-client
@@ -1872,8 +1874,8 @@ Do so only if possible in the `current-buffer'."
18721874

18731875
(defun jupyter-repl-interaction-mode-line ()
18741876
"Return a mode line string with the status of the kernel.
1875-
'*' means the kernel is busy, '-' means the kernel is idle and
1876-
the REPL is connected, 'x' means the REPL is disconnected
1877+
`*' means the kernel is busy, `-' means the kernel is idle and
1878+
the REPL is connected, `x' means the REPL is disconnected
18771879
from the kernel."
18781880
(and (cl-typep jupyter-current-client 'jupyter-repl-client)
18791881
(concat " JuPy["

0 commit comments

Comments
 (0)