switch from error to fail in binary decoders

Author: evancz

builder/src/Elm/Details.hs

@@ -776,7 +776,7 @@ instance Binary ValidOutline where
         case n of
           0 -> liftM  ValidApp get
           1 -> liftM3 ValidPkg get get get
-          _ -> error "binary encoding of ValidOutline was corrupted"
+          _ -> fail "binary encoding of ValidOutline was corrupted"
 
 
 instance Binary Local where

compiler/src/AST/Canonical.hs

@@ -342,7 +342,7 @@ instance Binary CtorOpts where
           0 -> return Normal
           1 -> return Enum
           2 -> return Unbox
-          _ -> error "binary encoding of CtorOpts was corrupted"
+          _ -> fail "binary encoding of CtorOpts was corrupted"
 
 
 instance Binary Annotation where
@@ -393,7 +393,7 @@ instance Binary AliasType where
         case n of
           0 -> liftM Holey get
           1 -> liftM Filled get
-          _ -> error "binary encoding of AliasType was corrupted"
+          _ -> fail "binary encoding of AliasType was corrupted"
 
 
 instance Binary FieldType where

compiler/src/AST/Optimized.hs

@@ -308,7 +308,7 @@ instance Binary Expr where
           24 -> pure   Unit
           25 -> liftM3 Tuple get get get
           26 -> liftM3 Shader get get get
-          _  -> error "problem getting Opt.Expr binary"
+          _  -> fail "problem getting Opt.Expr binary"
 
 
 instance Binary Def where
@@ -322,7 +322,7 @@ instance Binary Def where
         case word of
           0 -> liftM2 Def get get
           1 -> liftM3 TailDef get get get
-          _ -> error "problem getting Opt.Def binary"
+          _ -> fail "problem getting Opt.Def binary"
 
 
 instance Binary Destructor where
@@ -345,7 +345,7 @@ instance Binary Path where
           1 -> liftM2 Field get get
           2 -> liftM  Unbox get
           3 -> liftM  Root get
-          _ -> error "problem getting Opt.Path binary"
+          _ -> fail "problem getting Opt.Path binary"
 
 
 instance (Binary a) => Binary (Decider a) where
@@ -361,7 +361,7 @@ instance (Binary a) => Binary (Decider a) where
           0 -> liftM  Leaf get
           1 -> liftM3 Chain get get get
           2 -> liftM3 FanOut get get get
-          _ -> error "problem getting Opt.Decider binary"
+          _ -> fail "problem getting Opt.Decider binary"
 
 
 instance Binary Choice where
@@ -375,7 +375,7 @@ instance Binary Choice where
         case word of
           0 -> liftM Inline get
           1 -> liftM Jump get
-          _ -> error "problem getting Opt.Choice binary"
+          _ -> fail "problem getting Opt.Choice binary"
 
 
 
@@ -400,7 +400,7 @@ instance Binary Main where
         case word of
           0 -> return Static
           1 -> liftM2 Dynamic get get
-          _ -> error "problem getting Opt.Main binary"
+          _ -> fail "problem getting Opt.Main binary"
 
 
 instance Binary Node where
@@ -432,7 +432,7 @@ instance Binary Node where
           8  -> liftM2 Kernel get get
           9  -> liftM2 PortIncoming get get
           10 -> liftM2 PortOutgoing get get
-          _  -> error "problem getting Opt.Node binary"
+          _  -> fail "problem getting Opt.Node binary"
 
 
 instance Binary EffectsType where
@@ -448,4 +448,4 @@ instance Binary EffectsType where
           0 -> return Cmd
           1 -> return Sub
           2 -> return Fx
-          _ -> error "problem getting Opt.EffectsType binary"
+          _ -> fail "problem getting Opt.EffectsType binary"

compiler/src/AST/Utils/Binop.hs

@@ -41,12 +41,11 @@ instance Binary Precedence where
 instance Binary Associativity where
   get =
     do  n <- getWord8
-        return $
-          case n of
-            0 -> Left
-            1 -> Non
-            2 -> Right
-            _ -> error "Error reading valid associativity from serialized string"
+        case n of
+          0 -> return Left
+          1 -> return Non
+          2 -> return Right
+          _ -> fail "Error reading valid associativity from serialized string"
 
   put assoc =
     putWord8 $

compiler/src/Elm/Constraint.hs

@@ -216,7 +216,7 @@ instance Binary Op where
         case n of
           0 -> return Less
           1 -> return LessOrEqual
-          _ -> error "binary encoding of Op was corrupted"
+          _ -> fail "binary encoding of Op was corrupted"
 
 
 

compiler/src/Elm/Interface.hs

@@ -215,7 +215,7 @@ instance Binary Union where
           0 -> liftM OpenUnion get
           1 -> liftM ClosedUnion get
           2 -> liftM PrivateUnion get
-          _ -> error "binary encoding of Union was corrupted"
+          _ -> fail "binary encoding of Union was corrupted"
 
 
 instance Binary Alias where
@@ -229,7 +229,7 @@ instance Binary Alias where
         case n of
           0 -> liftM PublicAlias get
           1 -> liftM PrivateAlias get
-          _ -> error "binary encoding of Alias was corrupted"
+          _ -> fail "binary encoding of Alias was corrupted"
 
 
 instance Binary Binop where
@@ -251,4 +251,4 @@ instance Binary DependencyInterface where
         case n of
           0 -> liftM  Public get
           1 -> liftM3 Private get get get
-          _ -> error "binary encoding of DependencyInterface was corrupted"
+          _ -> fail "binary encoding of DependencyInterface was corrupted"

compiler/src/Optimize/DecisionTree.hs

@@ -618,7 +618,7 @@ instance Binary Test where
           5 -> liftM  IsStr get
           6 -> liftM  IsInt get
           7 -> liftM  IsBool get
-          _ -> error "problem getting DecisionTree.Test binary"
+          _ -> fail "problem getting DecisionTree.Test binary"
 
 
 instance Binary Path where
@@ -634,4 +634,4 @@ instance Binary Path where
           0 -> liftM2 Index get get
           1 -> liftM Unbox get
           2 -> pure Empty
-          _ -> error "problem getting DecisionTree.Path binary"
+          _ -> fail "problem getting DecisionTree.Path binary"