fix some spacing, fix credo warnings

Author: mmmries

lib/sqlitex/sql_builder.ex

@@ -23,14 +23,14 @@ defmodule Sqlitex.SqlBuilder do
   defp table_opt(:temp), do: {:temp, "TEMP"}
   defp table_opt({:primary_key, cols}) when is_list(cols) do
     {
-      :primary_key, ",PRIMARY KEY ("
+      :primary_key, ", PRIMARY KEY ("
       # Also quote the columns in a PRIMARY KEY list
-      <> (cols |> Enum.map(&(~s("#{&1}"))) |> Enum.join(","))
+      <> (cols |> Enum.map(&(~s("#{&1}"))) |> Enum.join(", "))
       <> ")"
     }
   end
   defp table_opt({:primary_key, col}) when is_atom(col) do
-    {:primary_key, ",PRIMARY KEY (\"" <> Atom.to_string(col) <> "\")"}
+    {:primary_key, ", PRIMARY KEY (\"" <> Atom.to_string(col) <> "\")"}
   end
 
   # Supported column options

test/row_test.exs

@@ -3,23 +3,23 @@ defmodule Sqlitex.RowTest do
   import Sqlitex.Row
 
   test "supports the YYYY-MM-DD HH:MM format" do
-    [row] = from([:datetime],[:test],[{"1988-02-14 15:17"}], %{})
-    assert %{test: {{1988,2,14},{15,17,0,0}}} == row
+    [row] = from([:datetime], [:test], [{"1988-02-14 15:17"}], %{})
+    assert %{test: {{1988, 2, 14}, {15, 17, 0, 0}}} == row
   end
 
   test "supports the YYYY-MM-DD HH:MM:SS format" do
-    [row] = from([:datetime],[:test],[{"1988-02-14 15:17:11"}], %{})
-    assert %{test: {{1988,2,14},{15,17,11,0}}} == row
+    [row] = from([:datetime], [:test], [{"1988-02-14 15:17:11"}], %{})
+    assert %{test: {{1988, 2, 14}, {15, 17, 11, 0}}} == row
   end
 
   test "supports the YYYY-MM-DD HH:MM:SS.FFF format" do
-    [row] = from([:datetime],[:test],[{"1988-02-14 15:17:11.123"}], %{})
-    assert %{test: {{1988,2,14},{15,17,11,123_000}}} == row
+    [row] = from([:datetime], [:test], [{"1988-02-14 15:17:11.123"}], %{})
+    assert %{test: {{1988, 2, 14}, {15, 17, 11, 123_000}}} == row
   end
 
   test "supports the YYYY-MM-DD HH:MM:SS.FFFFFF format" do
-    [row] = from([:datetime],[:test],[{"1988-02-14 15:17:11.123456"}], %{})
-    assert %{test: {{1988,2,14},{15,17,11,123_456}}} == row
+    [row] = from([:datetime], [:test], [{"1988-02-14 15:17:11.123456"}], %{})
+    assert %{test: {{1988, 2, 14}, {15, 17, 11, 123_456}}} == row
   end
 
   test "parses decimal types" do

test/sql_builder_test.exs

@@ -14,12 +14,12 @@ defmodule SqlBuilderTest do
 
   test "creating a table with a primary key" do
     sql = Sql.create_table(:dinosaurs, [primary_key: :id], id: :integer, name: :text)
-    assert sql == "CREATE  TABLE \"dinosaurs\" (\"id\" integer, \"name\" text ,PRIMARY KEY (\"id\"))"
+    assert sql == "CREATE  TABLE \"dinosaurs\" (\"id\" integer, \"name\" text , PRIMARY KEY (\"id\"))"
   end
 
   test "creating a table with multiple primary keys" do
     sql = Sql.create_table(:dinosaurs, [primary_key: [:id, :type]], id: :integer, type: :integer, name: :text)
-    assert sql == "CREATE  TABLE \"dinosaurs\" (\"id\" integer, \"type\" integer, \"name\" text ,PRIMARY KEY (\"id\",\"type\"))"
+    assert sql == "CREATE  TABLE \"dinosaurs\" (\"id\" integer, \"type\" integer, \"name\" text , PRIMARY KEY (\"id\", \"type\"))"
   end
 
   test "creating a table with NOT NULL columns" do

test/sqlitex_test.exs

@@ -28,14 +28,14 @@ defmodule SqlitexTest do
   test "server basic query" do
     {:ok, conn} = Sqlitex.Server.start_link(@shared_cache)
     {:ok, [row]} = Sqlitex.Server.query(conn, "SELECT * FROM players ORDER BY id LIMIT 1")
-    assert row == [id: 1, name: "Mikey", created_at: {{2012,10,14},{05,46,28,318_107}}, updated_at: {{2013,09,06},{22,29,36,610_911}}, type: nil]
+    assert row == [id: 1, name: "Mikey", created_at: {{2012, 10, 14}, {05, 46, 28, 318_107}}, updated_at: {{2013, 09, 06}, {22, 29, 36, 610_911}}, type: nil]
     Sqlitex.Server.stop(conn)
   end
 
   test "server basic query by name" do
     {:ok, _} = Sqlitex.Server.start_link(@shared_cache, name: :sql)
     {:ok, [row]} = Sqlitex.Server.query(:sql, "SELECT * FROM players ORDER BY id LIMIT 1")
-    assert row == [id: 1, name: "Mikey", created_at: {{2012,10,14},{05,46,28,318_107}}, updated_at: {{2013,09,06},{22,29,36,610_911}}, type: nil]
+    assert row == [id: 1, name: "Mikey", created_at: {{2012, 10, 14}, {05, 46, 28, 318_107}}, updated_at: {{2013, 09, 06}, {22, 29, 36, 610_911}}, type: nil]
     Sqlitex.Server.stop(:sql)
   end
 
@@ -46,20 +46,20 @@ defmodule SqlitexTest do
 
   test "a basic query returns a list of keyword lists", context do
     {:ok, [row]} = Sqlitex.query(context[:golf_db], "SELECT * FROM players ORDER BY id LIMIT 1")
-    assert row == [id: 1, name: "Mikey", created_at: {{2012,10,14},{05,46,28,318_107}}, updated_at: {{2013,09,06},{22,29,36,610_911}}, type: nil]
+    assert row == [id: 1, name: "Mikey", created_at: {{2012, 10, 14}, {05, 46, 28, 318_107}}, updated_at: {{2013, 09, 06}, {22, 29, 36, 610_911}}, type: nil]
   end
 
   test "a basic query returns a list of maps when into: %{} is given", context do
     {:ok, [row]} = Sqlitex.query(context[:golf_db], "SELECT * FROM players ORDER BY id LIMIT 1", into: %{})
-    assert row == %{id: 1, name: "Mikey", created_at: {{2012,10,14},{05,46,28,318_107}}, updated_at: {{2013,09,06},{22,29,36,610_911}}, type: nil}
+    assert row == %{id: 1, name: "Mikey", created_at: {{2012, 10, 14}, {05, 46, 28, 318_107}}, updated_at: {{2013, 09, 06}, {22, 29, 36, 610_911}}, type: nil}
   end
 
   test "with_db" do
     {:ok, [row]} = Sqlitex.with_db(@shared_cache, fn(db) ->
       Sqlitex.query(db, "SELECT * FROM players ORDER BY id LIMIT 1")
     end)
 
-    assert row == [id: 1, name: "Mikey", created_at: {{2012,10,14},{05,46,28,318_107}}, updated_at: {{2013,09,06},{22,29,36,610_911}}, type: nil]
+    assert row == [id: 1, name: "Mikey", created_at: {{2012, 10, 14}, {05, 46, 28, 318_107}}, updated_at: {{2013, 09, 06}, {22, 29, 36, 610_911}}, type: nil]
   end
 
   test "table creation works as expected" do