Elixir updates (#212)

## Additions
* Add CircleCI
* Add/Enforce Credo

## Updates
* Updated dependencies
* Updated README.md

## Bug fixes
* Fix #204 by fixing the case clause
* Add default timeouts of 5000ms to queries.

Author: ConnorRigby

.circleci/config.yml

@@ -0,0 +1,23 @@
+version: 2.0
+jobs:
+  build:
+    docker:
+      - image: circleci/elixir:1.6.6-otp-21
+    steps:
+      - checkout
+      - restore_cache:
+          keys:
+            - v2-dependency-cache-{{ checksum "mix.lock" }}
+      - run: mix local.hex --force
+      - run: mix local.rebar --force
+      - run: mix deps.get
+      - run: mix deps.compile
+      - run: mix compile
+      - run: ./integration/hack_out_incompatible_tests.sh
+      - run: mix credo --strict
+      - run: mix coveralls.circle
+      - save_cache:
+          key: v2-dependency-cache-{{ checksum "mix.lock" }}
+          paths:
+            - _build
+            - deps

.credo.exs

@@ -72,10 +72,6 @@
       {Credo.Check.Warning.BoolOperationOnSameValues},
       {Credo.Check.Warning.IExPry},
       {Credo.Check.Warning.IoInspect, false},
-      {Credo.Check.Warning.NameRedeclarationByAssignment, false},
-      {Credo.Check.Warning.NameRedeclarationByCase, false},
-      {Credo.Check.Warning.NameRedeclarationByDef, false},
-      {Credo.Check.Warning.NameRedeclarationByFn, false},
       {Credo.Check.Warning.OperationOnSameValues, false},
         # Disabled because of p.x == p.x in Ecto queries
       {Credo.Check.Warning.OperationWithConstantResult},

.formatter.exs

@@ -0,0 +1,4 @@
+# Used by "mix format"
+[
+  inputs: ["mix.exs", "{config,lib,test,bench}/**/*.{ex,exs}"]
+]

.tool-versions

@@ -0,0 +1,2 @@
+erlang 21.0.1
+elixir 1.6.6-otp-21

.travis.yml

@@ -1,7 +1,6 @@
-[![Build Status](https://travis-ci.org/scouten/sqlite_ecto2.svg?branch=master "Build Status")](https://travis-ci.org/scouten/sqlite_ecto2)
+[![CircleCI](https://circleci.com/gh/Sqlite-Ecto/sqlite_ecto2.svg?style=svg)](https://circleci.com/gh/Sqlite-Ecto/sqlite_ecto2)
 [![Hex.pm](https://img.shields.io/hexpm/v/sqlite_ecto2.svg)](https://hex.pm/packages/sqlite_ecto2)
-[![Ebert](https://ebertapp.io/github/scouten/sqlite_ecto2.svg)](https://ebertapp.io/github/scouten/sqlite_ecto2)
-[![Coverage Status](https://coveralls.io/repos/github/scouten/sqlite_ecto2/badge.svg?branch=master)](https://coveralls.io/github/scouten/sqlite_ecto2?branch=master)
+[![Coverage Status](https://coveralls.io/repos/github/Sqlite-Ecto/sqlite_ecto2/badge.svg?branch=master)](https://coveralls.io/github/Sqlite-Ecto/sqlite_ecto2?branch=master)
 
 # sqlite_ecto2
 
@@ -10,18 +9,11 @@
 Read [the tutorial](./docs/tutorial.md) for a detailed example of how to setup and use a SQLite repo with Ecto, or just check-out the CliffsNotes in the sections below if you want to get started quickly.
 
 
-## SEEKING NEW MAINTAINER
-
-My sincere apologies, but I must step down from maintaining this project. Some life events have conspired to leave me without the time I would need to devote to properly continue the development of this project. If you are interested in giving it the love it needs (especially, following the changes for Ecto 3.0), please file an issue or contact me at <eric@scouten.com> to discuss taking ownership of this module.
-
-I'll review PRs from time to time if they can be merged easily, but I do not have the ability to review or attempt to fix unsolved issues.
-
-
 ## Ecto Version Compatibility
 
 **IMPORTANT:** This release will _only_ work with Ecto 2.2.x. If you need compatibility with older versions of Ecto, please see:
 
-* Ecto 2.1.x -> [`sqlite_ecto2` 2.0.x series](https://github.com/scouten/sqlite_ecto2/tree/v2.0)
+* Ecto 2.1.x -> [`sqlite_ecto2` 2.0.x series](https://github.com/Sqlite-Ecto/sqlite_ecto2/tree/v2.0)
 * Ecto 1.x -> [`sqlite_ecto` v1.x series](https://github.com/jazzyb/sqlite_ecto)
 
 
@@ -62,7 +54,8 @@ Note that the Travis configuration for this repo specifically excludes OTP 19.0
 
 ## Dependencies
 
-This library makes use of [sqlitex](https://github.com/mmmries/sqlitex) and [esqlite](https://github.com/mmzeeman/esqlite).  Since esqlite uses Erlang NIFs to incorporate SQLite, you will need a valid C compiler to build the library.
+This library makes use of [sqlite3](https://github.com/Sqlite-Ecto/sqlitex)
+Since esqlite uses Erlang NIFs to incorporate SQLite, you will need a valid C compiler to build the library.
 
 ## Example
 

README.md

@@ -10,9 +10,10 @@ defmodule Sqlite.DbConnection.Protocol do
 
   @spec connect(Keyword.t) :: {:ok, state}
   def connect(opts) do
-    {db_path, _opts} = Keyword.pop(opts, :database)
+    db_path = Keyword.fetch!(opts, :database)
+    db_timeout = Keyword.get(opts, :db_timeout, 5000)
 
-    {:ok, db} = Sqlitex.Server.start_link(db_path)
+    {:ok, db} = Sqlitex.Server.start_link(db_path, db_timeout: db_timeout)
     :ok = Sqlitex.Server.exec(db, "PRAGMA foreign_keys = ON")
     {:ok, [[foreign_keys: 1]]} = Sqlitex.Server.query(db, "PRAGMA foreign_keys")
 
@@ -81,7 +82,7 @@ defmodule Sqlite.DbConnection.Protocol do
       :transaction -> "BEGIN"
       :savepoint   -> "SAVEPOINT sqlite_ecto_savepoint"
     end
-    handle_transaction(sql, s)
+    handle_transaction(sql, [timeout: Keyword.get(opts, :timeout, 5000)], s)
   end
 
   @spec handle_commit(Keyword.t, state) ::
@@ -91,7 +92,7 @@ defmodule Sqlite.DbConnection.Protocol do
       :transaction -> "COMMIT"
       :savepoint   -> "RELEASE SAVEPOINT sqlite_ecto_savepoint"
     end
-    handle_transaction(sql, s)
+    handle_transaction(sql, [timeout: Keyword.get(opts, :timeout, 5000)], s)
   end
 
   @spec handle_rollback(Keyword.t, state) ::
@@ -101,7 +102,7 @@ defmodule Sqlite.DbConnection.Protocol do
       :transaction -> "ROLLBACK"
       :savepoint   -> "ROLLBACK TO SAVEPOINT sqlite_ecto_savepoint"
     end
-    handle_transaction(sql, s)
+    handle_transaction(sql, [timeout: Keyword.get(opts, :timeout, 5000)], s)
   end
 
   defp refined_info(prepared_info) do
@@ -125,10 +126,10 @@ defmodule Sqlite.DbConnection.Protocol do
   defp maybe_atom_to_lc_string(nil), do: nil
   defp maybe_atom_to_lc_string(item), do: item |> to_string |> String.downcase
 
-  defp handle_execute(%Query{statement: sql}, params, _sync, _opts, s) do
+  defp handle_execute(%Query{statement: sql}, params, _sync, opts, s) do
     # Note that we rely on Sqlitex.Server to cache the prepared statement,
     # so we can simply refer to the original SQL statement here.
-    case run_stmt(sql, params, s) do
+    case run_stmt(sql, params, opts, s) do
       {:ok, result} ->
         {:ok, result, s}
       other ->
@@ -145,10 +146,16 @@ defmodule Sqlite.DbConnection.Protocol do
                                         message: to_string(message)}, s}
   end
 
-  defp run_stmt(query, params, s) do
-    opts = [decode: :manual, types: true, bind: params]
+  defp run_stmt(query, params, opts, s) do
+    query_opts = [
+      timeout: Keyword.get(opts, :timeout, 5000),
+      decode: :manual,
+      types: true,
+      bind: params
+    ]
+
     command = command_from_sql(query)
-    case query_rows(s.db, to_string(query), opts) do
+    case query_rows(s.db, to_string(query), query_opts) do
       {:ok, %{rows: raw_rows, columns: raw_column_names}} ->
         {rows, num_rows, column_names} = case {raw_rows, raw_column_names} do
           {_, []} -> {nil, get_changes_count(s.db, command), nil}
@@ -160,6 +167,8 @@ defmodule Sqlite.DbConnection.Protocol do
                                           command: command}}
       {:error, {_sqlite_errcode, _message}} = err ->
         sqlite_error(err, s)
+      {:error, %Sqlite.DbConnection.Error{} = err} ->
+        {:error, err, s}
       {:error, :args_wrong_length} ->
         {:error,
          %ArgumentError{message: "parameters must match number of placeholders in query"},
@@ -193,8 +202,8 @@ defmodule Sqlite.DbConnection.Protocol do
     String.to_atom(List.first(words))
   end
 
-  defp handle_transaction(stmt, s) do
-    {:ok, _rows} = query_rows(s.db, stmt, into: :raw_list)
+  defp handle_transaction(stmt, opts, s) do
+    {:ok, _rows} = query_rows(s.db, stmt, Keyword.merge(opts, [into: :raw_list]))
     command = command_from_sql(stmt)
     result = %Sqlite.DbConnection.Result{rows: nil,
                                          num_rows: nil,
@@ -207,8 +216,10 @@ defmodule Sqlite.DbConnection.Protocol do
     try do
       Sqlitex.Server.query_rows(db, stmt, opts)
     catch
-      :exit, _ ->
-        {:raise, %Sqlite.DbConnection.Error{message: "Disconnected"}}
+      :exit, {:timeout, _gen_server_call} ->
+        {:error, %Sqlite.DbConnection.Error{message: "Timeout"}}
+      :exit, _ex ->
+        {:error, %Sqlite.DbConnection.Error{message: "Disconnected"}}
     end
   end
 end

config/dogma.exs

@@ -29,4 +29,8 @@ defimpl Enumerable, for: Sqlite.DbConnection.Stream do
   def count(_) do
     {:error, __MODULE__}
   end
+
+  def slice(_) do
+    {:error, __MODULE__}
+  end
 end

lib/sqlite_db_connection/protocol.ex

@@ -565,10 +565,10 @@ if Code.ensure_loaded?(Sqlitex.Server) do
 
     # DDL
 
-    alias Ecto.Migration.Table
+    alias Ecto.Migration.Constraint
     alias Ecto.Migration.Index
     alias Ecto.Migration.Reference
-    alias Ecto.Migration.Constraint
+    alias Ecto.Migration.Table
 
     @drops [:drop, :drop_if_exists]