Add snapshot test of join with values query

Author: spicychickensauce

test/ecto/adapters/sqlite3/connection/join_test.exs

@@ -135,11 +135,11 @@ defmodule Ecto.Adapters.SQLite3.Connection.JoinTest do
     end
   end
 
-  test "join with values is not supported" do
-    assert_raise Ecto.QueryError, fn ->
-      rows = [%{x: 1, y: 1}, %{x: 2, y: 2}]
-      types = %{x: :integer, y: :integer}
+  test "join with values" do
+    rows = [%{x: 1, y: 1}, %{x: 2, y: 2}]
+    types = %{x: :integer, y: :integer}
 
+    query =
       Schema
       |> join(
         :inner,
@@ -149,8 +149,11 @@ defmodule Ecto.Adapters.SQLite3.Connection.JoinTest do
       )
       |> select([p, q], {p.id, q.x})
       |> plan()
-      |> all()
-    end
+
+    assert ~s{SELECT s0."id", v1."x" FROM "schema" AS s0 } <>
+             ~s{INNER JOIN (WITH xxx(y, x) AS (VALUES (?,?),(?,?)) SELECT * FROM xxx) AS v1 } <>
+             ~s{ON (v1."x" = s0."x") AND (v1."y" = s0."y")} ==
+             all(query)
   end
 
   test "join with fragment" do