Make drop mode optional (#57)

* Re-enable integrations tests
  This was accidentally disabled after cleaning up the workflow.
* Make drop mode optional
  Fixes #56 and prepares for future addition.

Author: warmwaffles

.github/workflows/ci.yml

@@ -53,3 +53,4 @@ jobs:
       - run: mix deps.compile
       - run: mix compile
       - run: mix test
+      - run: EXQLITE_INTEGRATION=true mix test --trace

lib/ecto/adapters/sqlite3/connection.ex

@@ -377,7 +377,7 @@ defmodule Ecto.Adapters.SQLite3.Connection do
   end
 
   @impl true
-  def execute_ddl({:drop, %Table{} = table, _mode}) do
+  def execute_ddl({:drop, %Table{} = table}) do
     [
       [
         "DROP TABLE ",
@@ -387,7 +387,12 @@ defmodule Ecto.Adapters.SQLite3.Connection do
   end
 
   @impl true
-  def execute_ddl({:drop_if_exists, %Table{} = table, _mode}) do
+  def execute_ddl({:drop, %Table{} = table, _mode}) do
+    execute_ddl({:drop, table})
+  end
+
+  @impl true
+  def execute_ddl({:drop_if_exists, %Table{} = table}) do
     [
       [
         "DROP TABLE IF EXISTS ",
@@ -396,6 +401,11 @@ defmodule Ecto.Adapters.SQLite3.Connection do
     ]
   end
 
+  @impl true
+  def execute_ddl({:drop_if_exists, %Table{} = table, _mode}) do
+    execute_ddl({:drop_if_exists, table})
+  end
+
   @impl true
   def execute_ddl({:alter, %Table{} = table, changes}) do
     Enum.map(changes, fn change ->
@@ -449,7 +459,7 @@ defmodule Ecto.Adapters.SQLite3.Connection do
   end
 
   @impl true
-  def execute_ddl({:drop, %Index{} = index, _mode}) do
+  def execute_ddl({:drop, %Index{} = index}) do
     [
       [
         "DROP INDEX ",
@@ -459,7 +469,12 @@ defmodule Ecto.Adapters.SQLite3.Connection do
   end
 
   @impl true
-  def execute_ddl({:drop_if_exists, %Index{} = index, _mode}) do
+  def execute_ddl({:drop, %Index{} = index, _mode}) do
+    execute_ddl({:drop, index})
+  end
+
+  @impl true
+  def execute_ddl({:drop_if_exists, %Index{} = index}) do
     [
       [
         "DROP INDEX IF EXISTS ",
@@ -468,6 +483,11 @@ defmodule Ecto.Adapters.SQLite3.Connection do
     ]
   end
 
+  @impl true
+  def execute_ddl({:drop_if_exists, %Index{} = index, _mode}) do
+    execute_ddl({:drop_if_exists, index})
+  end
+
   @impl true
   def execute_ddl({:rename, %Table{} = current_table, %Table{} = new_table}) do
     [
@@ -552,7 +572,7 @@ defmodule Ecto.Adapters.SQLite3.Connection do
   end
 
   @impl true
-  def execute_ddl({:drop, %Index{} = index, _mode}) do
+  def execute_ddl({:drop, %Index{} = index}) do
     [
       [
         "DROP INDEX ",
@@ -562,7 +582,12 @@ defmodule Ecto.Adapters.SQLite3.Connection do
   end
 
   @impl true
-  def execute_ddl({:drop_if_exists, %Index{} = index, _mode}) do
+  def execute_ddl({:drop, %Index{} = index, _mode}) do
+    execute_ddl({:drop, index})
+  end
+
+  @impl true
+  def execute_ddl({:drop_if_exists, %Index{} = index}) do
     [
       [
         "DROP INDEX IF EXISTS ",
@@ -571,6 +596,11 @@ defmodule Ecto.Adapters.SQLite3.Connection do
     ]
   end
 
+  @impl true
+  def execute_ddl({:drop_if_exists, %Index{} = index, _mode}) do
+    execute_ddl({:drop_if_exists, index})
+  end
+
   @impl true
   def execute_ddl({:drop, %Constraint{}, _mode}) do
     raise ArgumentError, "SQLite3 does not support ALTER TABLE DROP CONSTRAINT."