Cast to appropriate type in values expression

Author: spicychickensauce

lib/ecto/adapters/sqlite3/connection.ex

@@ -1573,18 +1573,11 @@ defmodule Ecto.Adapters.SQLite3.Connection do
   end
 
   defp values_expr(types, idx) do
-    intersperse_reduce(types, ?,, idx, fn {_field, _type}, idx ->
-      # TODO: cast?
-      # {[?$, Integer.to_string(idx), ?:, ?: | tagged_to_db(type)], idx + 1}
-      {[?$, Integer.to_string(idx)], idx + 1}
+    intersperse_reduce(types, ?,, idx, fn {_field, type}, idx ->
+      {[?$, Integer.to_string(idx), ?:, ?: | column_type(type, nil)], idx + 1}
     end)
   end
 
-  # defp tagged_to_db(:id), do: "bigint"
-  # defp tagged_to_db(:integer), do: "bigint"
-  # defp tagged_to_db({:array, type}), do: [tagged_to_db(type), ?[, ?]]
-  # defp tagged_to_db(type), do: ecto_to_db(type)
-
   def interval(_, "microsecond", _sources) do
     raise ArgumentError,
           "SQLite does not support microsecond precision in datetime intervals"

test/ecto/adapters/sqlite3/connection/join_test.exs

@@ -158,7 +158,8 @@ defmodule Ecto.Adapters.SQLite3.Connection.JoinTest do
     col_names = Map.keys(types) |> Enum.join(", ")
 
     assert ~s{SELECT s0."id", v1."x" FROM "schema" AS s0 } <>
-             ~s{INNER JOIN (WITH temp_78027(#{col_names}) AS (VALUES ($1,$2),($3,$4)) SELECT * FROM temp_78027) AS v1 } <>
+             ~s{INNER JOIN (WITH temp_78027(#{col_names}) AS (VALUES ($1::INTEGER,$2::INTEGER),($3::INTEGER,$4::INTEGER)) } <>
+             ~s{SELECT * FROM temp_78027) AS v1 } <>
              ~s{ON (v1."x" = s0."x") AND (v1."y" = s0."y")} ==
              all(query)
   end