@@ -20,8 +20,7 @@ Add `nebulex_redis_adapter` to your list of dependencies in `mix.exs`:
2020``` elixir
2121defp deps do
2222 [
23- {:nebulex , " ~> 1.0" },
24- {:nebulex_redis_adapter , github: " cabol/nebulex_redis_adapter" }
23+ {:nebulex_redis_adapter , " ~> 1.0" }
2524 ]
2625end
2726```
@@ -115,13 +114,38 @@ host and port for each proxy.
115114
116115## Testing
117116
118- Before to run the tests, ensure you have Redis up and running on ** localhiost**
119- and port ** 6379** . Then run:
117+ First of all, ensure you have Redis up and running on ** localhiost**
118+ and port ** 6379** (default host and port).
119+
120+ Since ` NebulexRedisAdapter ` uses the support modules and shared tests from
121+ Nebulex and by default its ` test ` folder is not included within the ` hex `
122+ dependency, it is necessary to fetch ` :nebulex ` dependency directly from GtiHub.
123+ This is done by setting the environment variable ` NBX_TEST ` , like so:
124+
125+ ```
126+ $ export NBX_TEST=true
127+ ```
128+
129+ Fetch deps:
130+
131+ ```
132+ $ mix deps.get
133+ ```
134+
135+ Now we can run the tests:
120136
121137```
122138$ mix test
123139```
124140
141+ Running tests with coverage:
142+
143+ ```
144+ $ mix coveralls.html
145+ ```
146+
147+ You can find the coverage report within ` cover/excoveralls.html ` .
148+
125149## Benchmarks
126150
127151Benchmarks were added using [ benchee] ( https://github.com/PragTob/benchee ) ;
@@ -130,9 +154,34 @@ to learn more, see the [benchmarks](./benchmarks) directory.
130154To run the benchmarks:
131155
132156```
133- $ mix run benchmarks/benchmark.exs
157+ $ mix deps.get && mix run benchmarks/benchmark.exs
134158```
135159
160+ ## Contributing
161+
162+ Contributions to Nebulex are very welcome and appreciated!
163+
164+ Use the [ issue tracker] ( https://github.com/cabol/nebulex_redis_adapter/issues )
165+ for bug reports or feature requests. Open a
166+ [ pull request] ( https://github.com/cabol/nebulex_redis_adapter/pulls )
167+ when you are ready to contribute.
168+
169+ When submitting a pull request you should not update the [ CHANGELOG.md] ( CHANGELOG.md ) ,
170+ and also make sure you test your changes thoroughly, include unit tests
171+ alongside new or changed code.
172+
173+ Before to submit a PR it is highly recommended to run:
174+
175+ * ` export NBX_TEST=true ` to fetch Nebulex from GH directly and be able to
176+ re-use shared tests.
177+ * ` mix test ` to run tests
178+ * ` mix coveralls.html && open cover/excoveralls.html ` to run tests and check
179+ out code coverage (expected 100%).
180+ * ` mix format && mix credo --strict ` to format your code properly and find code
181+ style issues
182+ * ` mix dialyzer ` to run dialyzer for type checking; might take a while on the
183+ first invocation
184+
136185## Copyright and License
137186
138187Copyright (c) 2018, Carlos Bolaños.
0 commit comments