fix: remove heuristics and just default to no workspace folders

Author: doorgan

apps/expert/lib/expert/state.ex

@@ -63,16 +63,10 @@ defmodule Expert.State do
     response = initialize_result()
 
     projects =
-      case event.workspace_folders do
-        nil ->
-          find_projects(event.root_uri)
-
-        _ ->
-          for %{uri: uri} <- event.workspace_folders,
-              project = Project.new(uri),
-              project.mix_project? do
-            project
-          end
+      for %{uri: uri} <- event.workspace_folders || [],
+          project = Project.new(uri),
+          project.mix_project? do
+        project
       end
 
     ActiveProjects.set_projects(projects)
@@ -257,7 +251,7 @@ defmodule Expert.State do
 
   def apply(%__MODULE__{} = state, %GenLSP.Notifications.TextDocumentDidSave{params: params}) do
     uri = params.text_document.uri
-    project = Forge.Project.project_for_uri(state.configuration.projects, uri)
+    project = Forge.Project.project_for_uri(ActiveProjects.projects(), uri)
 
     case Document.Store.save(uri) do
       :ok ->
@@ -282,7 +276,7 @@ defmodule Expert.State do
   end
 
   def apply(%__MODULE__{} = state, %Notifications.WorkspaceDidChangeWatchedFiles{params: params}) do
-    for project <- state.configuration.projects,
+    for project <- ActiveProjects.projects(),
         change <- params.changes do
       params = filesystem_event(project: Project, uri: change.uri, event_type: change.type)
       EngineApi.broadcast(project, params)

apps/expert/test/expert/expert_test.exs

@@ -239,9 +239,7 @@ defmodule ExpertTest do
 
     test "supports missing workspace_folders in the request", %{
       client: client,
-      project_root: project_root,
-      main_project: main_project,
-      secondary_project: secondary_project
+      project_root: project_root
     } do
       assert :ok =
                request(
@@ -253,13 +251,7 @@ defmodule ExpertTest do
         "capabilities" => %{"workspace" => %{"workspaceFolders" => %{"supported" => true}}}
       })
 
-      assert [_, _] = projects = Expert.ActiveProjects.projects()
-
-      for project <- projects do
-        assert project.root_uri in [main_project.root_uri, secondary_project.root_uri]
-
-        assert_project_alive?(project)
-      end
+      assert [] = Expert.ActiveProjects.projects()
     end
   end