Fix dialyzer issues

Author: doorgan

apps/engine/lib/engine/engine/code_action.ex

@@ -9,18 +9,9 @@ defmodule Engine.CodeAction do
 
   defstruct [:title, :kind, :changes, :uri]
 
-  @type code_action_kind ::
-          :empty
-          | :quick_fix
-          | :refactor
-          | :refactor_extract
-          | :refactor_inline
-          | :refactor_rewrite
-          | :source
-          | :source_organize_imports
-          | :source_fix_all
+  @type code_action_kind :: GenLSP.Enumerations.CodeActionKind.t()
 
-  @type trigger_kind :: :invoked | :automatic
+  @type trigger_kind :: GenLSP.Enumerations.CodeActionTriggerKind.t()
 
   @type t :: %__MODULE__{
           title: String.t(),

apps/engine/lib/engine/engine/code_action/handlers/add_alias.ex

@@ -69,7 +69,7 @@ defmodule Engine.CodeAction.Handlers.AddAlias do
         CodeAction.new(
           analysis.document.uri,
           "alias #{Formats.module(potential_alias_module)}",
-          :quick_fix,
+          CodeActionKind.quick_fix(),
           changes
         )
     end

apps/engine/lib/engine/engine/code_action/handlers/organize_aliases.ex

@@ -24,7 +24,15 @@ defmodule Engine.CodeAction.Handlers.OrganizeAliases do
         []
       else
         changes = Changes.new(doc, edits)
-        [CodeAction.new(doc.uri, "Organize aliases", :source_organize_imports, changes)]
+
+        [
+          CodeAction.new(
+            doc.uri,
+            "Organize aliases",
+            CodeActionKind.source_organize_imports(),
+            changes
+          )
+        ]
       end
     else
       _ ->

apps/engine/lib/engine/engine/code_action/handlers/remove_unused_alias.ex

@@ -52,7 +52,14 @@ defmodule Engine.CodeAction.Handlers.RemoveUnusedAlias do
       case to_edit(document, range.start, diagnostic) do
         {:ok, module_name, edit} ->
           changes = Changes.new(document, [edit])
-          action = CodeAction.new(document.uri, "Remove alias #{module_name}", :source, changes)
+
+          action =
+            CodeAction.new(
+              document.uri,
+              "Remove alias #{module_name}",
+              Enumerations.CodeActionKind.source(),
+              changes
+            )
 
           [action | acc]
 

apps/engine/lib/engine/engine/code_action/handlers/replace_remote_function.ex

@@ -41,7 +41,14 @@ defmodule Engine.CodeAction.Handlers.ReplaceRemoteFunction do
       case apply_transform(doc, line_number, module, function, suggestion) do
         {:ok, edits} ->
           changes = Changes.new(doc, edits)
-          code_action = CodeAction.new(doc.uri, "Rename to #{suggestion}", :quick_fix, changes)
+
+          code_action =
+            CodeAction.new(
+              doc.uri,
+              "Rename to #{suggestion}",
+              CodeActionKind.quick_fix(),
+              changes
+            )
 
           [code_action | acc]
 

apps/engine/lib/engine/engine/code_action/handlers/replace_with_underscore.ex

@@ -15,7 +15,13 @@ defmodule Engine.CodeAction.Handlers.ReplaceWithUnderscore do
     Enum.reduce(diagnostics, [], fn %Diagnostic{} = diagnostic, acc ->
       with {:ok, variable_name, line_number} <- extract_variable_and_line(diagnostic),
            {:ok, changes} <- to_changes(doc, line_number, variable_name) do
-        action = CodeAction.new(doc.uri, "Rename to _#{variable_name}", :quick_fix, changes)
+        action =
+          CodeAction.new(
+            doc.uri,
+            "Rename to _#{variable_name}",
+            CodeActionKind.quick_fix(),
+            changes
+          )
 
         [action | acc]
       else

apps/expert/lib/expert.ex

@@ -25,14 +25,14 @@ defmodule Expert do
   @dialyzer {:nowarn_function, apply_to_state: 2}
 
   @spec server_request(
-          Requests.request(),
-          (Requests.request(), {:ok, any()} | {:error, term()} -> term())
+          term(),
+          (term(), {:ok, any()} | {:error, term()} -> term())
         ) :: :ok
   def server_request(request, on_response) when is_function(on_response, 2) do
     GenServer.call(__MODULE__, {:server_request, request, on_response})
   end
 
-  @spec server_request(Requests.request()) :: :ok
+  @spec server_request(term()) :: :ok
   def server_request(request) do
     server_request(request, fn _, _ -> :ok end)
   end

apps/expert/lib/expert/configuration.ex

@@ -75,9 +75,9 @@ defmodule Expert.Configuration do
     apply_config_change(config, default_config())
   end
 
-  @spec on_change(t, DidChangeConfiguration.t()) ::
+  @spec on_change(t, WorkspaceDidChangeConfiguration.t()) ::
           {:ok, t}
-          | {:ok, t, Requests.RegisterCapability.t()}
+          | {:ok, t, Requests.ClientRegisterCapability.t()}
   def on_change(%__MODULE__{} = old_config, :defaults) do
     apply_config_change(old_config, default_config())
   end

apps/expert/lib/expert/task_queue.ex

@@ -126,6 +126,8 @@ defmodule Expert.TaskQueue do
       Transport.write(%{id: id, error: error})
     end
 
+    @dialyzer {:nowarn_function, map_code: 1}
+
     defp map_code(:parse_error), do: ErrorCodes.parse_error()
     defp map_code(:invalid_request), do: ErrorCodes.invalid_request()
     defp map_code(:method_not_found), do: ErrorCodes.method_not_found()

apps/expert/lib/expert/transport/std_io.ex

@@ -81,6 +81,10 @@ defmodule Expert.Transport.StdIO do
     dump_lsp(request)
   end
 
+  # Dialyzer complains about Schematic.dump not existing, but it does
+  # This will be removed by #20 anyways
+  @dialyzer {:nowarn_function, dump_lsp: 1}
+
   defp dump_lsp(%module{} = item) do
     with {:ok, item} <- Convert.to_lsp(item) do
       Schematic.dump(module.schematic(), item)