fix: revert "feat: epmdless deployments (#167)" (#180)

This reverts commit 9cfb5cc.

Author: doorgan

apps/expert/lib/expert/engine_node.ex

@@ -29,21 +29,17 @@ defmodule Expert.EngineNode do
 
     def start(%__MODULE__{} = state, paths, from) do
       this_node = inspect(Node.self())
-      dist_port = Expert.EPMD.dist_port()
-
-      args =
-        [
-          "--erl",
-          "-start_epmd false -erl_epmd_port #{dist_port} -dist_listen false",
-          "--name",
-          Project.node_name(state.project),
-          "--cookie",
-          state.cookie,
-          "--no-halt",
-          "-e",
-          "Node.connect(#{this_node}); IO.puts(\"ok\")"
-          | path_append_arguments(paths)
-        ]
+
+      args = [
+        "--name",
+        Project.node_name(state.project),
+        "--cookie",
+        state.cookie,
+        "--no-halt",
+        "-e",
+        "Node.connect(#{this_node})"
+        | path_append_arguments(paths)
+      ]
 
       case Expert.Port.open_elixir(state.project, args: args) do
         {:error, :no_elixir, message} ->
@@ -121,6 +117,7 @@ defmodule Expert.EngineNode do
   use GenServer
 
   def start(project) do
+    :ok = ensure_epmd_started()
     start_net_kernel(project)
 
     node_name = Project.node_name(project)
@@ -144,6 +141,16 @@ defmodule Expert.EngineNode do
     :rpc.call(node, Engine, :ensure_apps_started, [])
   end
 
+  defp ensure_epmd_started do
+    case System.cmd("epmd", ~w(-daemon)) do
+      {"", 0} ->
+        :ok
+
+      _ ->
+        {:error, :epmd_failed}
+    end
+  end
+
   if Mix.env() == :test do
     # In test environment, Expert depends on the Engine app, so we look for it
     # in the expert build path.
@@ -284,7 +291,7 @@ defmodule Expert.EngineNode do
 
   @impl true
   def handle_call({:start, paths}, from, %State{} = state) do
-    :ok = :net_kernel.monitor_nodes(true, node_type: :all)
+    :ok = :net_kernel.monitor_nodes(true, node_type: :visible)
     Process.send_after(self(), :maybe_start_timeout, @start_timeout)
 
     case State.start(state, paths, from) do