Skip to content

Commit d712c66

Browse files
authored
Merge pull request #1 from laurencegill/add_clickhouse_serviceaccount_support
Implement serviceAccount support for clickhouse pod
2 parents 566ad13 + 44659ac commit d712c66

File tree

5 files changed

+40
-0
lines changed

5 files changed

+40
-0
lines changed

charts/posthog/ALL_VALUES.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -620,7 +620,11 @@ The following table lists the configurable parameters of the PostHog chart and t
620620
| clickhouse.image.tag | string | `"22.8.11.15"` | ClickHouse image tag. Note: PostHog does not support all versions of ClickHouse. Please override the default only if you know what you are doing. |
621621
| clickhouse.image.pullPolicy | string | `"IfNotPresent"` | Image pull policy |
622622
| clickhouse.image.pullSecrets | list | `[]` | |
623+
| clickhouse.serviceAccount.create | bool | `false` | serviceAccount should be created - boolean |
624+
| clickhouse.serviceAccount.name | string | `nil` | name of the serviceAccount |
625+
| clickhouse.serviceAccount.annotations | object | `{}` | Configures annotation for the serviceAccount |
623626
| clickhouse.tolerations | list | `[]` | Toleration labels for clickhouse pod assignment |
627+
| clickhouse.serviceAccountName | string | `""` | Override serviceAccountName for clickhouse pod Note: this will override serviceAccount.name if both are set |
624628
| clickhouse.affinity | object | `{}` | Affinity settings for clickhouse pod |
625629
| clickhouse.resources | object | `{}` | Clickhouse resource requests/limits. See more at http://kubernetes.io/docs/user-guide/compute-resources/ |
626630
| clickhouse.securityContext.enabled | bool | `true` | |

charts/posthog/templates/_helpers.tpl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,12 @@ Create the name of the service account to use
178178
{{- end -}}
179179
{{- end -}}
180180

181+
{{- define "posthog.clickhouse.serviceAccount" -}}
182+
{{- if .Values.clickhouse.serviceAccount.create -}}
183+
{{ default "clickhouse-serviceaccount" .Values.clickhouse.serviceAccount.name }}
184+
{{- end -}}
185+
{{- end -}}
186+
181187
{{- define "posthog.helmOperation" -}}
182188
{{- if .Release.IsUpgrade -}}
183189
upgrade
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
{{- if .Values.clickhouse.enabled }}
2+
{{- if .Values.clickhouse.serviceAccount.create -}}
3+
apiVersion: v1
4+
kind: ServiceAccount
5+
metadata:
6+
name: {{ template "posthog.clickhouse.serviceAccount" . }}
7+
labels: {{- include "_snippet-metadata-labels-common" . | nindent 4 }}
8+
{{- if .Values.clickhouse.serviceAccount.annotations }}
9+
annotations: {{ toYaml .Values.clickhouse.serviceAccount.annotations | nindent 4 }}
10+
{{- end }}
11+
{{- end -}}
12+
{{- end -}}

charts/posthog/templates/clickhouse_instance.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,11 @@ spec:
7171
podDistribution: {{ toYaml .Values.clickhouse.podDistribution | nindent 12 }}
7272
{{- end}}
7373
spec:
74+
{{- if .Values.clickhouse.serviceAccountName }}
75+
serviceAccountName: {{ toYaml .Values.clickhouse.serviceAccountName | nindent 12 }}
76+
{{- else if .Values.clickhouse.serviceAccount.create }}
77+
serviceAccountName: {{ template "posthog.clickhouse.serviceAccount" . }}
78+
{{- end }}
7479
{{- if .Values.clickhouse.affinity }}
7580
affinity: {{ toYaml .Values.clickhouse.affinity | nindent 12 }}
7681
{{- end }}

charts/posthog/values.yaml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1732,8 +1732,21 @@ clickhouse:
17321732
##
17331733
pullSecrets: []
17341734

1735+
serviceAccount:
1736+
# -- Alternative serviceAccount for clickhouse pod to use
1737+
# @default autogenerated by posthog.serviceAccount
1738+
# -- serviceAccount should be created - boolean
1739+
create: false
1740+
# -- name of the serviceAccount
1741+
name:
1742+
# -- Configures annotation for the serviceAccount
1743+
annotations: {}
1744+
17351745
# -- Toleration labels for clickhouse pod assignment
17361746
tolerations: []
1747+
# -- Override serviceAccountName for clickhouse pod
1748+
# Note: this will override serviceAccount.name if both are set
1749+
serviceAccountName: ""
17371750
# -- Affinity settings for clickhouse pod
17381751
affinity: {}
17391752
# -- Clickhouse resource requests/limits. See more at http://kubernetes.io/docs/user-guide/compute-resources/

0 commit comments

Comments
 (0)