Add external-secrets support #8
Conversation
eldada
left a comment
eldada
left a comment
There was a problem hiding this comment.
Thank you so much for this PR! A great move forward 😄
Please see my comments.
| {{- if .Values.useExistingSecret }} | ||
| name: {{ .Values.existingSecretName }} | ||
| {{- else }} | ||
| name: {{ template "postfix.fullname" . }} |
There was a problem hiding this comment.
Should be name: {{ template "postfix.fullname" . }}-secret?
helm/postfix/values.yaml
Outdated
| existingSecretName: postfix | ||
|
|
||
| # e.g kuberentes-external-secrets | ||
| useExternalSecrets: false |
There was a problem hiding this comment.
Can we put this under a dedicated block like the following
externalSecret:
enabled: false
secretsBackendType: secretsManager
secretsKey: infra/postfix
README.md
Outdated
| helm/postfix | ||
| ``` | ||
|
|
||
| 1. Use kubernetes external secrets |
There was a problem hiding this comment.
Can you add a link to the ExternalSecret resource type?
There was a problem hiding this comment.
it's there a few linws above - added link to CRD.yml
| --set smtp.relayMyhostname=my.local \ | ||
| --set smtp.relayUsername=${USERNAME} \ | ||
| --set useExternalSecrets=true \ | ||
| --set ExternalSecretsBackendType=secretsManager \ |
There was a problem hiding this comment.
Need to update the example post your refactoring...
There was a problem hiding this comment.
Please fix this so I can merge. Looks like this is the last issue @hagzag .
eldada
left a comment
eldada
left a comment
There was a problem hiding this comment.
Fix the last comment in the README.md
|
@hagzag ? |
2 participants
@eldada looked useful ;) - added some support for secrets.