fix: nil reference in api.kibana_synthetics.go:418 in case of unmarshable arrays (#1320)

biscout42 · web-flow · commit 789780d35179 · 2025-09-22T12:55:53.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,7 @@
 - Add support for `data_view_id` in the `elasticstack_kibana_slo` resource ([#1305](https://github.com/elastic/terraform-provider-elasticstack/pull/1305))
 - Add support for `unenrollment_timeout` in `elasticstack_fleet_agent_policy` ([#1169](https://github.com/elastic/terraform-provider-elasticstack/issues/1169))
 - Handle default value for `allow_restricted_indices` in `elasticstack_elasticsearch_security_api_key` ([#1315](https://github.com/elastic/terraform-provider-elasticstack/pull/1315))
+- Fixed `nil` reference in kibana synthetics API client in case of response errors ([#1320](https://github.com/elastic/terraform-provider-elasticstack/pull/1320))
 
 ## [0.11.17] - 2025-07-21
 
diff --git a/libs/go-kibana-rest/docker-compose.yml b/libs/go-kibana-rest/docker-compose.yml
@@ -1,6 +1,6 @@
 services:
   elasticsearch:
-    image: docker.elastic.co/elasticsearch/elasticsearch:9.1.3@sha256:d620e80b7222e32eff42ac0fc614a0a5753f6ce9859df33b9ddea49c3bf5fb01
+    image: docker.elastic.co/elasticsearch/elasticsearch:9.1.2@sha256:d1a8016cf55be8ffec635ed69f5a9acb0c459db35b46a4549ec5b2847a2f170a
     environment:
       cluster.name: test
       discovery.type: single-node
@@ -11,7 +11,7 @@ services:
     ports:
       - "9200:9200/tcp"
   set-kibana-password:
-    image: docker.elastic.co/kibana/kibana:9.1.3@sha256:26792c8e4a68ba0bff3efcc46755f60bf36bb16b2431014c210f2546ca1819ad
+    image: docker.elastic.co/kibana/kibana:9.0.3@sha256:c4c00a485fbc3619d8373f3bc74e9dd5b5a34380ef50442be4366e8fb57cd50a
     restart: on-failure
     links:
       - elasticsearch
@@ -22,7 +22,7 @@ services:
       elasticsearch:
         condition: service_started
   kibana:
-    image: docker.elastic.co/kibana/kibana:9.1.3@sha256:26792c8e4a68ba0bff3efcc46755f60bf36bb16b2431014c210f2546ca1819ad
+    image: docker.elastic.co/kibana/kibana:9.0.3@sha256:c4c00a485fbc3619d8373f3bc74e9dd5b5a34380ef50442be4366e8fb57cd50a
     environment:
       SERVER_NAME: kibana
       ELASTICSEARCH_HOSTS: http://es:9200
diff --git a/libs/go-kibana-rest/kbapi/api.kibana_logstash_pipeline.go b/libs/go-kibana-rest/kbapi/api.kibana_logstash_pipeline.go
@@ -73,7 +73,7 @@ func newKibanaLogstashPipelineGetFunc(c *resty.Client) KibanaLogstashPipelineGet
 			if resp.StatusCode() == 404 {
 				return nil, nil
 			}
-			return nil, NewAPIError(resp.StatusCode(), resp.Status())
+			return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())
 		}
 		logstashPipeline := &LogstashPipeline{}
 		err = json.Unmarshal(resp.Body(), logstashPipeline)
@@ -97,7 +97,7 @@ func newKibanaLogstashPipelineListFunc(c *resty.Client) KibanaLogstashPipelineLi
 		}
 		log.Debug("Response: ", resp)
 		if resp.StatusCode() >= 300 {
-			return nil, NewAPIError(resp.StatusCode(), resp.Status())
+			return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())
 		}
 		logstashPipelinesList := &LogstashPipelinesList{}
 		err = json.Unmarshal(resp.Body(), logstashPipelinesList)
@@ -140,7 +140,7 @@ func newKibanaLogstashPipelineCreateOrUpdateFunc(c *resty.Client) KibanaLogstash
 
 		log.Debug("Response: ", resp)
 		if resp.StatusCode() >= 300 {
-			return nil, NewAPIError(resp.StatusCode(), resp.Status())
+			return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())
 		}
 
 		// Retrive the object to return it
@@ -174,7 +174,7 @@ func newKibanaLogstashPipelineDeleteFunc(c *resty.Client) KibanaLogstashPipeline
 		}
 		log.Debug("Response: ", resp)
 		if resp.StatusCode() >= 300 {
-			return NewAPIError(resp.StatusCode(), resp.Status())
+			return NewAPIError(resp.StatusCode(), "%s", resp.Status())
 		}
 
 		return nil
diff --git a/libs/go-kibana-rest/kbapi/api.kibana_role_management.go b/libs/go-kibana-rest/kbapi/api.kibana_role_management.go
@@ -100,7 +100,7 @@ func newKibanaRoleManagementGetFunc(c *resty.Client) KibanaRoleManagementGet {
 			if resp.StatusCode() == 404 {
 				return nil, nil
 			}
-			return nil, NewAPIError(resp.StatusCode(), resp.Status())
+			return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())
 		}
 		kibanaRole := &KibanaRole{}
 		err = json.Unmarshal(resp.Body(), kibanaRole)
@@ -124,7 +124,7 @@ func newKibanaRoleManagementListFunc(c *resty.Client) KibanaRoleManagementList {
 		}
 		log.Debug("Response: ", resp)
 		if resp.StatusCode() >= 300 {
-			return nil, NewAPIError(resp.StatusCode(), resp.Status())
+			return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())
 		}
 		kibanaRoles := make(KibanaRoles, 0, 1)
 		err = json.Unmarshal(resp.Body(), &kibanaRoles)
@@ -165,7 +165,7 @@ func newKibanaRoleManagementCreateOrUpdateFunc(c *resty.Client) KibanaRoleManage
 		}
 		log.Debug("Response: ", resp)
 		if resp.StatusCode() >= 300 {
-			return nil, NewAPIError(resp.StatusCode(), resp.Status())
+			return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())
 		}
 
 		// Retrive the object to return it
@@ -197,7 +197,7 @@ func newKibanaRoleManagementDeleteFunc(c *resty.Client) KibanaRoleManagementDele
 		}
 		log.Debug("Response: ", resp)
 		if resp.StatusCode() >= 300 {
-			return NewAPIError(resp.StatusCode(), resp.Status())
+			return NewAPIError(resp.StatusCode(), "%s", resp.Status())
 		}
 
 		return nil
diff --git a/libs/go-kibana-rest/kbapi/api.kibana_save_object.go b/libs/go-kibana-rest/kbapi/api.kibana_save_object.go
@@ -85,7 +85,7 @@ func newKibanaSavedObjectGetFunc(c *resty.Client) KibanaSavedObjectGet {
 			if resp.StatusCode() == 404 {
 				return nil, nil
 			}
-			return nil, NewAPIError(resp.StatusCode(), resp.Status())
+			return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())
 
 		}
 		var data map[string]interface{}
@@ -165,7 +165,7 @@ func newKibanaSavedObjectFindFunc(c *resty.Client) KibanaSavedObjectFind {
 			if resp.StatusCode() == 404 {
 				return nil, nil
 			}
-			return nil, NewAPIError(resp.StatusCode(), resp.Status())
+			return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())
 
 		}
 		var data map[string]interface{}
@@ -214,7 +214,7 @@ func newKibanaSavedObjectCreateFunc(c *resty.Client) KibanaSavedObjectCreate {
 		}
 		log.Debug("Response: ", resp)
 		if resp.StatusCode() >= 300 {
-			return nil, NewAPIError(resp.StatusCode(), resp.Status())
+			return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())
 		}
 		var dataResponse map[string]interface{}
 		err = json.Unmarshal(resp.Body(), &dataResponse)
@@ -263,7 +263,7 @@ func newKibanaSavedObjectUpdateFunc(c *resty.Client) KibanaSavedObjectUpdate {
 		}
 		log.Debug("Response: ", resp)
 		if resp.StatusCode() >= 300 {
-			return nil, NewAPIError(resp.StatusCode(), resp.Status())
+			return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())
 		}
 		var dataResponse map[string]interface{}
 		err = json.Unmarshal(resp.Body(), &dataResponse)
@@ -304,7 +304,7 @@ func newKibanaSavedObjectDeleteFunc(c *resty.Client) KibanaSavedObjectDelete {
 		}
 		log.Debug("Response: ", resp)
 		if resp.StatusCode() >= 300 {
-			return NewAPIError(resp.StatusCode(), resp.Status())
+			return NewAPIError(resp.StatusCode(), "%s", resp.Status())
 		}
 		var dataResponse map[string]interface{}
 		err = json.Unmarshal(resp.Body(), &dataResponse)
@@ -356,7 +356,7 @@ func newKibanaSavedObjectExportFunc(c *resty.Client) KibanaSavedObjectExport {
 		}
 		log.Debug("Response: ", resp)
 		if resp.StatusCode() >= 300 {
-			return nil, NewAPIError(resp.StatusCode(), resp.Status())
+			return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())
 		}
 
 		data := resp.Body()
@@ -396,7 +396,7 @@ func newKibanaSavedObjectImportFunc(c *resty.Client) KibanaSavedObjectImport {
 		}
 		log.Debug("Response: ", resp)
 		if resp.StatusCode() >= 300 {
-			return nil, NewAPIError(resp.StatusCode(), resp.Status())
+			return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())
 		}
 		var dataResponse map[string]interface{}
 		err = json.Unmarshal(resp.Body(), &dataResponse)
diff --git a/libs/go-kibana-rest/kbapi/api.kibana_shorten_url.go b/libs/go-kibana-rest/kbapi/api.kibana_shorten_url.go
@@ -63,7 +63,7 @@ func newKibanaShortenURLCreateFunc(c *resty.Client) KibanaShortenURLCreate {
 
 		log.Debug("Response: ", resp)
 		if resp.StatusCode() >= 300 {
-			return nil, NewAPIError(resp.StatusCode(), resp.Status())
+			return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())
 		}
 
 		shortenURLResponse := &ShortenURLResponse{}
diff --git a/libs/go-kibana-rest/kbapi/api.kibana_spaces.go b/libs/go-kibana-rest/kbapi/api.kibana_spaces.go
@@ -87,7 +87,7 @@ func newKibanaSpaceGetFunc(c *resty.Client) KibanaSpaceGet {
 			if resp.StatusCode() == 404 {
 				return nil, nil
 			}
-			return nil, NewAPIError(resp.StatusCode(), resp.Status())
+			return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())
 
 		}
 		kibanaSpace := &KibanaSpace{}
@@ -113,7 +113,7 @@ func newKibanaSpaceListFunc(c *resty.Client) KibanaSpaceList {
 		}
 		log.Debug("Response: ", resp)
 		if resp.StatusCode() >= 300 {
-			return nil, NewAPIError(resp.StatusCode(), resp.Status())
+			return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())
 		}
 		kibanaSpaces := make(KibanaSpaces, 0, 1)
 		err = json.Unmarshal(resp.Body(), &kibanaSpaces)
@@ -148,7 +148,7 @@ func newKibanaSpaceCreateFunc(c *resty.Client) KibanaSpaceCreate {
 
 		log.Debug("Response: ", resp)
 		if resp.StatusCode() >= 300 {
-			return nil, NewAPIError(resp.StatusCode(), resp.Status())
+			return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())
 		}
 		kibanaSpace = &KibanaSpace{}
 		err = json.Unmarshal(resp.Body(), kibanaSpace)
@@ -189,7 +189,7 @@ func newKibanaSpaceCopySavedObjectsFunc(c *resty.Client) KibanaSpaceCopySavedObj
 
 		log.Debug("Response: ", resp)
 		if resp.StatusCode() >= 300 {
-			return NewAPIError(resp.StatusCode(), resp.Status())
+			return NewAPIError(resp.StatusCode(), "%s", resp.Status())
 		}
 		data := make(map[string]interface{})
 		err = json.Unmarshal(resp.Body(), &data)
@@ -205,7 +205,7 @@ func newKibanaSpaceCopySavedObjectsFunc(c *resty.Client) KibanaSpaceCopySavedObj
 			}
 		}
 		if len(errors) > 0 {
-			return NewAPIError(500, strings.Join(errors, "\n"))
+			return NewAPIError(500, "%s", strings.Join(errors, "\n"))
 		}
 
 		return nil
@@ -231,7 +231,7 @@ func newKibanaSpaceDeleteFunc(c *resty.Client) KibanaSpaceDelete {
 		log.Debug("Response: ", resp)
 		if resp.StatusCode() >= 300 {
 
-			return NewAPIError(resp.StatusCode(), resp.Status())
+			return NewAPIError(resp.StatusCode(), "%s", resp.Status())
 
 		}
 
@@ -261,7 +261,7 @@ func newKibanaSpaceUpdateFunc(c *resty.Client) KibanaSpaceUpdate {
 
 		log.Debug("Response: ", resp)
 		if resp.StatusCode() >= 300 {
-			return nil, NewAPIError(resp.StatusCode(), resp.Status())
+			return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())
 		}
 		kibanaSpace = &KibanaSpace{}
 		err = json.Unmarshal(resp.Body(), kibanaSpace)
diff --git a/libs/go-kibana-rest/kbapi/api.kibana_status.go b/libs/go-kibana-rest/kbapi/api.kibana_status.go
@@ -29,7 +29,7 @@ func newKibanaStatusGetFunc(c *resty.Client) KibanaStatusGet {
 			if resp.StatusCode() == 404 {
 				return nil, nil
 			}
-			return nil, NewAPIError(resp.StatusCode(), resp.Status())
+			return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())
 		}
 		kibanaStatus := make(KibanaStatus)
 		err = json.Unmarshal(resp.Body(), &kibanaStatus)
diff --git a/libs/go-kibana-rest/kbapi/api.kibana_synthetics.go b/libs/go-kibana-rest/kbapi/api.kibana_synthetics.go
@@ -415,6 +415,9 @@ func newKibanaSyntheticsMonitorDeleteFunc(c *resty.Client) KibanaSyntheticsMonit
 		}
 
 		result, err := unmarshal(resp, []MonitorDeleteStatus{})
+		if err != nil {
+			return nil, err
+		}
 		return *result, err
 	}
 }
@@ -481,6 +484,9 @@ func newKibanaSyntheticsParameterDeleteFunc(c *resty.Client) KibanaSyntheticsPar
 		}
 
 		result, err := unmarshal(resp, []ParameterDeleteStatus{})
+		if err != nil {
+			return nil, err
+		}
 		return *result, err
 	}
 }
@@ -503,9 +509,9 @@ func handleKibanaError(err error, resp *resty.Response) error {
 		kibanaErr := KibanaError{}
 		err := json.Unmarshal(resp.Body(), &kibanaErr)
 		if err != nil {
-			return NewAPIError(resp.StatusCode(), resp.Status(), err)
+			return NewAPIError(resp.StatusCode(), "status: %s, err: %s", resp.Status(), err)
 		}
-		return NewAPIError(resp.StatusCode(), kibanaErr.Message, kibanaErr.Error)
+		return NewAPIError(resp.StatusCode(), "message: %s, err: %s", kibanaErr.Message, kibanaErr.Error)
 	}
 	return nil
 }
diff --git a/libs/go-kibana-rest/kbapi/api.kibana_synthetics_test.go b/libs/go-kibana-rest/kbapi/api.kibana_synthetics_test.go
@@ -444,6 +444,7 @@ func (s *KBAPITestSuite) TestKibanaSyntheticsPrivateLocationAPI() {
 				created, err := pAPI.Create(ctx, cfg)
 
 				assert.NoError(s.T(), err)
+				assert.NotNil(s.T(), created)
 				assert.Equal(s.T(), created.Label, cfg.Label)
 				assert.Equal(s.T(), created.AgentPolicyId, cfg.AgentPolicyId)
 

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ func newKibanaLogstashPipelineGetFunc(c *resty.Client) KibanaLogstashPipelineGet`
`73`	`73`	`if resp.StatusCode() == 404 {`
`74`	`74`	`return nil, nil`
`75`	`75`	`}`
`76`		`- return nil, NewAPIError(resp.StatusCode(), resp.Status())`
	`76`	`+ return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`77`	`77`	`}`
`78`	`78`	`logstashPipeline := &LogstashPipeline{}`
`79`	`79`	`err = json.Unmarshal(resp.Body(), logstashPipeline)`
`@@ -97,7 +97,7 @@ func newKibanaLogstashPipelineListFunc(c *resty.Client) KibanaLogstashPipelineLi`
`97`	`97`	`}`
`98`	`98`	`log.Debug("Response: ", resp)`
`99`	`99`	`if resp.StatusCode() >= 300 {`
`100`		`- return nil, NewAPIError(resp.StatusCode(), resp.Status())`
	`100`	`+ return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`101`	`101`	`}`
`102`	`102`	`logstashPipelinesList := &LogstashPipelinesList{}`
`103`	`103`	`err = json.Unmarshal(resp.Body(), logstashPipelinesList)`
`@@ -140,7 +140,7 @@ func newKibanaLogstashPipelineCreateOrUpdateFunc(c *resty.Client) KibanaLogstash`
`140`	`140`
`141`	`141`	`log.Debug("Response: ", resp)`
`142`	`142`	`if resp.StatusCode() >= 300 {`
`143`		`- return nil, NewAPIError(resp.StatusCode(), resp.Status())`
	`143`	`+ return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`144`	`144`	`}`
`145`	`145`
`146`	`146`	`// Retrive the object to return it`
`@@ -174,7 +174,7 @@ func newKibanaLogstashPipelineDeleteFunc(c *resty.Client) KibanaLogstashPipeline`
`174`	`174`	`}`
`175`	`175`	`log.Debug("Response: ", resp)`
`176`	`176`	`if resp.StatusCode() >= 300 {`
`177`		`- return NewAPIError(resp.StatusCode(), resp.Status())`
	`177`	`+ return NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`178`	`178`	`}`
`179`	`179`
`180`	`180`	`return nil`
Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ func newKibanaRoleManagementGetFunc(c *resty.Client) KibanaRoleManagementGet {`
`100`	`100`	`if resp.StatusCode() == 404 {`
`101`	`101`	`return nil, nil`
`102`	`102`	`}`
`103`		`- return nil, NewAPIError(resp.StatusCode(), resp.Status())`
	`103`	`+ return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`104`	`104`	`}`
`105`	`105`	`kibanaRole := &KibanaRole{}`
`106`	`106`	`err = json.Unmarshal(resp.Body(), kibanaRole)`
`@@ -124,7 +124,7 @@ func newKibanaRoleManagementListFunc(c *resty.Client) KibanaRoleManagementList {`
`124`	`124`	`}`
`125`	`125`	`log.Debug("Response: ", resp)`
`126`	`126`	`if resp.StatusCode() >= 300 {`
`127`		`- return nil, NewAPIError(resp.StatusCode(), resp.Status())`
	`127`	`+ return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`128`	`128`	`}`
`129`	`129`	`kibanaRoles := make(KibanaRoles, 0, 1)`
`130`	`130`	`err = json.Unmarshal(resp.Body(), &kibanaRoles)`
`@@ -165,7 +165,7 @@ func newKibanaRoleManagementCreateOrUpdateFunc(c *resty.Client) KibanaRoleManage`
`165`	`165`	`}`
`166`	`166`	`log.Debug("Response: ", resp)`
`167`	`167`	`if resp.StatusCode() >= 300 {`
`168`		`- return nil, NewAPIError(resp.StatusCode(), resp.Status())`
	`168`	`+ return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`169`	`169`	`}`
`170`	`170`
`171`	`171`	`// Retrive the object to return it`
`@@ -197,7 +197,7 @@ func newKibanaRoleManagementDeleteFunc(c *resty.Client) KibanaRoleManagementDele`
`197`	`197`	`}`
`198`	`198`	`log.Debug("Response: ", resp)`
`199`	`199`	`if resp.StatusCode() >= 300 {`
`200`		`- return NewAPIError(resp.StatusCode(), resp.Status())`
	`200`	`+ return NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`201`	`201`	`}`
`202`	`202`
`203`	`203`	`return nil`
Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ func newKibanaSavedObjectGetFunc(c *resty.Client) KibanaSavedObjectGet {`
`85`	`85`	`if resp.StatusCode() == 404 {`
`86`	`86`	`return nil, nil`
`87`	`87`	`}`
`88`		`- return nil, NewAPIError(resp.StatusCode(), resp.Status())`
	`88`	`+ return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`89`	`89`
`90`	`90`	`}`
`91`	`91`	`var data map[string]interface{}`
`@@ -165,7 +165,7 @@ func newKibanaSavedObjectFindFunc(c *resty.Client) KibanaSavedObjectFind {`
`165`	`165`	`if resp.StatusCode() == 404 {`
`166`	`166`	`return nil, nil`
`167`	`167`	`}`
`168`		`- return nil, NewAPIError(resp.StatusCode(), resp.Status())`
	`168`	`+ return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`169`	`169`
`170`	`170`	`}`
`171`	`171`	`var data map[string]interface{}`
`@@ -214,7 +214,7 @@ func newKibanaSavedObjectCreateFunc(c *resty.Client) KibanaSavedObjectCreate {`
`214`	`214`	`}`
`215`	`215`	`log.Debug("Response: ", resp)`
`216`	`216`	`if resp.StatusCode() >= 300 {`
`217`		`- return nil, NewAPIError(resp.StatusCode(), resp.Status())`
	`217`	`+ return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`218`	`218`	`}`
`219`	`219`	`var dataResponse map[string]interface{}`
`220`	`220`	`err = json.Unmarshal(resp.Body(), &dataResponse)`
`@@ -263,7 +263,7 @@ func newKibanaSavedObjectUpdateFunc(c *resty.Client) KibanaSavedObjectUpdate {`
`263`	`263`	`}`
`264`	`264`	`log.Debug("Response: ", resp)`
`265`	`265`	`if resp.StatusCode() >= 300 {`
`266`		`- return nil, NewAPIError(resp.StatusCode(), resp.Status())`
	`266`	`+ return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`267`	`267`	`}`
`268`	`268`	`var dataResponse map[string]interface{}`
`269`	`269`	`err = json.Unmarshal(resp.Body(), &dataResponse)`
`@@ -304,7 +304,7 @@ func newKibanaSavedObjectDeleteFunc(c *resty.Client) KibanaSavedObjectDelete {`
`304`	`304`	`}`
`305`	`305`	`log.Debug("Response: ", resp)`
`306`	`306`	`if resp.StatusCode() >= 300 {`
`307`		`- return NewAPIError(resp.StatusCode(), resp.Status())`
	`307`	`+ return NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`308`	`308`	`}`
`309`	`309`	`var dataResponse map[string]interface{}`
`310`	`310`	`err = json.Unmarshal(resp.Body(), &dataResponse)`
`@@ -356,7 +356,7 @@ func newKibanaSavedObjectExportFunc(c *resty.Client) KibanaSavedObjectExport {`
`356`	`356`	`}`
`357`	`357`	`log.Debug("Response: ", resp)`
`358`	`358`	`if resp.StatusCode() >= 300 {`
`359`		`- return nil, NewAPIError(resp.StatusCode(), resp.Status())`
	`359`	`+ return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`360`	`360`	`}`
`361`	`361`
`362`	`362`	`data := resp.Body()`
`@@ -396,7 +396,7 @@ func newKibanaSavedObjectImportFunc(c *resty.Client) KibanaSavedObjectImport {`
`396`	`396`	`}`
`397`	`397`	`log.Debug("Response: ", resp)`
`398`	`398`	`if resp.StatusCode() >= 300 {`
`399`		`- return nil, NewAPIError(resp.StatusCode(), resp.Status())`
	`399`	`+ return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`400`	`400`	`}`
`401`	`401`	`var dataResponse map[string]interface{}`
`402`	`402`	`err = json.Unmarshal(resp.Body(), &dataResponse)`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ func newKibanaShortenURLCreateFunc(c *resty.Client) KibanaShortenURLCreate {`
`63`	`63`
`64`	`64`	`log.Debug("Response: ", resp)`
`65`	`65`	`if resp.StatusCode() >= 300 {`
`66`		`- return nil, NewAPIError(resp.StatusCode(), resp.Status())`
	`66`	`+ return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`shortenURLResponse := &ShortenURLResponse{}`
Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ func newKibanaSpaceGetFunc(c *resty.Client) KibanaSpaceGet {`
`87`	`87`	`if resp.StatusCode() == 404 {`
`88`	`88`	`return nil, nil`
`89`	`89`	`}`
`90`		`- return nil, NewAPIError(resp.StatusCode(), resp.Status())`
	`90`	`+ return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`91`	`91`
`92`	`92`	`}`
`93`	`93`	`kibanaSpace := &KibanaSpace{}`
`@@ -113,7 +113,7 @@ func newKibanaSpaceListFunc(c *resty.Client) KibanaSpaceList {`
`113`	`113`	`}`
`114`	`114`	`log.Debug("Response: ", resp)`
`115`	`115`	`if resp.StatusCode() >= 300 {`
`116`		`- return nil, NewAPIError(resp.StatusCode(), resp.Status())`
	`116`	`+ return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`117`	`117`	`}`
`118`	`118`	`kibanaSpaces := make(KibanaSpaces, 0, 1)`
`119`	`119`	`err = json.Unmarshal(resp.Body(), &kibanaSpaces)`
`@@ -148,7 +148,7 @@ func newKibanaSpaceCreateFunc(c *resty.Client) KibanaSpaceCreate {`
`148`	`148`
`149`	`149`	`log.Debug("Response: ", resp)`
`150`	`150`	`if resp.StatusCode() >= 300 {`
`151`		`- return nil, NewAPIError(resp.StatusCode(), resp.Status())`
	`151`	`+ return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`152`	`152`	`}`
`153`	`153`	`kibanaSpace = &KibanaSpace{}`
`154`	`154`	`err = json.Unmarshal(resp.Body(), kibanaSpace)`
`@@ -189,7 +189,7 @@ func newKibanaSpaceCopySavedObjectsFunc(c *resty.Client) KibanaSpaceCopySavedObj`
`189`	`189`
`190`	`190`	`log.Debug("Response: ", resp)`
`191`	`191`	`if resp.StatusCode() >= 300 {`
`192`		`- return NewAPIError(resp.StatusCode(), resp.Status())`
	`192`	`+ return NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`193`	`193`	`}`
`194`	`194`	`data := make(map[string]interface{})`
`195`	`195`	`err = json.Unmarshal(resp.Body(), &data)`
`@@ -205,7 +205,7 @@ func newKibanaSpaceCopySavedObjectsFunc(c *resty.Client) KibanaSpaceCopySavedObj`
`205`	`205`	`}`
`206`	`206`	`}`
`207`	`207`	`if len(errors) > 0 {`
`208`		`- return NewAPIError(500, strings.Join(errors, "\n"))`
	`208`	`+ return NewAPIError(500, "%s", strings.Join(errors, "\n"))`
`209`	`209`	`}`
`210`	`210`
`211`	`211`	`return nil`
`@@ -231,7 +231,7 @@ func newKibanaSpaceDeleteFunc(c *resty.Client) KibanaSpaceDelete {`
`231`	`231`	`log.Debug("Response: ", resp)`
`232`	`232`	`if resp.StatusCode() >= 300 {`
`233`	`233`
`234`		`- return NewAPIError(resp.StatusCode(), resp.Status())`
	`234`	`+ return NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`235`	`235`
`236`	`236`	`}`
`237`	`237`
`@@ -261,7 +261,7 @@ func newKibanaSpaceUpdateFunc(c *resty.Client) KibanaSpaceUpdate {`
`261`	`261`
`262`	`262`	`log.Debug("Response: ", resp)`
`263`	`263`	`if resp.StatusCode() >= 300 {`
`264`		`- return nil, NewAPIError(resp.StatusCode(), resp.Status())`
	`264`	`+ return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`265`	`265`	`}`
`266`	`266`	`kibanaSpace = &KibanaSpace{}`
`267`	`267`	`err = json.Unmarshal(resp.Body(), kibanaSpace)`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ func newKibanaStatusGetFunc(c *resty.Client) KibanaStatusGet {`
`29`	`29`	`if resp.StatusCode() == 404 {`
`30`	`30`	`return nil, nil`
`31`	`31`	`}`
`32`		`- return nil, NewAPIError(resp.StatusCode(), resp.Status())`
	`32`	`+ return nil, NewAPIError(resp.StatusCode(), "%s", resp.Status())`
`33`	`33`	`}`
`34`	`34`	`kibanaStatus := make(KibanaStatus)`
`35`	`35`	`err = json.Unmarshal(resp.Body(), &kibanaStatus)`
Original file line number	Diff line number	Diff line change
`@@ -415,6 +415,9 @@ func newKibanaSyntheticsMonitorDeleteFunc(c *resty.Client) KibanaSyntheticsMonit`
`415`	`415`	`}`
`416`	`416`
`417`	`417`	`result, err := unmarshal(resp, []MonitorDeleteStatus{})`
	`418`	`+ if err != nil {`
	`419`	`+ return nil, err`
	`420`	`+ }`
`418`	`421`	`return *result, err`
`419`	`422`	`}`
`420`	`423`	`}`
`@@ -481,6 +484,9 @@ func newKibanaSyntheticsParameterDeleteFunc(c *resty.Client) KibanaSyntheticsPar`
`481`	`484`	`}`
`482`	`485`
`483`	`486`	`result, err := unmarshal(resp, []ParameterDeleteStatus{})`
	`487`	`+ if err != nil {`
	`488`	`+ return nil, err`
	`489`	`+ }`
`484`	`490`	`return *result, err`
`485`	`491`	`}`
`486`	`492`	`}`
`@@ -503,9 +509,9 @@ func handleKibanaError(err error, resp *resty.Response) error {`
`503`	`509`	`kibanaErr := KibanaError{}`
`504`	`510`	`err := json.Unmarshal(resp.Body(), &kibanaErr)`
`505`	`511`	`if err != nil {`
`506`		`- return NewAPIError(resp.StatusCode(), resp.Status(), err)`
	`512`	`+ return NewAPIError(resp.StatusCode(), "status: %s, err: %s", resp.Status(), err)`
`507`	`513`	`}`
`508`		`- return NewAPIError(resp.StatusCode(), kibanaErr.Message, kibanaErr.Error)`
	`514`	`+ return NewAPIError(resp.StatusCode(), "message: %s, err: %s", kibanaErr.Message, kibanaErr.Error)`
`509`	`515`	`}`
`510`	`516`	`return nil`
`511`	`517`	`}`