Skip to content

Commit 0b6542c

Browse files
committed
Fix tests
1 parent 9ed8173 commit 0b6542c

File tree

1 file changed

+41
-41
lines changed

1 file changed

+41
-41
lines changed

internal/utils/customtypes/memory_size_value_test.go

Lines changed: 41 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ func TestMemorySize_ParseBytes(t *testing.T) {
279279
tests := []struct {
280280
name string
281281
memorySize MemorySize
282-
expectedBytes int64
282+
expectedMB int64
283283
expectedError bool
284284
}{
285285
{
@@ -293,69 +293,69 @@ func TestMemorySize_ParseBytes(t *testing.T) {
293293
expectedError: true,
294294
},
295295
{
296-
name: "bytes without unit",
297-
memorySize: NewMemorySizeValue("1048576"), // exactly 1MB
298-
expectedBytes: 1048576,
296+
name: "bytes without unit",
297+
memorySize: NewMemorySizeValue("1048576"), // exactly 1MB
298+
expectedMB: 1,
299299
},
300300
{
301-
name: "bytes without unit - rounds down",
302-
memorySize: NewMemorySizeValue("1048575"), // 1 byte less than 1MB
303-
expectedBytes: 0, // rounds down to 0MB
301+
name: "bytes without unit - rounds down",
302+
memorySize: NewMemorySizeValue("1048575"), // 1 byte less than 1MB
303+
expectedMB: 0, // rounds down to 0MB
304304
},
305305
{
306-
name: "bytes without unit - partial MB rounds down",
307-
memorySize: NewMemorySizeValue("1500000"), // ~1.43MB
308-
expectedBytes: 1048576, // rounds down to 1MB
306+
name: "bytes without unit - partial MB rounds down",
307+
memorySize: NewMemorySizeValue("1500000"), // ~1.43MB
308+
expectedMB: 1, // rounds down to 1MB
309309
},
310310
{
311-
name: "kilobytes",
312-
memorySize: NewMemorySizeValue("1024k"), // exactly 1MB
313-
expectedBytes: 1024 * 1024,
311+
name: "kilobytes",
312+
memorySize: NewMemorySizeValue("1024k"), // exactly 1MB
313+
expectedMB: 1,
314314
},
315315
{
316-
name: "kilobytes - partial MB rounds down",
317-
memorySize: NewMemorySizeValue("1000k"), // ~976KB, rounds down to 0MB
318-
expectedBytes: 0,
316+
name: "kilobytes - partial MB rounds down",
317+
memorySize: NewMemorySizeValue("1000k"), // ~976KB, rounds down to 0MB
318+
expectedMB: 0,
319319
},
320320
{
321-
name: "kilobytes with B suffix",
322-
memorySize: NewMemorySizeValue("1024kb"), // exactly 1MB
323-
expectedBytes: 1024 * 1024,
321+
name: "kilobytes with B suffix",
322+
memorySize: NewMemorySizeValue("1024kb"), // exactly 1MB
323+
expectedMB: 1,
324324
},
325325
{
326-
name: "megabytes",
327-
memorySize: NewMemorySizeValue("128m"),
328-
expectedBytes: 128 * 1024 * 1024,
326+
name: "megabytes",
327+
memorySize: NewMemorySizeValue("128m"),
328+
expectedMB: 128,
329329
},
330330
{
331-
name: "megabytes with B suffix",
332-
memorySize: NewMemorySizeValue("128mb"),
333-
expectedBytes: 128 * 1024 * 1024,
331+
name: "megabytes with B suffix",
332+
memorySize: NewMemorySizeValue("128mb"),
333+
expectedMB: 128,
334334
},
335335
{
336-
name: "uppercase megabytes",
337-
memorySize: NewMemorySizeValue("128MB"),
338-
expectedBytes: 128 * 1024 * 1024,
336+
name: "uppercase megabytes",
337+
memorySize: NewMemorySizeValue("128MB"),
338+
expectedMB: 128,
339339
},
340340
{
341-
name: "gigabytes",
342-
memorySize: NewMemorySizeValue("2g"),
343-
expectedBytes: 2 * 1024 * 1024 * 1024,
341+
name: "gigabytes",
342+
memorySize: NewMemorySizeValue("2g"),
343+
expectedMB: 2 * 1024,
344344
},
345345
{
346-
name: "gigabytes with B suffix",
347-
memorySize: NewMemorySizeValue("2gb"),
348-
expectedBytes: 2 * 1024 * 1024 * 1024,
346+
name: "gigabytes with B suffix",
347+
memorySize: NewMemorySizeValue("2gb"),
348+
expectedMB: 2 * 1024,
349349
},
350350
{
351-
name: "terabytes",
352-
memorySize: NewMemorySizeValue("1t"),
353-
expectedBytes: 1024 * 1024 * 1024 * 1024,
351+
name: "terabytes",
352+
memorySize: NewMemorySizeValue("1t"),
353+
expectedMB: 1024 * 1024,
354354
},
355355
{
356-
name: "terabytes with B suffix",
357-
memorySize: NewMemorySizeValue("1tb"),
358-
expectedBytes: 1024 * 1024 * 1024 * 1024,
356+
name: "terabytes with B suffix",
357+
memorySize: NewMemorySizeValue("1tb"),
358+
expectedMB: 1024 * 1024,
359359
},
360360
{
361361
name: "invalid format",
@@ -377,7 +377,7 @@ func TestMemorySize_ParseBytes(t *testing.T) {
377377
require.True(t, diags.HasError())
378378
} else {
379379
require.False(t, diags.HasError())
380-
require.Equal(t, tt.expectedBytes, bytes)
380+
require.Equal(t, tt.expectedMB, bytes)
381381
}
382382
})
383383
}

0 commit comments

Comments
 (0)