Propagate SplitShardCountSummary to ESQL data nodes #137773
Merged
+344
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkts
commented
Nov 10, 2025
| return waitForCheckpoint; | ||
| } | ||
|
|
||
| // Used by ValidateQueryAction, ExplainAction, FieldCaps, TermsEnumAction, lookup join in ESQL |
Contributor
Author
There was a problem hiding this comment.
As noted, additional handling may be needed for lookup join.
Member
There was a problem hiding this comment.
Currently, resizing lookup indices is not allowed.
Contributor
Author
There was a problem hiding this comment.
RIght, thanks. I think i would like to still pass the summary if it's available in that context just to avoid inconsistency. It would be a follow up anyway.
elasticsearchmachine
added
the
needs:triage
lkts
added
>non-issue
:Distributed Indexing/Distributed
elasticsearchmachine
added
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
dnhatn
reviewed
Nov 10, 2025
| // This value is specific to resharding feature and this code path is specific to CCS | ||
| // involving 8.x remote cluster. | ||
| // We don't currently expect resharding to be used in such conditions so it's unset. | ||
| this.reshardSplitShardCountSummary = SplitShardCountSummary.UNSET; |
Member
There was a problem hiding this comment.
I can open a PR to remove this BWC after your PR, as it is no longer needed in 9.x.
Contributor
Author
There was a problem hiding this comment.
Oh nice, we don't allow CCS between majors?
bcully
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SplitShardCountSummaryis a piece of metadata specific to resharding feature. It is needed to ensure correctness of search results during resharding.This PR propagates
SplitShardCountSummarycalculated by a coordinator when obtaining routing information to data nodes. Since ESQL accesses routing information via a separate API this requires changing the search shards API response. It is then plugged into aShardSearchRequestthat is passed tocreateSearchContextcall (see also #135804). In future a custom searcher that ensures that correct documents are returned during resharding will be created using this value. This PR does not include this logic and only ensures that a correctShardSearchRequestis created.