Skip stacktrace for exceptions when stacktrace is not relevant. (#110785)

These exceptions are expected and don't imply bugs, their stacktrace
isn't relevant and should not be logged.

Relates to ES-7097

Author: mosche

server/src/main/java/org/elasticsearch/action/NoShardAvailableActionException.java

@@ -18,8 +18,6 @@
 
 public final class NoShardAvailableActionException extends ElasticsearchException {
 
-    private static final StackTraceElement[] EMPTY_STACK_TRACE = new StackTraceElement[0];
-
     // This is set so that no StackTrace is serialized in the scenario when we wrap other shard failures.
     // It isn't necessary to serialize this field over the wire as the empty stack trace is serialized instead.
     private final boolean onShardFailureWrapper;
@@ -57,8 +55,8 @@ public NoShardAvailableActionException(StreamInput in) throws IOException {
     }
 
     @Override
-    public StackTraceElement[] getStackTrace() {
-        return onShardFailureWrapper ? EMPTY_STACK_TRACE : super.getStackTrace();
+    public Throwable fillInStackTrace() {
+        return this; // this exception doesn't imply a bug, no need for a stack trace
     }
 
     @Override
@@ -67,7 +65,7 @@ public void printStackTrace(PrintWriter s) {
             super.printStackTrace(s);
         } else {
             // Override to simply print the first line of the trace, which is the current exception.
-            // Since we aren't serializing the repetitive stacktrace onShardFailureWrapper, we shouldn't print it out either
+            // Note: This will also omit the cause chain or any suppressed exceptions.
             s.println(this);
         }
     }

server/src/main/java/org/elasticsearch/action/UnavailableShardsException.java

@@ -45,4 +45,9 @@ public UnavailableShardsException(StreamInput in) throws IOException {
     public RestStatus status() {
         return RestStatus.SERVICE_UNAVAILABLE;
     }
+
+    @Override
+    public Throwable fillInStackTrace() {
+        return this; // this exception doesn't imply a bug, no need for a stack trace
+    }
 }

server/src/main/java/org/elasticsearch/cluster/block/ClusterBlockException.java

@@ -38,6 +38,11 @@ public ClusterBlockException(StreamInput in) throws IOException {
         this.blocks = in.readCollectionAsImmutableSet(ClusterBlock::new);
     }
 
+    @Override
+    public Throwable fillInStackTrace() {
+        return this; // this exception doesn't imply a bug, no need for a stack trace
+    }
+
     @Override
     protected void writeTo(StreamOutput out, Writer<Throwable> nestedExceptionsWriter) throws IOException {
         super.writeTo(out, nestedExceptionsWriter);

server/src/main/java/org/elasticsearch/common/util/concurrent/EsRejectedExecutionException.java

@@ -27,6 +27,11 @@ public EsRejectedExecutionException() {
         this(null, false);
     }
 
+    @Override
+    public Throwable fillInStackTrace() {
+        return this; // this exception doesn't imply a bug, no need for a stack trace
+    }
+
     /**
      * Checks if the thread pool that rejected the execution was terminated
      * shortly after the rejection. Its possible that this returns false and the

server/src/main/java/org/elasticsearch/discovery/MasterNotDiscoveredException.java

@@ -32,4 +32,9 @@ public RestStatus status() {
     public MasterNotDiscoveredException(StreamInput in) throws IOException {
         super(in);
     }
+
+    @Override
+    public Throwable fillInStackTrace() {
+        return this; // this exception doesn't imply a bug, no need for a stack trace
+    }
 }

server/src/main/java/org/elasticsearch/node/NodeClosedException.java

@@ -28,4 +28,9 @@ public NodeClosedException(DiscoveryNode node) {
     public NodeClosedException(StreamInput in) throws IOException {
         super(in);
     }
+
+    @Override
+    public Throwable fillInStackTrace() {
+        return this; // this exception doesn't imply a bug, no need for a stack trace
+    }
 }

server/src/main/java/org/elasticsearch/search/aggregations/MultiBucketConsumerService.java

@@ -65,6 +65,11 @@ public TooManyBucketsException(StreamInput in) throws IOException {
             maxBuckets = in.readInt();
         }
 
+        @Override
+        public Throwable fillInStackTrace() {
+            return this; // this exception doesn't imply a bug, no need for a stack trace
+        }
+
         @Override
         protected void writeTo(StreamOutput out, Writer<Throwable> nestedExceptionsWriter) throws IOException {
             super.writeTo(out, nestedExceptionsWriter);

server/src/main/java/org/elasticsearch/transport/NodeNotConnectedException.java

@@ -27,4 +27,9 @@ public NodeNotConnectedException(DiscoveryNode node, String msg) {
     public NodeNotConnectedException(StreamInput in) throws IOException {
         super(in);
     }
+
+    @Override
+    public Throwable fillInStackTrace() {
+        return this; // this exception doesn't imply a bug, no need for a stack trace
+    }
 }