[MODEL] Only warn if inheritance_enabled is set to true

Author: estolfo

elasticsearch-model/lib/elasticsearch/model.rb

@@ -187,7 +187,7 @@ def inheritance_enabled
       #     Elasticsearch::Model.inheritance_enabled = true
       #
       def inheritance_enabled=(inheritance_enabled)
-        warn STI_DEPRECATION_WARNING
+        warn STI_DEPRECATION_WARNING if inheritance_enabled
         @settings[:inheritance_enabled] = inheritance_enabled
       end
 

elasticsearch-model/spec/elasticsearch/model/module_spec.rb

@@ -89,5 +89,30 @@ def self.search(query, options={})
         expect(Elasticsearch::Model.settings[:foo]).to eq('bar')
       end
     end
+
+    context 'when \'inheritance_enabled\' is set' do
+
+      around do |example|
+        original_value = Elasticsearch::Model.settings[:inheritance_enabled]
+        example.run
+        Elasticsearch::Model.settings[:inheritance_enabled] = original_value
+      end
+
+      context 'when \'inheritance_enabled\' is true' do
+
+        it 'warns with a deprecation message' do
+          expect(Elasticsearch::Model).to receive(:warn)
+          Elasticsearch::Model.inheritance_enabled = true
+        end
+      end
+
+      context 'when \'inheritance_enabled\' is false' do
+
+        it 'does not warn' do
+          expect(Elasticsearch::Model).not_to receive(:warn)
+          Elasticsearch::Model.inheritance_enabled = false
+        end
+      end
+    end
   end
 end