Fix #2060: deprecate StringProperty

Author: gmarz

src/CodeGeneration/CodeGeneration.LowLevelClient/CodeGeneration.LowLevelClient.project.lock.json

@@ -1,6 +1,6 @@
 {
   "locked": false,
-  "version": 2,
+  "version": 1,
   "targets": {
     ".NETFramework,Version=v4.5": {},
     ".NETFramework,Version=v4.5/win": {}

src/CodeGeneration/Nest.Litterateur/Nest.Litterateur.project.lock.json

@@ -1,6 +1,6 @@
 {
   "locked": false,
-  "version": 2,
+  "version": 1,
   "targets": {
     ".NETFramework,Version=v4.5": {},
     ".NETFramework,Version=v4.5/win": {}

src/Elasticsearch.Net/Elasticsearch.Net.project.lock.json

@@ -1,6 +1,6 @@
 {
   "locked": false,
-  "version": 2,
+  "version": 1,
   "targets": {
     ".NETFramework,Version=v4.5": {},
     ".NETFramework,Version=v4.5/win": {}

src/Nest/Mapping/DynamicTemplate/SingleMapping.cs

@@ -6,6 +6,8 @@ public class SingleMappingDescriptor<T> :
 		DescriptorBase<SingleMappingDescriptor<T>, IPropertiesDescriptor<T, IProperty>>, IPropertiesDescriptor<T, IProperty>
 		where T : class
 	{
+
+		[Obsolete("Only valid for indices created before Elasticsearch 5.0 and will be removed in the next major version.  For newly created indices, use `text` or `keyword` instead.")]
 		public IProperty String(Func<StringPropertyDescriptor<T>, IStringProperty> selector) =>
 			selector?.Invoke(new StringPropertyDescriptor<T>());
 
@@ -60,4 +62,4 @@ public IProperty Generic(Func<GenericPropertyDescriptor<T>, IGenericProperty> se
 		public IProperty Percolator(Func<PercolatorPropertyDescriptor<T>, IPercolatorProperty> selector) =>
 			selector?.Invoke(new PercolatorPropertyDescriptor<T>());
 	}
-}
+}

src/Nest/Mapping/Types/Core/String/StringProperty.cs

@@ -4,6 +4,7 @@
 namespace Nest
 {
 	[JsonObject(MemberSerialization.OptIn)]
+	[Obsolete("Only valid for indices created before Elasticsearch 5.0 and will be removed in the next major version.  For newly created indices, use `text` or `keyword` instead.")]
 	public interface IStringProperty : IDocValuesProperty
 	{
 		[JsonProperty("index")]
@@ -43,6 +44,7 @@ public interface IStringProperty : IDocValuesProperty
 		IStringFielddata Fielddata { get; set; }
 	}
 
+	[Obsolete("Only valid for indices created before Elasticsearch 5.0 and will be removed in the next major version.  For newly created indices, use `text` or `keyword` instead.")]
 	public class StringProperty : DocValuesPropertyBase, IStringProperty
 	{
 		public StringProperty() : base("string") { }
@@ -61,6 +63,7 @@ public StringProperty() : base("string") { }
 		public IStringFielddata Fielddata { get; set; }
 	}
 
+	[Obsolete("Only valid for indices created before Elasticsearch 5.0 and will be removed in the next major version.  For newly created indices, use `text` or `keyword` instead.")]
 	public class StringPropertyDescriptor<T>
 		: DocValuesPropertyDescriptorBase<StringPropertyDescriptor<T>, IStringProperty, T>, IStringProperty
 		where T : class

src/Nest/Mapping/Types/Properties.cs

@@ -37,6 +37,8 @@ public interface IPropertiesDescriptor<T, out TReturnType>
 		where T : class
 		where TReturnType : class
 	{
+
+		[Obsolete("Only valid for indices created before Elasticsearch 5.0 and will be removed in the next major version.  For newly created indices, use `text` or `keyword` instead.")]
 		TReturnType String(Func<StringPropertyDescriptor<T>, IStringProperty> selector);
 		TReturnType Text(Func<TextPropertyDescriptor<T>, ITextProperty> selector);
 		TReturnType Keyword(Func<KeywordPropertyDescriptor<T>, IKeywordProperty> selector);
@@ -64,6 +66,8 @@ public class PropertiesDescriptor<T> : IsADictionaryDescriptorBase<PropertiesDes
 		public PropertiesDescriptor() : base(new Properties<T>()) { }
 		public PropertiesDescriptor(IProperties properties) : base(properties ?? new Properties<T>()) { }
 
+
+		[Obsolete("Only valid for indices created before Elasticsearch 5.0 and will be removed in the next major version.  For newly created indices, use `text` or `keyword` instead.")]
 		public PropertiesDescriptor<T> String(Func<StringPropertyDescriptor<T>, IStringProperty> selector) => SetProperty(selector);
 
 		public PropertiesDescriptor<T> Text(Func<TextPropertyDescriptor<T>, ITextProperty> selector) => SetProperty(selector);