Fix/bwc obsolete (#3739)

* Indent global.json

* Patch in ctors and methods needed for binary compatibility

This commit patches in ctors and methods that are removed between 6.6.0 and 6.7.0 rest api specs, and marks then as obsolete

Author: russcam

build/scripts/Versioning.fs

@@ -29,7 +29,7 @@ module Versioning =
     let writeVersionIntoGlobalJson version =
         let globalJson = globalJson ()
         let newGlobalJson = { globalJson with version = version.ToString(); }
-        File.WriteAllText("global.json", JsonConvert.SerializeObject(newGlobalJson))
+        File.WriteAllText("global.json", JsonConvert.SerializeObject(newGlobalJson, Formatting.Indented))
         printfn "Written (%s) to global.json as the current version will use this version from now on as current in the build" (version.ToString()) 
 
     let GlobalJsonVersion = parse <| globalJson().version

src/Nest/Indices/MappingManagement/PutMapping/PutMappingRequest.cs

@@ -101,6 +101,10 @@ public PutMappingRequest() : this(typeof(T), typeof(T)) { }
 	[DescriptorFor("IndicesPutMapping")]
 	public partial class PutMappingDescriptor<T> where T : class
 	{
+		/// <summary>/{index}/{type}/_mapping. Will infer the index from the generic type</summary>
+		///<param name="type"> this parameter is required</param>
+		public PutMappingDescriptor(TypeName type) : base(r=>r.Required("type", type).Required("index", (IndexName)typeof(T))){}
+
 		public PutMappingDescriptor(IndexName index, TypeName type) : base(r => r.Required("index", index).Required("type", type)) { }
 
 		IAllField ITypeMapping.AllField { get; set; }

src/Nest/XPack/Security/User/DisableUser/DisableUserRequest.cs

@@ -1,9 +1,19 @@
-namespace Nest
+using System;
+
+namespace Nest
 {
 	public partial interface IDisableUserRequest { }
 
 	public partial class DisableUserRequest { }
 
 	[DescriptorFor("XpackSecurityDisableUser")]
-	public partial class DisableUserDescriptor { }
+	public partial class DisableUserDescriptor
+	{
+		[Obsolete("Use the constructor that accepts Name. Will be removed in the next major release")]
+		public DisableUserDescriptor() { }
+
+		[Obsolete("Use the constructor that accepts Name. Will be removed in the next major release")]
+		public DisableUserDescriptor Username(Name username) =>
+			Assign(username, (a , v) => a.RouteValues.Required("username", username));
+	}
 }

src/Nest/XPack/Security/User/EnableUser/EnableUserRequest.cs

@@ -1,9 +1,19 @@
-namespace Nest
+using System;
+
+namespace Nest
 {
 	public partial interface IEnableUserRequest { }
 
 	public partial class EnableUserRequest { }
 
 	[DescriptorFor("XpackSecurityEnableUser")]
-	public partial class EnableUserDescriptor { }
+	public partial class EnableUserDescriptor
+	{
+		[Obsolete("Use the constructor that accepts Name. Will be removed in the next major release")]
+		public EnableUserDescriptor() { }
+
+		[Obsolete("Use the constructor that accepts Name. Will be removed in the next major release")]
+		public EnableUserDescriptor Username(Name username) =>
+			Assign(username, (a , v) => a.RouteValues.Required("username", username));
+	}
 }