Merge branch '6.x' into 6.4

Author: russcam

docs/client-concepts/low-level/getting-started.asciidoc

@@ -51,7 +51,7 @@ There are many other <<configuration-options,configuration options>> on `Connect
 * whether HTTP compression support should be enabled on the client
 
 [float]
-==== Connecton pools
+==== Connection pools
 
 `ConnectionConfiguration` is not restricted to being passed a single address for Elasticsearch. There are several different
 types of <<connection-pooling,Connection pool>> available, each with different characteristics that can be used to
@@ -99,10 +99,10 @@ var person = new Person
     LastName = "Laarman"
 };
 
-var indexResponse = lowlevelClient.Index<BytesResponse>("people", "person", "1", PostData.Serializable(person)); <1>
+var indexResponse = lowlevelClient.Index<BytesResponse>("people", "person", "1", PostData.Serializable(person)); <1>
 byte[] responseBytes = indexResponse.Body;
 
-var asyncIndexResponse = await lowlevelClient.IndexAsync<StringResponse>("people", "person", "1", PostData.Serializable(person)); <2>
+var asyncIndexResponse = await lowlevelClient.IndexAsync<StringResponse>("people", "person", "1", PostData.Serializable(person)); <2>
 string responseString = asyncIndexResponse.Body;
 ----
 <1> synchronous method that returns an `IIndexResponse`
@@ -238,8 +238,8 @@ is successful
 ----
 var searchResponse = lowlevelClient.Search<BytesResponse>("people", "person", PostData.Serializable(new { match_all = new {} }));
 
-var success = searchResponse.Success; <1>
-var successOrKnownError = searchResponse.SuccessOrKnownError; <2>
+var success = searchResponse.Success; <1>
+var successOrKnownError = searchResponse.SuccessOrKnownError; <2>
 var exception = searchResponse.OriginalException; <3>
 ----
 <1> Response is in the 200 range, or an expected response for the given request

src/Tests/Tests.Reproduce/GithubIssue3412.cs

@@ -0,0 +1,27 @@
+using FluentAssertions;
+using System.Linq;
+using Elastic.Xunit.XunitPlumbing;
+using Tests.Core.ManagedElasticsearch.Clusters;
+using Tests.Domain;
+
+namespace Tests.Reproduce
+{
+	public class GithubIssue3412 : IClusterFixture<WritableCluster>
+	{
+		private readonly WritableCluster _cluster;
+
+		public GithubIssue3412(WritableCluster cluster) => _cluster = cluster;
+
+		[I]
+		public void WildcardBeingEscapedHasNoBarringsOnResult()
+		{
+			var indexedDocument1 = _cluster.Client.Index(new Project { Name = "project-1" }, d => d.Index("prefixed-1"));
+			var indexedDocument2 = _cluster.Client.Index(new Project { Name = "project-2" }, d => d.Index("prefixed-2"));
+			var refresh = _cluster.Client.Refresh("prefixed-*");
+			var search = _cluster.Client.Search<Project>(s => s.Index("prefixed-*"));
+			search.Total.Should().Be(2);
+			var queriedIndices = search.Hits.Select(h => h.Index).ToArray();
+			queriedIndices.Should().BeEquivalentTo(new[] {"prefixed-1", "prefixed-2"});
+		}
+	}
+}

src/Tests/Tests/ClientConcepts/LowLevel/GettingStarted.doc.cs

@@ -64,7 +64,7 @@ public void UsingConnectionSettings()
          * - whether HTTP compression support should be enabled on the client
 		 *
 		 * [float]
-		 * ==== Connecton pools
+		 * ==== Connection pools
 		 *
 		 * `ConnectionConfiguration` is not restricted to being passed a single address for Elasticsearch. There are several different
 		 * types of <<connection-pooling,Connection pool>> available, each with different characteristics that can be used to