Hit<T> sorts is not always a float caused a nasty serialization bug! Fixes #121

Author: Mpdreamz

src/Nest.Tests.Integration/Search/QueryResponseMapperTests.cs

@@ -58,7 +58,7 @@ public void HitsMaxScoreIsSet()
 		}
 
 		[Test]
-		public void HitsScoreIsSet()
+		public void HitsSortsIsSet()
 		{
 			//arrange
 			//pull existing example through method we know is functional based on other passing unit tests
@@ -72,6 +72,19 @@ public void HitsScoreIsSet()
 
 			Assert.True(hits.Hits.All(h=>h.Sorts.Count() == 2));
 		}
+		[Test]
+		public void HitsSortsIsSetWithStringSort()
+		{
+			var queryResults = this.ConnectedClient.Search<ElasticSearchProject>(s => s
+				.QueryString("*")
+				.SortAscending(p=>p.Name.Suffix("sort"))
+				.SortDescending(p => p.Id)
+			);
+
+			var hits = queryResults.Hits;
+
+			Assert.True(hits.Hits.All(h => h.Sorts.Count() == 2));
+		}
 
 		[Test]
 		public void BoolQuery()

src/Nest/Domain/Hit/Hit.cs

@@ -25,7 +25,7 @@ public class Hit<T> where T : class
 		public string Id { get; internal set; }
 
 		[JsonProperty(PropertyName = "sort")]
-		public IEnumerable<float> Sorts { get; internal set; }
+		public IEnumerable<object> Sorts { get; internal set; }
 
 		[JsonProperty(PropertyName = "highlight")]
 		public Dictionary<string, List<string>> Highlight { get; internal set; }

src/Nest/Resolvers/PropertyNameResolver.cs

@@ -16,7 +16,7 @@ namespace Nest.Resolvers
 
 	public class PropertyNameResolver : ExpressionVisitor
 	{
-    private static readonly ElasticResolver ContractResolver = new ElasticResolver();
+		private static readonly ElasticResolver ContractResolver = new ElasticResolver();
 
 		public ElasticPropertyAttribute GetElasticProperty(MemberInfo info)
 		{
@@ -25,19 +25,19 @@ public ElasticPropertyAttribute GetElasticProperty(MemberInfo info)
 				return ((ElasticPropertyAttribute)attributes.First());
 			return null;
 		}
-		
+
 		public ElasticTypeAttribute GetElasticPropertyFor<T>() where T : class
 		{
 			return GetElasticPropertyForType(typeof(T));
 		}
-		
+
 		public ElasticTypeAttribute GetElasticPropertyFor(Type type)
 		{
 			if (!type.IsClass && !type.IsInterface)
 				throw new ArgumentException("Type is not a class or interface", "type");
 			return GetElasticPropertyForType(type);
 		}
-		
+
 		private ElasticTypeAttribute GetElasticPropertyForType(Type type)
 		{
 			if (!type.IsClass && !type.IsInterface)
@@ -66,7 +66,7 @@ public string Resolve(Expression expression)
 		{
 			var stack = new Stack<string>();
 			var properties = new Stack<ElasticPropertyAttribute>();
-      Visit(expression, stack, properties);
+			Visit(expression, stack, properties);
 			return stack
 				.Aggregate(
 					new StringBuilder(),
@@ -75,7 +75,7 @@ public string Resolve(Expression expression)
 				.ToString();
 		}
 
-    protected override Expression VisitMemberAccess(MemberExpression expression, Stack<string> stack, Stack<ElasticPropertyAttribute> properties)
+		protected override Expression VisitMemberAccess(MemberExpression expression, Stack<string> stack, Stack<ElasticPropertyAttribute> properties)
 		{
 			if (stack != null)
 			{
@@ -94,7 +94,7 @@ protected override Expression VisitMemberAccess(MemberExpression expression, Sta
 				}
 				stack.Push(resolvedName);
 			}
-      return base.VisitMemberAccess(expression, stack, properties);
+			return base.VisitMemberAccess(expression, stack, properties);
 		}
 
 		protected override Expression VisitMethodCall(MethodCallExpression m, Stack<string> stack, Stack<ElasticPropertyAttribute> properties)