added tests to reproduce #1435

Author: Mpdreamz

src/Tests/Nest.Tests.Unit/Nest.Tests.Unit.csproj

@@ -408,6 +408,7 @@
     <Compile Include="Reproduce\Reproduce1187Tests.cs" />
     <Compile Include="Reproduce\Reproduce901Tests.cs" />
     <Compile Include="Reproduce\Reproduce1320Tests.cs" />
+    <Compile Include="Reproduce\Reproduce1435Tests.cs" />
     <Compile Include="Reproduce\Reproduce990Tests.cs" />
     <Compile Include="Reproduce\Reproduce974Tests.cs" />
     <Compile Include="Reproduce\Reproduce928Tests.cs" />
@@ -833,6 +834,9 @@
     <None Include="QueryParsers\Filter\Term.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
+    <None Include="Reproduce\OISAggs.json">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
     <None Include="Reproduce\Issue1199Index.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>

src/Tests/Nest.Tests.Unit/Reproduce/OISAggs.json

@@ -0,0 +1,15 @@
+{
+  "aggs": {
+    "my_aggregation": {
+      "filter": {
+        "fquery": {
+          "query": {
+            "query_string": {
+              "query": "Just an example"
+            }
+          }
+        }
+      }
+    }
+  }
+}

src/Tests/Nest.Tests.Unit/Reproduce/Reproduce1435Tests.cs

@@ -0,0 +1,140 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Reflection;
+using Nest.Tests.MockData.Domain;
+using NUnit.Framework;
+
+namespace Nest.Tests.Unit.Reproduce
+{
+	/// <summary>
+	/// tests to reproduce reported errors
+	/// </summary>
+	[TestFixture]
+	public class Reproduce1435Tests : BaseJsonTests
+	{
+		[Test]
+		public void UsingExplicitCasts()
+		{
+			var aggregations = new Dictionary<string, IAggregationContainer>
+			{
+				{
+					//Aggregators missing implicit casts to AggregationContainer
+					"my_aggregation", new AggregationContainer
+					{
+						Filter = new FilterAggregator
+						{
+							Filter = (FilterContainer)new QueryFilter
+							{
+								Query = (QueryContainer)new QueryStringQuery
+								{
+									Query = "Just an example"
+								}
+							}
+						}
+					}
+				}
+			};
+
+			var result = this._client.Search<ElasticsearchProject>(new SearchRequest<ElasticsearchProject>
+			{
+				Aggregations = aggregations
+			});
+
+			this.JsonEquals(result.ConnectionStatus.Request, MethodBase.GetCurrentMethod(), "OISAggs");
+		}
+
+		[Test]
+		public void UsingConstructor()
+		{
+			var aggregations = new Dictionary<string, IAggregationContainer>
+			{
+				{
+					//AggregationContaner should accept aggregators in constructor
+					"my_aggregation", new AggregationContainer
+					{
+						Filter = new FilterAggregator
+						{
+							Filter = new FilterContainer(new QueryFilter
+							{
+								Query = new QueryContainer(new QueryStringQuery
+								{
+									Query = "Just an example"
+								})
+							})
+						}
+					}
+				}
+			};
+
+			var result = this._client.Search<ElasticsearchProject>(new SearchRequest<ElasticsearchProject>
+			{
+				Aggregations = aggregations
+			});
+
+			this.JsonEquals(result.ConnectionStatus.Request, MethodBase.GetCurrentMethod(), "OISAggs");
+		}
+
+		[Test]
+		public void UsingToContainer()
+		{
+			var aggregations = new Dictionary<string, IAggregationContainer>
+			{
+				{
+					"my_aggregation", new AggregationContainer
+					{
+						Filter = new FilterAggregator
+						{
+							Filter = new QueryFilter
+							{
+								Query = new QueryStringQuery
+								{
+									Query = "Just an example"
+								}.ToContainer()
+							}.ToContainer()
+						} //Aggregator is missing ToContainer()
+					}
+				}
+			};
+
+			var result = this._client.Search<ElasticsearchProject>(new SearchRequest<ElasticsearchProject>
+			{
+				Aggregations = aggregations
+			});
+
+			this.JsonEquals(result.ConnectionStatus.Request, MethodBase.GetCurrentMethod(), "OISAggs");
+		}
+
+		[Test]
+		public void Using()
+		{
+			var aggregations = new Dictionary<string, IAggregationContainer>
+			{
+				{
+					"my_aggregation", new AggregationContainer
+					{
+						Filter = new FilterAggregator
+						{
+							Filter = new QueryFilter
+							{
+								Query = new QueryStringQuery
+								{
+									Query = "Just an example"
+								}.ToContainer()
+							}.ToContainer()
+						} //Aggregator is missing ToContainer()
+					}
+				}
+			};
+
+			var result = this._client.Search<ElasticsearchProject>(new SearchRequest<ElasticsearchProject>
+			{
+				Aggregations = aggregations
+			});
+
+			this.JsonEquals(result.ConnectionStatus.Request, MethodBase.GetCurrentMethod(), "OISAggs");
+		}
+
+
+	}
+}