fixed aggregations to work on 1.2, this means that for now .Histogram() response helper is broken on anything before 1.2

Author: Mpdreamz

src/Nest/Domain/Aggregations/AggregationsHelper.cs

@@ -105,11 +105,11 @@ public Bucket<KeyItem> Terms(string key)
 			return b;
 		}
 
-		public Bucket<KeyItem> Histogram(string key)
+		public Bucket<HistogramItem> Histogram(string key)
 		{
 			var bucket = this.TryGet<Bucket>(key);
-			var b = new Bucket<KeyItem>();
-			b.Items = bucket.Items.OfType<KeyItem>().ToList();
+			var b = new Bucket<HistogramItem>();
+			b.Items = bucket.Items.OfType<HistogramItem>().ToList();
 			return b;
 		}
 
@@ -154,11 +154,11 @@ public Bucket<RangeItem> GeoDistance(string key)
 			return b;
 		}
 
-		public Bucket<DateHistogramItem> DateHistogram(string key)
+		public Bucket<HistogramItem> DateHistogram(string key)
 		{
 			var bucket = this.TryGet<Bucket>(key);
-			var b = new Bucket<DateHistogramItem>();
-			b.Items = bucket.Items.OfType<DateHistogramItem>().ToList();
+			var b = new Bucket<HistogramItem>();
+			b.Items = bucket.Items.OfType<HistogramItem>().ToList();
 			return b;
 		}
 

src/Nest/Domain/Aggregations/DateHistogramItem.cs renamed to src/Nest/Domain/Aggregations/HistogramItem.cs

@@ -2,11 +2,14 @@
 
 namespace Nest
 {
-	public class DateHistogramItem : BucketAggregationBase, IBucketItem
+	public class HistogramItem : BucketAggregationBase, IBucketItem
 	{
 		public long Key { get; set; }
 		public string KeyAsString { get; set; }
 
+		/// <summary>
+		/// Get a DateTime form of the returned key, only make sense on date_histogram aggregations.
+		/// </summary>
 		public DateTime Date
 		{
 			get

src/Nest/Domain/Facets/HistogramFacet.cs

@@ -4,12 +4,12 @@
 namespace Nest
 {
     [JsonObject]
-    public class HistogramFacet : Facet, IFacet<HistogramItem>
+    public class HistogramFacet : Facet, IFacet<HistogramFacetItem>
     {
         [JsonProperty("entries")]
-        public IEnumerable<HistogramItem> Items { get; internal set; }
+        public IEnumerable<HistogramFacetItem> Items { get; internal set; }
     }
-    public class HistogramItem : FacetItem
+    public class HistogramFacetItem : FacetItem
     {
         [JsonProperty("key")]
         public double Key { get; set; }

src/Nest/Nest.csproj

@@ -104,7 +104,7 @@
     <Compile Include="Domain\Aggregations\AggregationsHelper.cs" />
     <Compile Include="Domain\Aggregations\Bucket.cs" />
     <Compile Include="Domain\Aggregations\BucketAggregationBase.cs" />
-    <Compile Include="Domain\Aggregations\DateHistogramItem.cs" />
+    <Compile Include="Domain\Aggregations\HistogramItem.cs" />
     <Compile Include="Domain\Aggregations\ExtendedStatsMetric.cs" />
     <Compile Include="Domain\Aggregations\IAggration.cs" />
     <Compile Include="Domain\Aggregations\IBucketAggregation.cs" />

src/Nest/Resolvers/Converters/Aggregations/AggregationConverter.cs

@@ -9,7 +9,7 @@ namespace Nest.Resolvers.Converters.Aggregations
 
 	public class AggregationConverter : JsonConverter
 	{
-		private static Regex _numeric = new Regex(@"^[\d.]+$"); 
+		private static Regex _numeric = new Regex(@"^[\d.]+(\.[\d.]+)?$"); 
 
 		public override bool CanWrite
 		{
@@ -36,6 +36,8 @@ private IAggregation ReadAggregation(JsonReader reader, JsonSerializer serialize
 
 			switch (property)
 			{
+				case "values":
+					return GetPercentilesMetricAggregation(reader, serializer);
 				case "value":
 					return GetValueMetricOrAggregation(reader, serializer);
 				case "buckets":
@@ -61,6 +63,8 @@ private IAggregation GetPercentilesMetricAggregation(JsonReader reader, JsonSeri
 		{
 			var metric = new PercentilesMetric();
 			var percentileItems = new List<PercentileItem>();
+			if (reader.TokenType == JsonToken.StartObject)
+				reader.Read();
 			while (reader.TokenType != JsonToken.EndObject)
 			{
 				var percentile = double.Parse(reader.Value as string);
@@ -156,7 +160,7 @@ private IAggregation GetDateHistogramAggregation(JsonReader reader, JsonSerializ
 			var docCount = (reader.Value as long?).GetValueOrDefault(0);
 			reader.Read();
 
-			var dateHistogram = new DateHistogramItem() {Key = key, KeyAsString = keyAsString, DocCount = docCount};
+			var dateHistogram = new HistogramItem() {Key = key, KeyAsString = keyAsString, DocCount = docCount};
 			dateHistogram.Aggregations = this.GetNestedAggregations(reader, serializer);
 			return dateHistogram;
 

src/Tests/Nest.Tests.Integration/Aggregations/BucketAggregationTests.cs

@@ -236,6 +236,7 @@ public void DateHistogram()
 			results.IsValid.Should().BeTrue();
 			var bucket = results.Aggs.DateHistogram("bucket_agg");
 			bucket.Items.Should().NotBeEmpty();
+			var item = bucket.Items.First();
 		}
 
 	}

src/Tests/Nest.Tests.Integration/Aggregations/ParseResponseItemsTests.cs

@@ -100,7 +100,7 @@ public void DateHistogramItem()
 	        var firstAgg = results.Aggregations.First().Value as Bucket;
 		    firstAgg.Should().NotBeNull();
 		    firstAgg.Items.Should().NotBeEmpty();
-			var grams = firstAgg.Items.OfType<DateHistogramItem>();
+			var grams = firstAgg.Items.OfType<HistogramItem>();
 			grams.Should().NotBeEmpty();
 	    }
 

src/Tests/Nest.Tests.Integration/Core/Map/RootProperties/MapRootObjectPropertiesTests.cs

@@ -26,7 +26,6 @@ public void RootPropertiesShouldSerialize()
 				.Dynamic()
 				.Enabled()
 				.IncludeInAll()
-				.Path("full")
 			);
 			this.DefaultResponseAssertations(result);
 		}