#fix 643 numeric terms we're not showing up on .Key on buckets (null)

Author: Mpdreamz

src/Nest/Resolvers/Converters/AggregationConverter.cs

@@ -170,15 +170,15 @@ private IAggregation GetDateHistogramAggregation(JsonReader reader, JsonSerializ
 		private IAggregation GetKeyedBucketItem(JsonReader reader, JsonSerializer serializer)
 		{
 			reader.Read();
-			var key = reader.Value as string;
+			var key = reader.Value;
 			reader.Read();
 			var property = reader.Value as string;
 			if (property == "from" || property == "to")
-				return GetRangeAggregation(reader, serializer, key);
+				return GetRangeAggregation(reader, serializer, key.ToString());
 
 
 			var keyItem = new KeyItem();
-			keyItem.Key = key;
+			keyItem.Key = key.ToString();
 			reader.Read(); //doc_count;
 			var docCount = reader.Value as long?;
 			keyItem.DocCount = docCount.GetValueOrDefault(0);

src/Tests/Nest.Tests.Integration/Nest.Tests.Integration.csproj

@@ -161,6 +161,7 @@
     <Compile Include="RawCalls\DynamicNullTests.cs" />
     <Compile Include="Mapping\NotAnalyzedTest.cs" />
     <Compile Include="RawCalls\ReturnTypesTest.cs" />
+    <Compile Include="Reproduce\Reproduce643Tests.cs" />
     <Compile Include="Reproduce\Reproduce628Tests.cs" />
     <Compile Include="Reproduce\Reproduce487Tests.cs" />
     <Compile Include="Reproduce\Reproduce437Tests.cs" />

src/Tests/Nest.Tests.Integration/Reproduce/Reproduce643Tests.cs

@@ -0,0 +1,40 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using Elasticsearch.Net;
+using Nest.Tests.MockData;
+using Nest.Tests.MockData.Domain;
+using NUnit.Framework;
+using System.Diagnostics;
+using FluentAssertions;
+
+namespace Nest.Tests.Integration.Reproduce
+{
+	[TestFixture]
+	public class Reproduce643Tests : IntegrationTests
+	{
+
+		/// <summary>
+		/// https://github.com/Mpdreamz/NEST/issues/643
+		/// </summary>
+		[Test]
+		public void TermsAggregationOnLongFieldShouldHaveKeysOnBucket()
+		{
+			var searchResult = this._client.Search<ElasticsearchProject>(s => s
+				.Size(0)
+				.Aggregations(aggs=>aggs
+					.Terms("numericTerms", t=>t
+						.Field(p=>p.LongValue)
+						.Size(10)
+					)
+				)
+			);
+
+			searchResult.IsValid.Should().BeTrue();
+			var terms = searchResult.Aggs.Terms("numericTerms");
+			terms.Items.Should().NotBeEmpty().And.NotContain(p => p.Key.IsNullOrEmpty());
+
+		}
+
+	}
+}