fix invalid upgrade api tests

Author: Mpdreamz

src/Tests/Tests/XPack/Migration/MigrationUpgrade/InvalidMigrationUpgradeApiTests.cs

@@ -10,41 +10,51 @@
 
 namespace Tests.XPack.Migration.MigrationUpgrade
 {
-	[SkipVersion(">=6.3.0", "Not running on latest version")]
+	[SkipVersion("<6.3.0", "Not running on latest version")]
 	public class InvalidMigrationUpgradeApiTests
 		: ApiIntegrationTestBase<XPackCluster, IMigrationUpgradeResponse, IMigrationUpgradeRequest, MigrationUpgradeDescriptor,
 			MigrationUpgradeRequest>
 	{
-		private const string Index = ".watches";
-
 		public InvalidMigrationUpgradeApiTests(XPackCluster cluster, EndpointUsage usage)
 			: base(cluster, usage) { }
 
 		protected override bool ExpectIsValid => false;
 
 		protected override object ExpectJson => null;
-		protected override int ExpectStatusCode => 400;
+		protected override int ExpectStatusCode => 500;
 
 		protected override Func<MigrationUpgradeDescriptor, IMigrationUpgradeRequest> Fluent => f => f;
 		protected override HttpMethod HttpMethod => HttpMethod.POST;
 
-		protected override MigrationUpgradeRequest Initializer => new MigrationUpgradeRequest(Index);
+		protected override MigrationUpgradeRequest Initializer => new MigrationUpgradeRequest(CallIsolatedValue);
 
-		protected override string UrlPath => $"/_xpack/migration/upgrade/{Index}";
+		protected override string UrlPath => $"/_xpack/migration/upgrade/{CallIsolatedValue}";
 
 		protected override LazyResponses ClientUsage() => Calls(
-			(c, f) => c.MigrationUpgrade(Index, f),
-			(c, f) => c.MigrationUpgradeAsync(Index, f),
+			(c, f) => c.MigrationUpgrade(CallIsolatedValue, f),
+			(c, f) => c.MigrationUpgradeAsync(CallIsolatedValue, f),
 			(c, r) => c.MigrationUpgrade(r),
 			(c, r) => c.MigrationUpgradeAsync(r)
 		);
 
-		protected override MigrationUpgradeDescriptor NewDescriptor() => new MigrationUpgradeDescriptor(Index);
+		protected override MigrationUpgradeDescriptor NewDescriptor() => new MigrationUpgradeDescriptor(CallIsolatedValue);
+
+		protected override void IntegrationSetup(IElasticClient client, CallUniqueValues values)
+		{
+			foreach (var (k, v) in values)
+				client.CreateIndex(v);
+		}
+		protected override void IntegrationTeardown(IElasticClient client, CallUniqueValues values)
+		{
+			foreach (var (k, v) in values)
+				client.DeleteIndex(v);
+		}
 
 		protected override void ExpectResponse(IMigrationUpgradeResponse response)
 		{
 			response.ShouldNotBeValid();
-			response.ServerError.Should().BeNull();
+			response.ServerError.Should().NotBeNull();
+			response.ServerError.Status.Should().Be(500);
 		}
 	}
 }