Move to .NET 3.0 and C# 8.0 (#4097) (#4102)

* Move to .NET 3.0 and C# 8.0 (#4097)

* initial move to .NET Core 3.0

* bump to .net sdk 3.0.100 and update our build files to install it for now while the images catch up

* move scripts to 3.0 since we call dotnet run on them, exclude new types from codestandards test that all types live in Elasticsearch.Net/NEST namespace

* build tooling moved from 2.2 to 3.0

* move all netcoreapp over to 3.0

* move to range on RegexCollection no longer accepts Last()

* update our own dependencies

* make 2.2 available for canary so that rewrite using 2.2 tools still works

* fix yaml indentation

* disable ingest-attachemnt for now, installl has stderr on 8.0.0 which abstractions does not yet handle

* move rewriter and differ to local dotnet tools

* no longer need to install 2.2 sdk for differ

(cherry picked from commit 9bbffad)

* Bump System.Buffers in Tests

* Move library projects over to also build net461 on linux through Microsoft.NETFramework.ReferenceAssemblies like we do on 7.x and master

* disable bullkallretries on CI for now, warrants deeper investigation issue to follow

* update to latest abstractions

* SkipOnCiAttribute over SkipOnTeamCityAttribute

* enable ingest attachment on writable cluster

* update abstractions

* bulkinvalid should have skipversion

Author: Mpdreamz

appveyor.yml

@@ -4,6 +4,8 @@ test: off
 environment:
     DOTNET_CLI_TELEMETRY_OPTOUT: true
     DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
+install:
+    - cmd: choco install dotnetcore-sdk --version 3.0.100
 build_script:
     - cmd: build.bat canary
 

azure-pipelines.yml

@@ -3,6 +3,9 @@ jobs:
   pool:
     vmImage: 'ubuntu-16.04'
   steps:
+  - task: UseDotNet@2
+    inputs:
+        version: '3.0.100'
   - script: ./build.sh test-one
     displayName: 'build and unit test'
   - task: PublishTestResults@2
@@ -15,6 +18,9 @@ jobs:
   pool:
     vmImage: 'vs2017-win2016'
   steps:
+  - task: UseDotNet@2
+    inputs:
+      version: '3.0.100'
   - script: build.bat canary
     displayName: 'build and unit test'
   - task: PublishTestResults@2
@@ -49,6 +55,9 @@ jobs:
       es601:
         esVersion: '6.0.1'
   steps:
+      - task: UseDotNet@2
+        inputs:
+            version: '3.0.100'
       - script: 'build.bat integrate-one $(esVersion) "readonly,writable,bool,xpack"'
         displayName: '$(esVersion) windows integration tests'
       - task: PublishTestResults@2
@@ -84,6 +93,9 @@ jobs:
       es601:
         esVersion: '6.0.1'
   steps:
+      - task: UseDotNet@2
+        inputs:
+            version: '3.0.100'
       - script: './build.sh integrate-one $(esVersion) "readonly,writable"'
         displayName: '$(esVersion) linux integration tests'
       - task: PublishTestResults@2

build/scripts/Benchmarking.fs

@@ -14,7 +14,7 @@ module Benchmarker =
         let password = match args.CommandArguments with | Benchmark b -> b.Password | _ -> None
         let runInteractive = not args.NonInteractive
         let credentials  = (username, password)
-        let runCommandPrefix = "run -f netcoreapp2.1 -c Release"
+        let runCommandPrefix = "run -f netcoreapp3.0 -c Release"
         let runCommand =
             match (runInteractive, url, credentials) with
             | (false, Some url, (Some username, Some password)) -> sprintf "%s -- --all \"%s\" \"%s\" \"%s\"" runCommandPrefix url username password

build/scripts/Cluster.fs

@@ -12,7 +12,7 @@ module Cluster =
         let clusterName = Option.defaultValue "" <| match args.CommandArguments with | Cluster c -> Some c.Name | _ -> None
         let clusterVersion = Option.defaultValue "" <|match args.CommandArguments with | Cluster c -> c.Version | _ -> None
 
-        let testsProjectDirectory = Path.Combine(Path.GetFullPath(Paths.Output("Tests.ClusterLauncher")), "netcoreapp2.1")
+        let testsProjectDirectory = Path.Combine(Path.GetFullPath(Paths.Output("Tests.ClusterLauncher")), "netcoreapp3.0")
         let tempDir = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());
 
         let sourceDir = Paths.Source("Tests/Tests.Configuration");

build/scripts/Differ.fs

@@ -9,6 +9,8 @@ open Commandline
 module Differ =
 
     let Run args =
+       Tooling.DotNet.Exec ["tool"; "restore"]
+        
        let differ = "assembly-differ"
        let args = args.RemainingArguments |> String.concat " "
        let command = sprintf @"%s %s -o ../../%s" differ args Paths.BuildOutput

build/scripts/Documentation.fs

@@ -11,7 +11,7 @@ module Documentation =
 
     let Generate args = 
         let docGenerator = PrivateProject(DocGenerator)
-        let path = Paths.ProjectOutputFolder docGenerator DotNetFramework.NetCoreApp2_1
+        let path = Paths.ProjectOutputFolder docGenerator DotNetFramework.NetCoreApp3_0
         let generator = sprintf "%s.dll" docGenerator.Name
 
         let (|NotNullOrEmpty|_|) (candidate:string) =

build/scripts/Projects.fs

@@ -7,13 +7,13 @@ module Projects =
     type DotNetFramework = 
         | NetStandard2_0
         | Net461
-        | NetCoreApp2_1
+        | NetCoreApp3_0
         static member All = [NetStandard2_0; Net461]
-        static member AllTests = [NetCoreApp2_1; Net461] 
+        static member AllTests = [NetCoreApp3_0; Net461] 
         member this.Identifier = 
             match this with
             | NetStandard2_0 -> { MSBuild = "netstandard2.0"; Nuget = "netstandard2.0"; DefineConstants = ""; }
-            | NetCoreApp2_1 -> { MSBuild = "netcoreapp2.1"; Nuget = "netcoreapp2.1"; DefineConstants = ""; }
+            | NetCoreApp3_0 -> { MSBuild = "netcoreapp3.0"; Nuget = "netcoreapp3.0"; DefineConstants = ""; }
             | Net461 -> { MSBuild = "net461"; Nuget = "net461"; DefineConstants = ""; }
 
     type Project =

build/scripts/ShadowDependencies.fs

@@ -8,6 +8,9 @@ module ShadowDependencies =
     let private assemblyRewriter = "assembly-rewriter"
     let private keyFile = Paths.Keys "keypair.snk"
     let Rewrite majorVersion framework projects =
+        
+        Tooling.DotNet.Exec ["tool"; "restore"]
+        
         let project = projects |> Seq.head
         let folder = Paths.ProjectOutputFolder project framework
 

build/scripts/Testing.fs

@@ -41,7 +41,7 @@ module Tests =
             let p = ["test"; "."; "-c"; "RELEASE"]
             //make sure we only test netcoreapp on linux or requested on the command line to only test-one
             match (target, Environment.isLinux) with 
-            | (_, true) -> ["--framework"; "netcoreapp2.1"] |> List.append p
+            | (_, true) -> ["--framework"; "netcoreapp3.0"] |> List.append p
             | (Commandline.MultiTarget.One, _) ->
                 let random = new Random()
                 let fw = DotNetFramework.AllTests |> List.sortBy (fun _ -> random.Next()) |> List.head

build/scripts/Tooling.fs

@@ -58,9 +58,9 @@ module Tooling =
         member this.ExecIn workingDirectory arguments = this.ExecInWithTimeout workingDirectory arguments timeout
         member this.Exec arguments = this.ExecWithTimeout arguments timeout
 
-    let nugetFile = Path.GetFullPath "build/scripts/bin/Release/netcoreapp2.2/NuGet.exe" 
+    let nugetFile = Path.GetFullPath "build/scripts/bin/Release/netcoreapp3.0/NuGet.exe" 
     let Nuget = BuildTooling(None, nugetFile)
-    let ILRepack = BuildTooling(None, "build/scripts/bin/Release/netcoreapp2.2/ILRepack.exe")
+    let ILRepack = BuildTooling(None, "build/scripts/bin/Release/netcoreapp3.0/ILRepack.exe")
     let DotNet = BuildTooling(Some <| TimeSpan.FromMinutes(5.), "dotnet")