Fix ClearCachedRealms test

Introduce constants for File and PKI realm names

Author: russcam

src/Tests/Framework/ManagedElasticsearch/Tasks/InstallationTasks/EnsureSecurityRealms.cs

@@ -24,7 +24,7 @@ public override void Run(NodeConfiguration config, NodeFileSystem fileSystem)
 					"  security:",
 					"    authc:",
 					"      realms:",
-					"        file1:",
+					$"        {SecurityRealms.FileRealm}:",
 					"          type: file",
 					"          order: 0",
 					string.Empty
@@ -42,7 +42,7 @@ public override void Run(NodeConfiguration config, NodeFileSystem fileSystem)
 					"  security:",
 					"    authc:",
 					"      realms:",
-					"        pki1:",
+					$"        {SecurityRealms.PkiRealm}:",
 					"          type: pki",
 					"          order: 1",
 					string.Empty

src/Tests/Framework/ManagedElasticsearch/Tasks/InstallationTasks/SecurityRealms.cs

@@ -0,0 +1,10 @@
+namespace Tests.Framework.ManagedElasticsearch.Tasks.InstallationTasks
+{
+    public static class SecurityRealms
+    {
+        public const string FileRealm = "file1";
+
+        public const string PkiRealm = "pki1";
+
+    }
+}

src/Tests/Tests.csproj

@@ -301,6 +301,7 @@
     <Compile Include="Framework\ManagedElasticsearch\Tasks\InstallationTasks\EnsureWatcherActionConfigurationInElasticsearchYaml.cs" />
     <Compile Include="Framework\ManagedElasticsearch\Tasks\InstallationTasks\InstallationTaskBase.cs" />
     <Compile Include="Framework\ManagedElasticsearch\Tasks\InstallationTasks\InstallPlugins.cs" />
+    <Compile Include="Framework\ManagedElasticsearch\Tasks\InstallationTasks\SecurityRealms.cs" />
     <Compile Include="Framework\ManagedElasticsearch\Tasks\InstallationTasks\UnzipCurrentElasticsearchDistribution.cs" />
     <Compile Include="Framework\ManagedElasticsearch\Tasks\InstallationTasks\WriteAnalysisFiles.cs" />
     <Compile Include="Framework\ManagedElasticsearch\Tasks\NodeTaskRunner.cs" />

src/Tests/XPack/Security/ClearCachedRealms/ClearCachedRealmsApiTests.cs

@@ -6,6 +6,7 @@
 using Tests.Framework;
 using Tests.Framework.Integration;
 using Tests.Framework.ManagedElasticsearch.Clusters;
+using Tests.Framework.ManagedElasticsearch.Tasks.InstallationTasks;
 using Xunit;
 
 namespace Tests.XPack.Security.ClearCachedRealms
@@ -26,12 +27,12 @@ protected override LazyResponses ClientUsage() => Calls(
 		protected override int ExpectStatusCode => 200;
 		protected override HttpMethod HttpMethod => HttpMethod.POST;
 
-		protected override string UrlPath => $"/_xpack/security/realm/{this.Realm}/_clear_cache";
+		protected override string UrlPath => $"/_xpack/security/realm/{UrlEncode(this.Realm)}/_clear_cache";
 
 		protected override bool SupportsDeserialization => false;
 
 		//callisolated value can sometimes start with a digit which is not allowed for rolenames
-		private string Realm => $"default_file";
+		private string Realm => SecurityRealms.FileRealm;
 
 		protected override ClearCachedRealmsRequest Initializer => new ClearCachedRealmsRequest(this.Realm);
 
@@ -49,4 +50,4 @@ protected override void ExpectResponse(IClearCachedRealmsResponse response)
 		}
 	}
 
-}
+}