InMemoryConnection serializes PostData

InMemoryConnection is consistent with NEST 1.x behaviour
Added a logging example to demonstrate how to use OnRequestCompleted() to capture requests and responses

Author: russcam

src/Elasticsearch.Net/Connection/InMemoryConnection.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
+using System.IO.Compression;
 using System.Text;
 using System.Threading.Tasks;
 
@@ -11,8 +12,6 @@ public class InMemoryConnection : HttpConnection
 		private readonly byte[] _responseBody;
 		private readonly int _statusCode;
 
-		public List<Tuple<string, Uri, PostData<object>>> Requests = new List<Tuple<string, Uri, PostData<object>>>(); 
-		
 		public InMemoryConnection() 
 		{
 			_statusCode = 200;
@@ -34,10 +33,23 @@ protected ElasticsearchResponse<TReturn> ReturnConnectionStatus<TReturn>(Request
 			where TReturn : class
 		{
 			var body = responseBody ?? _responseBody;
-			var builder = new ResponseBuilder<TReturn>(requestData)
+            var data = requestData.PostData;
+            if (data != null)
+            {
+                using (var stream = new MemoryStream())
+                {
+                    if (requestData.HttpCompression)
+                        using (var zipStream = new GZipStream(stream, CompressionMode.Compress))
+                            data.Write(zipStream, requestData.ConnectionSettings);
+                    else
+                        data.Write(stream, requestData.ConnectionSettings);
+                }
+            }
+
+            var builder = new ResponseBuilder<TReturn>(requestData)
 			{
 				StatusCode = statusCode ?? this._statusCode,
-				Stream = (body != null) ? new MemoryStream(body) : null
+				Stream = (body != null) ? new MemoryStream(body) : null,
 			};
 			var cs = builder.ToResponse();
 			return cs;

src/Tests/ClientConcepts/LowLevel/Connecting.doc.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Collections.Specialized;
 using System.Net;
+using System.Text;
 using System.Threading.Tasks;
 using Elasticsearch.Net;
 using FluentAssertions;
@@ -173,22 +174,90 @@ public void AvailableOptions()
 			*/
 		}
 
-		/** 
-	     * You can pass a callback of type `Action<IApiCallDetails>` that can eaves drop every time a response (good or bad) is created. 
-		 * If you have complex logging needs this is a good place to add that in.
+        /** 
+         * You can pass a callback of type `Action<IApiCallDetails>` that can eaves drop every time a response (good or bad) is created. 
+         * If you have complex logging needs this is a good place to add that in.
+        */
+        [U]
+        public void OnRequestCompletedIsCalled()
+        {
+            var counter = 0;
+            var connectionPool = new SingleNodeConnectionPool(new Uri("http://localhost:9200"));
+            var settings = new ConnectionSettings(connectionPool, new InMemoryConnection())
+                .OnRequestCompleted(r => counter++);
+            var client = new ElasticClient(settings);
+            client.RootNodeInfo();
+            counter.Should().Be(1);
+            client.RootNodeInfoAsync();
+            counter.Should().Be(2);
+        }
+
+        /** 
+	     * An example of using `OnRequestCompleted()` for complex logging. Remember, if you would also like 
+         * to capture the request and/or response bytes, you also need to set `.DisableDirectStreaming()`
+         * to `true`
 		*/
-		[U]public void OnRequestCompletedIsCalled()
+        [U]public async Task UsingOnRequestCompletedForLogging()
 		{
-			var counter = 0;
+		    var list = new List<string>();
 			var connectionPool = new SingleNodeConnectionPool(new Uri("http://localhost:9200"));
 			var settings = new ConnectionSettings(connectionPool, new InMemoryConnection())
-				.OnRequestCompleted(r => counter++);
+                .DisableDirectStreaming()
+				.OnRequestCompleted(response =>
+				{
+                    // log out the request
+                    if (response.RequestBodyInBytes != null)
+                    {
+                        list.Add(
+                            $"{response.HttpMethod} {response.Uri} \n" +
+                            $"{Encoding.UTF8.GetString(response.RequestBodyInBytes)}");
+                    }
+                    else
+                    {
+                        list.Add($"{response.HttpMethod} {response.Uri}");
+                    }
+
+                    // log out the response
+                    if (response.ResponseBodyInBytes != null)
+                    {
+                        list.Add($"Status: {response.HttpStatusCode}\n" +
+                                 $"{Encoding.UTF8.GetString(response.ResponseBodyInBytes)}\n" +
+                                 $"{new string('-', 30)}\n");
+                    }
+                    else
+                    {
+                        list.Add($"Status: {response.HttpStatusCode}\n" +
+                                 $"{new string('-', 30)}\n");
+                    }
+                });
+
 			var client = new ElasticClient(settings);
-			client.RootNodeInfo();
-			counter.Should().Be(1);
-			client.RootNodeInfoAsync();
-			counter.Should().Be(2);
-		}
+
+            var syncResponse = client.Search<object>(s => s
+                .Scroll("2m")
+                .Sort(ss => ss
+                    .Ascending(SortSpecialField.DocumentIndexOrder)
+                )
+            );
+
+            list.Count.Should().Be(2);
+
+            var asyncResponse = await client.SearchAsync<object>(s => s
+                .Scroll("2m")
+                .Sort(ss => ss
+                    .Ascending(SortSpecialField.DocumentIndexOrder)
+                )
+            );
+
+            list.Count.Should().Be(4);
+            list.ShouldAllBeEquivalentTo(new []
+            {
+                "POST http://localhost:9200/_search?scroll=2m \n{\"sort\":[{\"_doc\":{\"order\":\"asc\"}}]}",
+                "Status: 200\n------------------------------\n",
+                "POST http://localhost:9200/_search?scroll=2m \n{\"sort\":[{\"_doc\":{\"order\":\"asc\"}}]}",
+                "Status: 200\n------------------------------\n"
+            });
+        }
 
 		public void ConfiguringSSL()
 		{