make sure types that implement DebuggerDisplay override ToString since these are likely to get logged (#4002)

(cherry picked from commit 901e60d)

Author: Mpdreamz

src/Nest/CommonAbstractions/Infer/Field/Field.cs

@@ -87,6 +87,8 @@ public Field(PropertyInfo property, double? boost, string format = null)
 			+ $"{(!string.IsNullOrEmpty(Format) ? " format: " + Format : string.Empty)}"
 			+ $"{(_type == null ? string.Empty : " typeof: " + _type.Name)}";
 
+		public override string ToString() => DebugDisplay;
+
 		private string PropertyDebug => Property == null ? null : $"PropertyInfo: {Property.Name}";
 
 		public bool Equals(Field other) => _type != null

src/Nest/CommonAbstractions/Infer/Fields/Fields.cs

@@ -22,6 +22,8 @@ public class Fields : IUrlParameter, IEnumerable<Field>, IEquatable<Fields>
 
 		private string DebugDisplay =>
 			$"Count: {ListOfFields.Count} [" + string.Join(",", ListOfFields.Select((t, i) => $"({i + 1}: {t?.DebugDisplay ?? "NULL"})")) + "]";
+		
+		public override string ToString() => DebugDisplay;
 
 		IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
 

src/Nest/CommonAbstractions/Infer/Id/Id.cs

@@ -68,7 +68,7 @@ string IUrlParameter.GetString(IConnectionConfigurationValues settings)
 
 		public static Id From<T>(T document) where T : class => new Id(document);
 
-		public override string ToString() => StringOrLongValue;
+		public override string ToString() => DebugDisplay;
 
 		public override bool Equals(object obj)
 		{

src/Nest/CommonAbstractions/Infer/IndexName/IndexName.cs

@@ -34,7 +34,7 @@ private IndexName(string index, Type type, string cluster = null)
 		public Type Type { get; }
 
 		internal string DebugDisplay => Type == null ? Name : $"{nameof(IndexName)} for typeof: {Type?.Name}";
-
+		
 		private static int TypeHashCode { get; } = typeof(IndexName).GetHashCode();
 
 		bool IEquatable<IndexName>.Equals(IndexName other) => EqualsMarker(other);

src/Nest/CommonAbstractions/Infer/Indices/Indices.cs

@@ -24,6 +24,8 @@ internal Indices(IEnumerable<IndexName> indices) : base(new ManyIndices(indices)
 			types => $"Count: {types.Indices.Count} [" + string.Join(",", types.Indices.Select((t, i) => $"({i + 1}: {t.DebugDisplay})")) + "]"
 		);
 
+		public override string ToString() => DebugDisplay;
+
 		string IUrlParameter.GetString(IConnectionConfigurationValues settings) => Match(
 			all => "_all",
 			many =>

src/Nest/CommonAbstractions/Infer/JoinFieldRouting/Routing.cs

@@ -47,6 +47,8 @@ public Routing(object document)
 
 		private string DebugDisplay => StringOrLongValue ?? "Routing from instance typeof: " + Document?.GetType().Name;
 
+		public override string ToString() => DebugDisplay;
+
 		private static int TypeHashCode { get; } = typeof(Routing).GetHashCode();
 
 		public bool Equals(Routing other)

src/Nest/CommonAbstractions/Infer/Name/Name.cs

@@ -13,6 +13,8 @@ public class Name : IEquatable<Name>, IUrlParameter
 
 		private string DebugDisplay => Value;
 
+		public override string ToString() => DebugDisplay;
+
 		private static int TypeHashCode { get; } = typeof(Name).GetHashCode();
 
 		public bool Equals(Name other) => EqualsString(other?.Value);

src/Nest/CommonAbstractions/Infer/Name/Names.cs

@@ -22,6 +22,8 @@ public Names(IEnumerable<Name> names)
 
 		private string DebugDisplay => ((IUrlParameter)this).GetString(null);
 
+		public override string ToString() => DebugDisplay;
+
 		public bool Equals(Names other) => EqualsAllIds(Value, other.Value);
 
 		string IUrlParameter.GetString(IConnectionConfigurationValues settings) =>

src/Nest/CommonAbstractions/Infer/NodeId/NodeIds.cs

@@ -20,6 +20,8 @@ public NodeIds(IEnumerable<string> nodeIds)
 
 		private string DebugDisplay => ((IUrlParameter)this).GetString(null);
 
+		public override string ToString() => DebugDisplay;
+
 		public bool Equals(NodeIds other) => EqualsAllIds(Value, other.Value);
 
 		string IUrlParameter.GetString(IConnectionConfigurationValues settings) => string.Join(",", Value);

src/Nest/CommonAbstractions/Infer/PropertyName/PropertyName.cs

@@ -43,6 +43,8 @@ public PropertyName(PropertyInfo property)
 		internal string DebugDisplay =>
 			$"{Expression?.ToString() ?? PropertyDebug ?? Name}{(_type == null ? "" : " typeof: " + _type.Name)}";
 
+		public override string ToString() => DebugDisplay;
+
 		private string PropertyDebug => Property == null ? null : $"PropertyInfo: {Property.Name}";
 		private static int TypeHashCode { get; } = typeof(PropertyName).GetHashCode();