added SkipOnTeamCity attribute for cancel bulk all tests that suffer from timing issues on the build server

Author: Mpdreamz

src/Tests/Document/Multiple/BulkAll/BulkAllApiTests.cs

@@ -113,7 +113,7 @@ private static void OnError(ref Exception ex, Exception e, EventWaitHandle handl
 			throw e;
 		}
 
-		[I]
+		[I, SkipOnTeamCity("this test is extremely flakey on TC, but never fails localy")]
 		public void DisposingObservableCancelsBulkAll()
 		{
 			var index = CreateIndexName();
@@ -158,7 +158,7 @@ public void DisposingObservableCancelsBulkAll()
 			bulkObserver.TotalNumberOfFailedBuffers.Should().Be(0);
 		}
 
-		[I]
+		[I, SkipOnTeamCity("this test is extremely flakey on TC, but never fails localy")]
 		public void CancelBulkAll()
 		{
 			var index = CreateIndexName();

src/Tests/Framework/XUnitPlumbing/IntegrationTestDiscoverer.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using System.Linq;
 using System.Reflection;
 using Xunit;
@@ -8,6 +9,8 @@ namespace Tests.Framework
 {
 	public class IntegrationTestDiscoverer : NestTestDiscoverer
 	{
+		private bool RunningOnTeamCity { get; } = !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("TEAMCITY_VERSION"));
+
 		public IntegrationTestDiscoverer(IMessageSink diagnosticMessageSink)
 			: base(diagnosticMessageSink, TestClient.Configuration.RunIntegrationTests) { }
 
@@ -17,29 +20,33 @@ protected override bool SkipMethod(ITestFrameworkDiscoveryOptions discoveryOptio
 			var method = classOfMethod.GetMethod(testMethod.Method.Name, BindingFlags.FlattenHierarchy | BindingFlags.NonPublic | BindingFlags.Public)
 				?? testMethod.Method.ToRuntimeMethod();
 
-			return TypeSkipVersionAttributeSatisfies(classOfMethod) ||
-				   MethodSkipVersionAttributeSatisfies(method);
+			return TypeSkipVersionAttributeSatisfies(classOfMethod)
+			       || MethodSkipVersionAttributeSatisfies(method)
+			       || SkipWhenRunOnTeamCity(classOfMethod, method);
 		}
 
-
-		private static bool TypeSkipVersionAttributeSatisfies(Type classOfMethod)
+		private bool SkipWhenRunOnTeamCity(Type classOfMethod, MethodInfo info)
 		{
-			var attributes = classOfMethod.GetAttributes<SkipVersionAttribute>();
-			if (!attributes.Any()) return false;
+			if (!this.RunningOnTeamCity) return false;
 
-			return attributes
-				.SelectMany(a => a.Ranges)
-				.Any(range => TestClient.VersionUnderTestSatisfiedBy(range.ToString()));
+			var attributes = classOfMethod.GetAttributes<SkipOnTeamCityAttribute>().Concat(info.GetAttributes<SkipOnTeamCityAttribute>());
+			return attributes.Any();
 		}
 
-		private static bool MethodSkipVersionAttributeSatisfies(MethodInfo methodInfo)
+		private static bool TypeSkipVersionAttributeSatisfies(Type classOfMethod) =>
+			VersionUnderTestMatchesAttribute(classOfMethod.GetAttributes<SkipVersionAttribute>());
+
+		private static bool MethodSkipVersionAttributeSatisfies(MethodInfo methodInfo) =>
+			VersionUnderTestMatchesAttribute(methodInfo.GetAttributes<SkipVersionAttribute>());
+
+		private static bool VersionUnderTestMatchesAttribute(IEnumerable<SkipVersionAttribute> attributes)
 		{
-			var attributes = methodInfo.GetAttributes<SkipVersionAttribute>();
 			if (!attributes.Any()) return false;
 
 			return attributes
 				.SelectMany(a => a.Ranges)
 				.Any(range => TestClient.VersionUnderTestSatisfiedBy(range.ToString()));
 		}
+
 	}
 }

src/Tests/Framework/XUnitPlumbing/SkipOnTeamCityAttribute.cs

@@ -0,0 +1,11 @@
+using System;
+
+namespace Tests.Framework
+{
+	public class SkipOnTeamCityAttribute : Attribute
+	{
+		public SkipOnTeamCityAttribute(string reason)
+		{
+		}
+	}
+}

src/Tests/Tests.csproj

@@ -39,4 +39,4 @@
   <ItemGroup>
     <EmbeddedResource Include="Document\Single\Attachment\Attachment_Test_Document.pdf" />
   </ItemGroup>
-</Project>
+</Project>