Skip to content

Commit b8cdbc0

Browse files
committed
fix on empty buckets (#3068)
Change `do { ... } while` loop to `while` loop so the deserialisation doesn't crash when receiving an empty aggregation bucket.
1 parent 207a15c commit b8cdbc0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/Nest/Aggregations/AggregateJsonConverter.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -498,14 +498,14 @@ private IAggregate GetMultiBucketAggregate(JsonReader reader, JsonSerializer ser
498498
{
499499
reader.Read();
500500
var aggs = new Dictionary<string, IAggregate>();
501-
do
501+
while (reader.TokenType != JsonToken.EndObject)
502502
{
503503
var name = reader.Value.ToString();
504504
reader.Read();
505505
var innerAgg = this.ReadAggregate(reader, serializer);
506506
aggs.Add(name, innerAgg);
507507
reader.Read();
508-
} while (reader.TokenType != JsonToken.EndObject);
508+
}
509509

510510
reader.Read();
511511
return new FiltersAggregate(aggs);

0 commit comments

Comments
 (0)