Fix #962: Analyze() on an empty string should not throw an exception

Author: gmarz

src/Nest/ElasticClient-Analyze.cs

@@ -16,7 +16,6 @@ public IAnalyzeResponse Analyze(Func<AnalyzeDescriptor, AnalyzeDescriptor> analy
 					IRequest<AnalyzeRequestParameters> request = d;
 					var text = request.RequestParameters.GetQueryStringValue<string>("text");
 					request.RequestParameters.RemoveQueryString("text");
-					text.ThrowIfNullOrEmpty("No text specified to analyze");
 					return this.RawDispatch.IndicesAnalyzeDispatch<AnalyzeResponse>(p, text);
 				}
 			);
@@ -32,7 +31,6 @@ public IAnalyzeResponse Analyze(IAnalyzeRequest analyzeRequest)
 					IRequest<AnalyzeRequestParameters> request = d;
 					var text = request.RequestParameters.GetQueryStringValue<string>("text");
 					request.RequestParameters.RemoveQueryString("text");
-					text.ThrowIfNullOrEmpty("No text specified to analyze");
 					return this.RawDispatch.IndicesAnalyzeDispatch<AnalyzeResponse>(p, text);
 				}
 			);
@@ -48,7 +46,6 @@ public Task<IAnalyzeResponse> AnalyzeAsync(Func<AnalyzeDescriptor, AnalyzeDescri
 					IRequest<AnalyzeRequestParameters> request = d;
 					var text = request.RequestParameters.GetQueryStringValue<string>("text");
 					request.RequestParameters.RemoveQueryString("text");
-					text.ThrowIfNullOrEmpty("No text specified to analyze");
 					return this.RawDispatch.IndicesAnalyzeDispatchAsync<AnalyzeResponse>(p, text);
 				}
 			);
@@ -64,7 +61,6 @@ public Task<IAnalyzeResponse> AnalyzeAsync(IAnalyzeRequest analyzeRequest)
 					IRequest<AnalyzeRequestParameters> request = d;
 					var text = request.RequestParameters.GetQueryStringValue<string>("text");
 					request.RequestParameters.RemoveQueryString("text");
-					text.ThrowIfNullOrEmpty("No text specified to analyze");
 					return this.RawDispatch.IndicesAnalyzeDispatchAsync<AnalyzeResponse>(p, text);
 				}
 			);

src/Tests/Nest.Tests.Integration/Core/Analyze/AnalyzeTests.cs

@@ -0,0 +1,30 @@
+using NUnit.Framework;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+using FluentAssertions;
+
+namespace Nest.Tests.Integration.Core.Analyze
+{
+	[TestFixture]
+	public class AnalyzeTests : IntegrationTests
+	{
+		[Test]
+		public void AnalyzeTest()
+		{
+			var request = new AnalyzeRequest("text to analyze");
+			var result = this.Client.Analyze(request);
+			result.IsValid.Should().BeTrue();
+		}
+
+		[Test]
+		public void AnalyzeEmptyStringDoesNotThrow()
+		{
+			var request = new AnalyzeRequest(string.Empty);
+			var result = this.Client.Analyze(request);
+			result.IsValid.Should().BeFalse();
+		}
+	}
+}

src/Tests/Nest.Tests.Integration/Nest.Tests.Integration.csproj

@@ -105,6 +105,7 @@
     <Compile Include="Connection\Failover\SniffTests.cs" />
     <Compile Include="Connection\HttpClient\HttpClientTests.cs" />
     <Compile Include="Connection\Thrift\ThiftBugReportTests.cs" />
+    <Compile Include="Core\Analyze\AnalyzeTests.cs" />
     <Compile Include="Core\Bulk\BulkTests.cs" />
     <Compile Include="Core\Bulk\BulkUpdateTests.cs" />
     <Compile Include="Core\CountTests.cs" />