fix #3116 instances of gethashcode in equals implementation (#3117)

* fix #3116 instances of gethashcode in equals implementation

* Equals on types and indices now ignores order and implements == operator

Conflicts:
	src/Nest/CommonAbstractions/Infer/Indices/Indices.cs
	src/Nest/CommonAbstractions/Infer/Types/Types.cs

Author: Mpdreamz

src/Nest/CommonAbstractions/Infer/Indices/Indices.cs

@@ -74,8 +74,7 @@ string IUrlParameter.GetString(IConnectionConfigurationValues settings)
 				all => "_all",
 				many =>
 				{
-					var nestSettings = settings as IConnectionSettingsValues;
-					if (nestSettings == null)
+					if (!(settings is IConnectionSettingsValues nestSettings))
 						throw new Exception("Tried to pass index names on querysting but it could not be resolved because no nest settings are available");
 
 					var infer = nestSettings.Inferrer;
@@ -85,6 +84,10 @@ string IUrlParameter.GetString(IConnectionConfigurationValues settings)
 			);
 		}
 
+		public static bool operator ==(Indices left, Indices right) => Equals(left, right);
+
+		public static bool operator !=(Indices left, Indices right) => !Equals(left, right);
+
 		public override bool Equals(object obj)
 		{
 			if (!(obj is Indices other)) return false;
@@ -97,12 +100,11 @@ public override bool Equals(object obj)
 			);
 		}
 
-		private static bool EqualsAllIndices(IReadOnlyList<IndexName> indicesCurrent, IReadOnlyList<IndexName> indicesOther)
+		private static bool EqualsAllIndices(IReadOnlyList<IndexName> thisIndices, IReadOnlyList<IndexName> otherIndices)
 		{
-			if (indicesCurrent == null && indicesOther == null) return true;
-			if (indicesCurrent == null || indicesOther == null) return false;
-			if (indicesCurrent.Count != indicesOther.Count) return false;
-			return indicesCurrent.Zip(indicesOther, Tuple.Create).All(t=>t.Item1.Equals(t.Item2));
+			if (thisIndices == null && otherIndices == null) return true;
+			if (thisIndices == null || otherIndices == null) return false;
+			return thisIndices.Count == otherIndices.Count && !thisIndices.Except(otherIndices).Any();
 		}
 
 		public override int GetHashCode()

src/Nest/CommonAbstractions/Infer/Types/Types.cs

@@ -85,6 +85,9 @@ string IUrlParameter.GetString(IConnectionConfigurationValues settings)
 			);
 
 		}
+		public static bool operator ==(Types left, Types right) => Equals(left, right);
+
+		public static bool operator !=(Types left, Types right) => !Equals(left, right);
 
 		public override bool Equals(object obj)
 		{
@@ -98,12 +101,12 @@ public override bool Equals(object obj)
 			);
 		}
 
-		private static bool EqualsAllTypes(IReadOnlyList<TypeName> indicesCurrent, IReadOnlyList<TypeName> indicesOther)
+		private static bool EqualsAllTypes(IReadOnlyList<TypeName> thisTypes, IReadOnlyList<TypeName> otherTypes)
 		{
-			if (indicesCurrent == null && indicesOther == null) return true;
-			if (indicesCurrent == null || indicesOther == null) return false;
-			if (indicesCurrent.Count != indicesOther.Count) return false;
-			return indicesCurrent.Zip(indicesOther, Tuple.Create).All(t=>t.Item1.Equals(t.Item2));
+			if (thisTypes == null && otherTypes == null) return true;
+			if (thisTypes == null || otherTypes == null) return false;
+			if (thisTypes.Count != otherTypes.Count) return false;
+			return thisTypes.Count == otherTypes.Count && !thisTypes.Except(otherTypes).Any();
 		}
 
 		public override int GetHashCode()

src/Tests/ClientConcepts/HighLevel/Inference/IndexNameInference.doc.cs

@@ -181,6 +181,11 @@ [U] public void EqualsValidation()
 			Index<Project>("cluster_one").Should().NotBe("cluster_one:project");
 			Index<Project>().Should().NotBe(Index<Developer>());
 			Index<Project>("cluster_one").Should().NotBe(Index<Developer>("cluster_one"));
+
+			Nest.Indices indices1 = "foo,bar";
+			Nest.Indices indices2 = "bar,foo";
+			indices1.Should().Be(indices2);
+			(indices1 == indices2).Should().BeTrue();
 		}
 
 		//hide

src/Tests/ClientConcepts/HighLevel/Inference/TypesAndRelationsInference.doc.cs

@@ -129,6 +129,12 @@ [U] public void EqualsValidation()
 
 			Relation<Project>().Should().Be(Relation<Project>());
 			Relation<Project>().Should().NotBe(Relation<Developer>());
+
+
+			Nest.Types types1 = "foo,bar";
+			Nest.Types types2 = "bar,foo";
+			types1.Should().Be(types2);
+			(types1 == types2).Should().BeTrue();
 		}
 
 		//hide