can now specify ThrowExceptions() on a per request basis, the build in extension methods that do not return an IResponse now set this so that they do not eat bad responses

Author: Mpdreamz

src/Elasticsearch.Net/Configuration/RequestConfiguration.cs

@@ -81,6 +81,13 @@ public interface IRequestConfiguration
 		/// Use the following client certificates to authenticate this single request
 		/// </summary>
 		X509CertificateCollection ClientCertificates { get; set; }
+
+		/// <summary>
+		/// Instead of following a c/go like error checking on response.IsValid always throw an exception
+		/// on the client when a call resulted in an exception on either the client or the Elasticsearch server.
+		/// <para>Reasons for such exceptions could be search parser errors, index missing exceptions, etc...</para>
+		/// </summary>
+		bool ThrowExceptions { get; set; }
 	}
 
 	public class RequestConfiguration : IRequestConfiguration
@@ -105,6 +112,7 @@ public class RequestConfiguration : IRequestConfiguration
 		public string RunAs { get; set; }
 
 		public X509CertificateCollection ClientCertificates { get; set; }
+		public bool ThrowExceptions { get; set; }
 	}
 
 	public class RequestConfigurationDescriptor : IRequestConfiguration
@@ -125,6 +133,7 @@ public class RequestConfigurationDescriptor : IRequestConfiguration
 		bool IRequestConfiguration.EnableHttpPipelining { get; set; } = true;
 		string IRequestConfiguration.RunAs { get; set; }
 		X509CertificateCollection IRequestConfiguration.ClientCertificates { get; set; }
+		bool IRequestConfiguration.ThrowExceptions { get; set; }
 
 		public RequestConfigurationDescriptor(IRequestConfiguration config)
 		{
@@ -202,6 +211,12 @@ public RequestConfigurationDescriptor DisablePing(bool? disable = true)
 			return this;
 		}
 
+		public RequestConfigurationDescriptor ThrowExceptions(bool throwExceptions = true)
+		{
+			Self.ThrowExceptions = throwExceptions;
+			return this;
+		}
+
 		public RequestConfigurationDescriptor DisableDirectStreaming(bool? disable = true)
 		{
 			Self.DisableDirectStreaming = disable;

src/Elasticsearch.Net/Transport/Pipeline/RequestData.cs

@@ -40,6 +40,7 @@ public class RequestData
 		public string ProxyUsername { get; }
 		public string ProxyPassword { get; }
 		public bool DisableAutomaticProxyDetection { get; }
+		public bool ThrowExceptions { get; }
 
 		public BasicAuthenticationCredentials BasicAuthorizationCredentials { get; }
 		public IEnumerable<int> AllowedStatusCodes { get; }
@@ -81,6 +82,7 @@ private RequestData(
 			this.Headers = global.Headers != null ? new NameValueCollection(global.Headers) : new NameValueCollection();
 			this.RunAs = local?.RunAs;
 			this.SkipDeserializationForStatusCodes = global?.SkipDeserializationForStatusCodes;
+			this.ThrowExceptions = local?.ThrowExceptions ?? global.ThrowExceptions;
 
 			this.RequestTimeout = local?.RequestTimeout ?? global.RequestTimeout;
 			this.PingTimeout =

src/Elasticsearch.Net/Transport/Transport.cs

@@ -176,7 +176,7 @@ private TResponse FinalizeResponse<TResponse>(RequestData requestData, IRequestP
 			if (response?.ApiCall == null)
 				pipeline.BadResponse(ref response, callDetails, requestData, clientException);
 
-			HandleElasticsearchClientException(clientException, response);
+			HandleElasticsearchClientException(requestData, clientException, response);
 			return response;
 		}
 
@@ -188,12 +188,12 @@ private static IApiCallDetails GetMostRecentCallDetails<TResponse>(TResponse res
 		}
 
 
-		private void HandleElasticsearchClientException(ElasticsearchClientException clientException, IElasticsearchResponse response)
+		private void HandleElasticsearchClientException(RequestData data, Exception clientException, IElasticsearchResponse response)
 		{
 			if (clientException != null && response.ApiCall.OriginalException == null && response.ApiCall is ApiCallDetails a)
 				a.OriginalException = clientException;
 			this.Settings.OnRequestCompleted?.Invoke(response.ApiCall);
-			if (clientException != null && this.Settings.ThrowExceptions) throw clientException;
+			if (clientException != null && data.ThrowExceptions) throw clientException;
 		}
 
 		private static void Ping(IRequestPipeline pipeline, Node node)

src/Nest/Document/Multiple/MultiGet/ElasticClient-GetMany.cs

@@ -25,7 +25,12 @@ public static class GetManyExtensions
 		public static IEnumerable<IMultiGetHit<T>> GetMany<T>(this IElasticClient client, IEnumerable<string> ids, IndexName index = null, TypeName type = null)
 			where T : class
 		{
-			var result = client.MultiGet(s => s.GetMany<T>(ids).Index(index).Type(type));
+			var result = client.MultiGet(s => s
+				.RequestConfiguration(r=>r.ThrowExceptions())
+				.GetMany<T>(ids)
+				.Index(index)
+				.Type(type)
+			);
 			return result.GetMany<T>(ids);
 		}
 
@@ -61,7 +66,13 @@ public static async Task<IEnumerable<IMultiGetHit<T>>> GetManyAsync<T>(
 			this IElasticClient client, IEnumerable<string> ids, IndexName index = null, TypeName type = null, CancellationToken cancellationToken = default(CancellationToken))
 			where T : class
 		{
-			var response = await client.MultiGetAsync(s => s.GetMany<T>(ids).Index(index).Type(type), cancellationToken).ConfigureAwait(false);
+			var response = await client.MultiGetAsync(s => s
+				.RequestConfiguration(r=>r.ThrowExceptions())
+				.GetMany<T>(ids)
+				.Index(index)
+				.Type(type),
+				cancellationToken
+			) .ConfigureAwait(false);
 			return response.GetMany<T>(ids);
 		}
 

src/Nest/Document/Multiple/MultiGet/ElasticClient-SourceMany.cs

@@ -28,17 +28,13 @@ public static class SourceManyExtensions
 		public static IEnumerable<T> SourceMany<T>(this IElasticClient client, IEnumerable<string> ids, string index = null, string type = null)
 			where T : class
 		{
-			var result = client.MultiGet(s => s.GetMany<T>(ids, (gs, i) =>
-			{
-				if (!string.IsNullOrEmpty(index))
-					gs.Index(index);
-
-				if (!string.IsNullOrEmpty(type))
-					gs.Type(type);
-
-				return gs;
-			}));
-
+			var result = client.MultiGet(s => s
+				.RequestConfiguration(r=>r.ThrowExceptions())
+				.GetMany<T>(ids, (gs, i) => gs
+					.Index(index)
+					.Type(type)
+				)
+			);
 			return result.SourceMany<T>(ids);
 		}
 
@@ -80,7 +76,13 @@ public static async Task<IEnumerable<T>> SourceManyAsync<T>(
 			this IElasticClient client, IEnumerable<string> ids, string index = null, string type = null, CancellationToken cancellationToken = default(CancellationToken))
 			where T : class
 		{
-			var response = await client.MultiGetAsync(s => s.GetMany<T>(ids, (gs, i) => gs.Index(index).Type(type)), cancellationToken).ConfigureAwait(false);
+			var response = await client.MultiGetAsync(s => s
+				.RequestConfiguration(r=>r.ThrowExceptions())
+				.GetMany<T>(ids, (gs, i) => gs
+					.Index(index)
+					.Type(type)
+				), cancellationToken)
+				.ConfigureAwait(false);
 			return response.SourceMany<T>(ids);
 		}
 

src/Nest/Indices/AliasManagement/GetAlias/ElasticClient-GetAliasesPointingToIndex.cs

@@ -13,7 +13,7 @@ public static class AliasPointingToIndexExtensions
 		/// <param name="index">The index name we want to know aliases of</param>
 		public static IReadOnlyDictionary<string, AliasDefinition> GetAliasesPointingToIndex(this IElasticClient client, IndexName index)
 		{
-			var response = client.GetAlias(a => a.Index(index));
+			var response = client.GetAlias(a => a.Index(index).RequestConfiguration(r=>r.ThrowExceptions()));
 			return AliasesPointingToIndex(index, response);
 		}
 
@@ -23,7 +23,7 @@ public static IReadOnlyDictionary<string, AliasDefinition> GetAliasesPointingToI
 		/// <param name="index">The index name we want to know aliases of</param>
 		public static async Task<IReadOnlyDictionary<string, AliasDefinition>> GetAliasesPointingToIndexAsync(this IElasticClient client, IndexName index)
 		{
-			var response = await client.GetAliasAsync(a => a.Index(index)).ConfigureAwait(false);
+			var response = await client.GetAliasAsync(a => a.Index(index).RequestConfiguration(r=>r.ThrowExceptions())).ConfigureAwait(false);
 			return AliasesPointingToIndex(index, response);
 		}
 

src/Nest/Indices/AliasManagement/GetAlias/ElasticClient-GetIndicesPointingToAlias.cs

@@ -18,7 +18,7 @@ public static class IndicesPointingToAliasExtensions
 		/// <param name="alias">The alias name(s)</param>
 		public static IReadOnlyCollection<string> GetIndicesPointingToAlias(this IElasticClient client, Names alias)
 		{
-			var response = client.GetAlias(a => a.Name(alias));
+			var response = client.GetAlias(a => a.Name(alias).RequestConfiguration(r=>r.ThrowExceptions()));
 			return IndicesPointingToAlias(client.ConnectionSettings, alias, response);
 		}
 
@@ -29,7 +29,7 @@ public static IReadOnlyCollection<string> GetIndicesPointingToAlias(this IElasti
 		/// <param name="alias">The alias name(s)</param>
 		public static async Task<IReadOnlyCollection<string>> GetIndicesPointingToAliasAsync(this IElasticClient client, Names alias)
 		{
-			var response = await client.GetAliasAsync(a => a.Name(alias)).ConfigureAwait(false);
+			var response = await client.GetAliasAsync(a => a.Name(alias).RequestConfiguration(r=>r.ThrowExceptions())).ConfigureAwait(false);
 			return IndicesPointingToAlias(client.ConnectionSettings, alias, response);
 		}