fixed exception serialization on dotnet core

Author: Mpdreamz

src/Elasticsearch.Net/Serialization/ElasticsearchNetJsonStrategy.cs

@@ -49,10 +49,11 @@ private IEnumerable<JsonObject> FlattenExceptions(Exception e)
 		private JsonObject ToExceptionJsonObject(Exception e, int depth)
 		{
 			var o = new JsonObject();
-
+#if !DOTNETCORE
 			var si = new SerializationInfo(e.GetType(), new FormatterConverter());
 			var sc = new StreamingContext();
 			e.GetObjectData(si, sc);
+			//TODO Loop over ISerializable data
 
 			var helpUrl = si.GetString("HelpURL");
 			var stackTrace = si.GetString("StackTraceString");
@@ -62,8 +63,16 @@ private JsonObject ToExceptionJsonObject(Exception e, int depth)
 			var hresult = si.GetInt32("HResult");
 			var source = si.GetString("Source");
 			var className = si.GetString("ClassName");
-
-			//TODO Loop over ISerializable data
+#else
+			var helpUrl = e.HelpLink;
+			var stackTrace = e.StackTrace;
+			var remoteStackTrace = string.Empty;
+			var remoteStackIndex = string.Empty;
+			var exceptionMethod = string.Empty;
+			var hresult = e.HResult;
+			var source = e.Source;
+			var className = string.Empty;
+#endif
 
 			o.Add("Depth", depth);
 			o.Add("ClassName", className);
@@ -74,7 +83,9 @@ private JsonObject ToExceptionJsonObject(Exception e, int depth)
 			o.Add("RemoteStackIndex", remoteStackIndex);
 			o.Add("HResult", hresult);
 			o.Add("HelpURL", helpUrl);
+#if !DOTNETCORE
 			this.WriteStructuredExceptionMethod(o, exceptionMethod);
+#endif
 			return o;
 		}
 

src/Tests/Reproduce/GithubIssue2052.cs

@@ -18,7 +18,11 @@ public class GithubIssue2052
 		private static object _bulkHeader =
 			 new { index = new { _index = "myIndex", _type = "myDocumentType" } };
 		private readonly ElasticLowLevelClient _client;
+#if !DOTNETCORE
 		private AssemblyName _assemblyName = new AssemblyName(typeof(GithubIssue2052).Assembly.FullName);
+#else
+		private AssemblyName _assemblyName = new AssemblyName(typeof(GithubIssue2052).GetTypeInfo().Assembly.FullName);
+#endif
 
 		public GithubIssue2052()
 		{
@@ -73,7 +77,7 @@ private IEnumerable<object> ExceptionJson(Exception e)
 			int maxExceptions = 20;
 			do
 			{
-
+#if !DOTNETCORE
 				var si = new SerializationInfo(e.GetType(), new FormatterConverter());
 				var sc = new StreamingContext();
 				e.GetObjectData(si, sc);
@@ -86,6 +90,16 @@ private IEnumerable<object> ExceptionJson(Exception e)
 				var hresult = si.GetInt32("HResult");
 				var source = si.GetString("Source");
 				var className = si.GetString("ClassName");
+#else
+				var helpUrl = e.HelpLink;
+				var stackTrace = e.StackTrace;
+				var remoteStackTrace = string.Empty;
+				var remoteStackIndex = string.Empty;
+				var exceptionMethod = string.Empty;
+				var hresult = e.HResult;
+				var source = e.Source;
+				var className = string.Empty;
+#endif
 
 				yield return new
 				{
@@ -98,7 +112,9 @@ private IEnumerable<object> ExceptionJson(Exception e)
 					RemoteStackIndex = remoteStackIndex,
 					HResult = hresult,
 					HelpURL = helpUrl,
+#if !DOTNETCORE
 					ExceptionMethod = this.WriteStructuredExceptionMethod(exceptionMethod)
+#endif
 				};
 				depth++;
 				e = e.InnerException;