Update documentation

Author: russcam

docs/asciidoc/aggregations/bucket/filter/filter-aggregation-usage.asciidoc

@@ -7,7 +7,7 @@
 [[filter-aggregation-usage]]
 == Filter Aggregation Usage
 
-Defines a single bucket of all the documents in the current document set context that match a specified filter. 
+Defines a single bucket of all the documents in the current document set context that match a specified filter.
 Often this will be used to narrow down the current aggregation context to a specific set of documents.
 
 Be sure to read the Elasticsearch documentation on {ref_current}/search-aggregations-bucket-filter-aggregation.html[Filter Aggregation]

docs/asciidoc/aggregations/pipeline/moving-average/moving-average-ewma-aggregation-usage.asciidoc

@@ -45,7 +45,7 @@ new SearchRequest<Project>()
     {
         Field = "startedOn",
         Interval = DateInterval.Month,
-        Aggregations = 
+        Aggregations =
             new SumAggregation("commits", "numberOfCommits") &&
             new MovingAverageAggregation("commits_moving_avg", "commits")
             {

docs/asciidoc/aggregations/pipeline/moving-average/moving-average-holt-linear-aggregation-usage.asciidoc

@@ -46,7 +46,7 @@ new SearchRequest<Project>()
     {
         Field = "startedOn",
         Interval = DateInterval.Month,
-        Aggregations = 
+        Aggregations =
             new SumAggregation("commits", "numberOfCommits") &&
             new MovingAverageAggregation("commits_moving_avg", "commits")
             {

docs/asciidoc/aggregations/pipeline/moving-average/moving-average-holt-winters-aggregation-usage.asciidoc

@@ -51,7 +51,7 @@ new SearchRequest<Project>()
     {
         Field = "startedOn",
         Interval = DateInterval.Month,
-        Aggregations = 
+        Aggregations =
             new SumAggregation("commits", "numberOfCommits") &&
             new MovingAverageAggregation("commits_moving_avg", "commits")
             {

docs/asciidoc/aggregations/pipeline/moving-average/moving-average-linear-aggregation-usage.asciidoc

@@ -44,7 +44,7 @@ new SearchRequest<Project>()
     {
         Field = "startedOn",
         Interval = DateInterval.Month,
-        Aggregations = 
+        Aggregations =
             new SumAggregation("commits", "numberOfCommits") &&
             new MovingAverageAggregation("commits_moving_avg", "commits")
             {

docs/asciidoc/aggregations/pipeline/moving-average/moving-average-simple-aggregation-usage.asciidoc

@@ -45,7 +45,7 @@ new SearchRequest<Project>()
     {
         Field = "startedOn",
         Interval = DateInterval.Month,
-        Aggregations = 
+        Aggregations =
             new SumAggregation("commits", "numberOfCommits") &&
             new MovingAverageAggregation("commits_moving_avg", "commits")
             {

docs/asciidoc/query-dsl/specialized/script/script-query-usage.asciidoc

@@ -7,6 +7,10 @@
 [[script-query-usage]]
 == Script Query Usage
 
+A query allowing to define {ref_current}/modules-scripting.html[scripts] as queries.
+
+See the Elasticsearch documentation on {ref_current}/query-dsl-script-query.html[script query] for more details.
+
 === Fluent DSL Example
 
 [source,csharp]
@@ -16,7 +20,7 @@ q
     .Name("named_query")
     .Boost(1.1)
     .Inline(_templateString)
-    .Params(p=>p.Add("param1", 1))
+    .Params(p => p.Add("param1", 50))
 )
 ----
 
@@ -31,7 +35,7 @@ new ScriptQuery
     Inline = _templateString,
     Params = new Dictionary<string, object>
     {
-        { "param1", 1 }
+        { "param1", 50 }
     }
 }
 ----
@@ -44,12 +48,20 @@ new ScriptQuery
     "_name": "named_query",
     "boost": 1.1,
     "script": {
-      "inline": "doc['num1'].value > param1",
+      "inline": "doc['numberOfCommits'].value > param1",
       "params": {
-        "param1": 1
+        "param1": 50
       }
     }
   }
 }
 ----
 
+=== Handling Responses
+
+[source,csharp]
+----
+response.IsValid.Should().BeTrue();
+response.Documents.Count().Should().BeGreaterThan(0);
+----
+

src/Tests/QueryDsl/Specialized/Script/ScriptQueryUsageTests.cs

@@ -1,15 +1,29 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Threading.Tasks;
+using FluentAssertions;
 using Nest;
+using Tests.Framework;
 using Tests.Framework.Integration;
 using Tests.Framework.MockData;
+using Xunit;
 
 namespace Tests.QueryDsl.Specialized.Script
 {
-	public class ScriptUsageTests : QueryDslUsageTestsBase
+	/**
+	* A query allowing to define {ref_current}/modules-scripting.html[scripts] as queries.
+	*
+	* See the Elasticsearch documentation on {ref_current}/query-dsl-script-query.html[script query] for more details.
+	*/
+	[Collection(IntegrationContext.ReadOnly)]
+	public class ScriptQueryUsageTests : QueryDslUsageTestsBase
 	{
-		public ScriptUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }
+		public ScriptQueryUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }
 
-		private static readonly string _templateString = "doc['num1'].value > param1";
+		private static readonly string _templateString = "doc['numberOfCommits'].value > param1";
+
+		protected override bool ForceInMemory => false;
 
 		protected override object QueryJson => new
 		{
@@ -19,8 +33,8 @@ public ScriptUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage)
 				boost = 1.1,
 				script = new
 				{
-					inline = "doc['num1'].value > param1",
-					@params = new { param1 = 1 }
+					inline = "doc['numberOfCommits'].value > param1",
+					@params = new { param1 = 50 }
 				}
 			}
 		};
@@ -32,7 +46,7 @@ public ScriptUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage)
 			Inline = _templateString,
 			Params = new Dictionary<string, object>
 			{
-				{ "param1", 1 }
+				{ "param1", 50 }
 			}
 		};
 
@@ -41,9 +55,18 @@ protected override QueryContainer QueryFluent(QueryContainerDescriptor<Project>
 				.Name("named_query")
 				.Boost(1.1)
 				.Inline(_templateString)
-				.Params(p=>p.Add("param1", 1))
+				.Params(p => p.Add("param1", 50))
 			);
 
+		protected void ExpectResponse(ISearchResponse<Project> response)
+		{
+			response.IsValid.Should().BeTrue();
+			response.Documents.Count().Should().BeGreaterThan(0);
+		}
+
+		[I]
+		protected async Task ReturnsExpectedResponse() => await this.AssertOnAllResponses(ExpectResponse);
+
 		protected override ConditionlessWhen ConditionlessWhen => new ConditionlessWhen<IScriptQuery>(a => a.Script)
 		{
 			q => {