fixed error responses that exceeded 65kb being truncated (sigh WebRequest) causing ElasticsearchServerException to throw a nullreference and .ServerError to always be null

Author: Mpdreamz

src/Elasticsearch.Net/Connection/HttpConnection.cs

@@ -28,6 +28,12 @@ static HttpConnection()
 			ServicePointManager.UseNagleAlgorithm = false;
 			ServicePointManager.Expect100Continue = false;
 			ServicePointManager.DefaultConnectionLimit = 10000;
+			ServicePointManager.SetTcpKeepAlive(true, 2000, 2000);
+			
+			//WebException's GetResponse is limitted to 65kb by default.
+			//Elasticsearch can be alot more chatty then that when dumping exceptions
+			//On error responses, so lets up the ante.
+			HttpWebRequest.DefaultMaximumErrorResponseLength = int.MaxValue;
 		}
 
 		public HttpConnection(IConnectionConfigurationValues settings)
@@ -173,6 +179,8 @@ protected virtual HttpWebRequest CreateWebRequest(Uri uri, string method, byte[]
 			var myReq = (HttpWebRequest)WebRequest.Create(uri);
 			myReq.Accept = "application/json";
 			myReq.ContentType = "application/json";
+			myReq.MaximumResponseHeadersLength = -1;
+			//myReq.AllowWriteStreamBuffering = false;
 			if (this.ConnectionSettings.EnableCompressedResponses)
 			{
 				myReq.AutomaticDecompression = DecompressionMethods.GZip | DecompressionMethods.Deflate;
@@ -232,6 +240,8 @@ private ElasticsearchResponse<Stream> HandleWebException(byte[] data, WebExcepti
 			var httpEx = webException.Response as HttpWebResponse;
 			if (httpEx != null)
 			{
+				//StreamReader ms = new StreamReader(httpEx.GetResponseStream());
+				//var response = ms.ReadToEnd();
 				cs = WebToElasticsearchResponse(data, httpEx.GetResponseStream(), httpEx, method, path);
 				return cs;
 			}

src/Tests/Nest.Tests.Integration/Exceptions/ElasticsearchExceptionTests.cs

@@ -48,12 +48,44 @@ public void ConnectionException_WithThrowingClient_Async()
 				.ThrowOnElasticsearchServerExceptions());
 			Assert.Throws<WebException>(async () => await client.RootNodeInfoAsync());
 		}
+		
+		[Test]
+		public async void ServerError_Is_Set_ClientThat_DoesNotThow_AndDoesNotExposeRawResponse_Async()
+		{
+			var uri = ElasticsearchConfiguration.CreateBaseUri();
+			var client = new ElasticClient(new ConnectionSettings(uri).ExposeRawResponse(false));
+			Assert.DoesNotThrow(async () =>
+			{
+				var result = await client.SearchAsync<ElasticsearchProject>(s => s.QueryRaw(@"{ ""badjson"": {}  }"));
+				result.IsValid.Should().BeFalse();
+				result.ConnectionStatus.HttpStatusCode.Should().Be(400);
+				var e = result.ServerError;
+				e.Should().NotBeNull();
+				e.ExceptionType.Should().Contain("SearchPhaseExecutionException");
+			});
+		}
+		
+		[Test]
+		public void ServerError_Is_Set_ClientThat_DoesNotThow_AndDoesNotExposeRawResponse()
+		{
+			var uri = ElasticsearchConfiguration.CreateBaseUri();
+			var client = new ElasticClient(new ConnectionSettings(uri).ExposeRawResponse(false));
+			Assert.DoesNotThrow(() =>
+			{
+				var result = client.Search<ElasticsearchProject>(s => s.QueryRaw(@"{ ""badjson"": {}  }"));
+				result.IsValid.Should().BeFalse();
+				result.ConnectionStatus.HttpStatusCode.Should().Be(400);
+				var e = result.ServerError;
+				e.Should().NotBeNull();
+				e.ExceptionType.Should().Contain("SearchPhaseExecutionException");
+			});
+		}
 
 		[Test]
 		public void ServerError_Is_Set_ClientThat_DoesNotThow()
 		{
 			var uri = ElasticsearchConfiguration.CreateBaseUri();
-			var client = new ElasticClient(new ConnectionSettings(uri));
+			var client = new ElasticClient(new ConnectionSettings(uri).ExposeRawResponse(true));
 			Assert.DoesNotThrow(() =>
 			{
 				var result = client.Search<ElasticsearchProject>(s => s.QueryRaw(@"{ ""badjson"": {}  }"));