Fix for code review

Author: gmoskovicz

src/Nest/DSL/Reindex/ReindexDescriptor.cs

@@ -6,7 +6,8 @@ public class ReindexDescriptor<T> where T : class
 		internal string _ToIndexName { get; set; }
 		internal string _FromIndexName { get; set; }
 		internal string _Scroll { get; set; }
-		internal int? _Size { get; set; }
+		internal int? _Size { get; set; }
+		internal bool _allTypes { get; set; }
 
 		internal Func<QueryDescriptor<T>, QueryContainer> _QuerySelector { get; set; }
 

src/Nest/Domain/Observers/ReindexObservable.cs

@@ -38,6 +38,7 @@ private void Reindex(IObserver<IReindexResponse<T>> observer)
 			var toIndex = this._reindexDescriptor._ToIndexName;
 			var scroll = this._reindexDescriptor._Scroll ?? "2m";
 			var size = this._reindexDescriptor._Size ?? 100;
+			var allTypes = this._reindexDescriptor._allTypes;
 
 			fromIndex.ThrowIfNullOrEmpty("fromIndex");
 			toIndex.ThrowIfNullOrEmpty("toIndex");
@@ -54,14 +55,10 @@ private void Reindex(IObserver<IReindexResponse<T>> observer)
 			var page = 0;
 			Func<SearchDescriptor<T>, SearchDescriptor<T>> searchDescriptor = s => s.Index(fromIndex);
 
-			if (typeof(T).Name.Equals(typeof(object).Name))
-			{
+			if (allTypes)
 				searchDescriptor = s => searchDescriptor(s).AllTypes();
-			}
 			else
-			{
 				searchDescriptor = s => searchDescriptor(s).Type<T>();
-			}
 
 
 			var searchResult = this.CurrentClient.Search<T>(

src/Nest/ElasticClient-Reindex.cs

@@ -16,9 +16,15 @@ public IObservable<IReindexResponse<T>> Reindex<T>(Func<ReindexDescriptor<T>, Re
 		}
 
 		/// <inheritdoc />
-		public IObservable<IReindexResponse<IDocument>> Reindex(Func<ReindexDescriptor<object>, ReindexDescriptor<object>> reindexSelector)
+		public IObservable<IReindexResponse<IDocument>> Reindex(Func<ReindexDescriptor<IDocument>, ReindexDescriptor<IDocument>> reindexSelector)
 		{
-			return Reindex<object>(reindexSelector);
+			reindexSelector.ThrowIfNull("reindexSelector");
+			var reindexDescriptor = reindexSelector(new ReindexDescriptor<IDocument>());
+
+			reindexDescriptor._allTypes = true;
+
+			var observable = new ReindexObservable<IDocument>(this, _connectionSettings, reindexDescriptor);
+			return observable;
 		}
 	}
 }

src/Nest/IElasticClient.cs

@@ -23,7 +23,7 @@ IObservable<IReindexResponse<T>> Reindex<T>(Func<ReindexDescriptor<T>, ReindexDe
 		/// Helper method that allows you to reindex from one index into another using SCAN and SCROLL.
 		/// </summary>
 		/// <returns>An IObservable you can subscribe to to listen to the progress of the reindexation process</returns>
-		IObservable<IReindexResponse<object>> Reindex(Func<ReindexDescriptor<object>, ReindexDescriptor<object>> reindexSelector);
+		IObservable<IReindexResponse<IDocument>> Reindex(Func<ReindexDescriptor<IDocument>, ReindexDescriptor<IDocument>> reindexSelector);
 
 		/// <summary>
 		/// A search request can be scrolled by specifying the scroll parameter. 

src/Tests/Nest.Tests.Integration/Index/ReindexTests.cs

@@ -13,7 +13,7 @@ public class ReindexTests : IntegrationTests
 		public void ReindexMinimal()
 		{
 			var toIndex = ElasticsearchConfiguration.NewUniqueIndexName();
-			var observable = this.Client.Reindex(r => r
+			var observable = this.Client.Reindex<object>(r => r
 				.FromIndex(ElasticsearchConfiguration.DefaultIndex)
 				.ToIndex(toIndex)
 			);
@@ -53,7 +53,7 @@ public void Reindex()
 					.NumberOfShards(1)
 				)
 			);
-			var observer = new ReindexObserver<object>(
+			var observer = new ReindexObserver<IDocument>(
 				onNext: (r) =>
 				{
 					var scrollResults = r.SearchResponse;