Skip to content

Commit 7860761

Browse files
committed
float level 3 section headers
1 parent ee222c6 commit 7860761

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

docs/7.0-breaking-changes/nest-breaking-changes.asciidoc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@ Most API methods now return classes and not interfaces, for example, the client
147147

148148
In instances where methods can benefit from returning an interface, these have been left intact, for example, `ISearchResponse<T>`.
149149

150+
[float]
150151
==== Why make the change?
151152

152153
Firstly, this significantly reduces the number of types in
@@ -169,6 +170,7 @@ the client calls and objects within that layer so they can be mocked.
169170
`IApiCallDetails.Success` and `ResponseBase.IsValid` have been simplified, making it easier to inspect
170171
if a request to Elasticsearch was indeed successful or not.
171172

173+
[float]
172174
==== Low Level Client
173175

174176
If the status code from Elasticsearch is `2xx` then `.Success` will be `true`. In instances where a `404`
@@ -177,6 +179,7 @@ will be `false`. This is also the case for `HEAD` requests that result in a `404
177179

178180
This is controlled via `IConnectionConfiguration.StatusCodeToResponseSuccess`, which currently has no public setter.
179181

182+
[float]
180183
==== High Level Client
181184

182185
The NEST high level client overrides `StatusCodeToResponseSuccess`, whereby `404` status codes now sets `.Success` as `true`.

0 commit comments

Comments
 (0)