updated build script xmldoc patch to save in the same xml file

Implemented fake task that patches xml docs to support <inheritdoc /> for interface implementations, removed snadcastle which is way tooo slow to be useful :(

fixed failing unit test post-refactor

fixed failing builds due to internalvisibleto being removed

nest & elasticsearch.net sign from the csproj file now, remove need for internalsvisibleto, fixed broken yaml test generator

Author: Mpdreamz

.gitignore

@@ -41,9 +41,14 @@ build/*
 build/tools/*
 !build/tools/sn
 !build/tools/ilmerge
+!build/*.fsx
+!build/*.fsx
+!build/*.ps1
+
 /dep/Newtonsoft.Json.4.0.2
 !new_docs/build
 new_docs/node_modules
+doc/Help
 
 /src/Nest.Tests.Unit/*.ncrunchproject
 *.ncrunchproject

build/InheritDoc.fsx

@@ -0,0 +1,25 @@
+#r "System.Xml.Linq.dll"
+open System.Xml
+open System.Xml.XPath
+open System.Linq
+open System.Xml.Linq
+open System.Text.RegularExpressions
+
+let PatchXmlDoc = fun (file: string) ->
+  let xml = XDocument.Load file
+  let nodes = xml.XPathSelectElements("//inheritdoc") 
+              |> Seq.map (fun n -> 
+                let methodName = n.Parent.Attribute(XName.Get("name")).Value
+                let interfaceName = Regex.Replace(methodName, @"\.([^.]+\.[^.]+\()", ".I$1")
+                let interfaceNode = xml.XPathSelectElement (sprintf "//member[@name='%s']" interfaceName)
+                (n.Parent, interfaceNode)
+              ) 
+              |> Seq.filter (fun (implementationElement, interfaceElement) -> 
+                interfaceElement <> null && implementationElement.HasElements && interfaceElement.HasElements
+              )
+  let nodesReplace = nodes 
+                      |> Seq.iter (fun (implementationElement, interfaceElement) ->
+                        implementationElement.Add (interfaceElement.Descendants().ToList())
+                      ) 
+                    
+  xml.Save file

build/build.fsx

@@ -1,7 +1,10 @@
 // include Fake lib
 #r @"tools/FAKE/tools/FakeLib.dll"
+#load @"InheritDoc.fsx"
 open Fake 
 open System
+open InheritDoc
+
 
 // Properties
 let buildDir = "build/output/"
@@ -19,6 +22,10 @@ Target "BuildApp" (fun _ ->
     !! "src/**/*.csproj"
       |> Seq.map(fun f -> (f, buildDir + directoryInfo(f).Name.Replace(".csproj", "")))
       |> Seq.iter(fun (f,d) -> MSBuildRelease d "Build" (seq { yield f }) |> ignore)
+    
+    //Scan for xml docs and patch them to replace <inheritdoc /> with the documentation
+    //from their interfaces
+    !! "build/output/Nest/Nest.xml" |> Seq.iter(fun f -> PatchXmlDoc f)
 )
 
 Target "Test" (fun _ ->
@@ -69,7 +76,7 @@ let nugetPack = fun name ->
     CreateDir nugetOutDir
 
     let dir = sprintf "%s/%s/" buildDir name
-    let version = "1.0.0-c2"
+    let version = "1.0.0-c4"
     NuGetPack (fun p ->
       {p with 
         Version = version
@@ -95,9 +102,9 @@ Target "Version" (fun _ ->
   let assemblyVersion = sprintf "%i.%i.0.0" version.Major version.Minor 
 
   trace (sprintf "%s %s" v assemblyVersion)
-
 )
 
+
 Target "Release" (fun _ -> 
     if not <| fileExists keyFile 
       then failwithf "{0} does not exist to sign the assemblies" keyFile 

doc/Help/Documentation.chm

@@ -38,7 +38,7 @@ namespace Elasticsearch.Net
 	</text>
 	}
 
-	internal static class KnownEnums
+	public static class KnownEnums
 	{
 		public static string Resolve(Enum e)
 		{

doc/documentation.shfbproj

@@ -46,7 +46,7 @@ namespace Elasticsearch.Net
 		public @method.QueryStringParamName @(mm.ToPascalCase())(@kv.Value.CsharpType(mm) @mm)
 		{
 			this._@(mm) = @Raw(setter);
-			this.Add("@mm", this._@mm);
+			this.AddQueryString("@mm", this._@mm);
 			return this;
 		}
 		</text>

doc/ghostdoc.gdc

@@ -50,8 +50,8 @@ namespace Nest
 				@Raw("IEnumerable<Expression<Func<T, object>>> ") @mm)
 			where T : class
 		{
-			qs._@(mm) = @mm@Raw(".Select(e=>(PropertyPathMarker)e)");
-			qs.Add("@mm", qs._@mm);
+			var _@(mm) = @mm@Raw(".Select(e=>(PropertyPathMarker)e)");
+			qs.AddQueryString("@mm", _@mm);
 			return qs;
 		}
 		</text>
@@ -66,8 +66,8 @@ namespace Nest
 			where T : class
 		{
 			var p = (PropertyPathMarker)@mm;
-			qs._@(mm) = p;
-			qs.Add("@mm", qs._@mm);
+			var _@(mm) = p;
+			qs.AddQueryString("@mm", _@mm);
 			return qs;
 		}
 		</text>

src/CodeGeneration/CodeGeneration.LowLevelClient/Views/Enums.Generated.cshtml

@@ -120,7 +120,7 @@ private string GenerateCall(string call)
 			{
 				var nv = "nv=>nv\r\n";
 				nv += queryStringKeys.Aggregate("",
-					(current, k) => current + string.Format("\t\t\t\t\t.Add(\"{0}\", {1})\r\n", k, this.GetQueryStringValue(k)));
+					(current, k) => current + string.Format("\t\t\t\t\t.AddQueryString(\"{0}\", {1})\r\n", k, this.GetQueryStringValue(k)));
 				nv += "\t\t\t\t";
 				args.Add(nv);
 			}