Skip to content

Commit 7414f14

Browse files
committed
CLR http connection is now super defensive about querying the Http Header collection, GetValues() never throws locally but does on the build server
1 parent c6c1bcd commit 7414f14

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/Elasticsearch.Net/Connection/HttpConnection.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,8 @@ public virtual ElasticsearchResponse<TReturn> Request<TReturn>(RequestData reque
146146
builder.StatusCode = (int)response.StatusCode;
147147
builder.Stream = response.GetResponseStream();
148148

149-
builder.DeprecationWarnings = response.Headers.GetValues("Warning");
149+
if (response.SupportsHeaders && response.Headers.HasKeys() && response.Headers.AllKeys.Contains("Warning"))
150+
builder.DeprecationWarnings = response.Headers.GetValues("Warning");
150151
// https://github.com/elastic/elasticsearch-net/issues/2311
151152
// if stream is null call dispose on response instead.
152153
if (builder.Stream == null || builder.Stream == Stream.Null) response.Dispose();

0 commit comments

Comments
 (0)