Fix #1236: Metric agg response not read to completion when value is null

Author: gmarz

src/Nest/Resolvers/Converters/Aggregations/AggregationConverter.cs

@@ -366,6 +366,7 @@ private IAggregation GetValueMetricOrAggregation(JsonReader reader, JsonSerializ
 			if (scriptedMetric != null)
 				return new ScriptedValueMetric { _Value = scriptedMetric };
 
+			reader.Read();
 			return valueMetric;
 		}
 

src/Tests/Nest.Tests.Integration/Nest.Tests.Integration.csproj

@@ -171,6 +171,7 @@
     <Compile Include="Reproduce\Reproduce1169Tests.cs" />
     <Compile Include="Reproduce\Reproduce1176Tests.cs" />
     <Compile Include="Reproduce\Reproduce1193Tests.cs" />
+    <Compile Include="Reproduce\Reproduce1236Tests.cs" />
     <Compile Include="Reproduce\Reproduce769Tests.cs" />
     <Compile Include="Reproduce\Reproduce945Tests.cs" />
     <Compile Include="Reproduce\Reproduce953Tests.cs" />

src/Tests/Nest.Tests.Integration/Reproduce/Reproduce1236Tests.cs

@@ -0,0 +1,39 @@
+using FluentAssertions;
+using Nest.Tests.MockData.Domain;
+using NUnit.Framework;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace Nest.Tests.Integration.Reproduce
+{
+	[TestFixture]
+	public class Reproduce1236Tests : IntegrationTests
+	{
+		[Test]
+		public void AggregationsMissingWithZeroHits()
+		{
+			var result = this.Client.Search<ElasticsearchProject>(s => s
+				.Query(q => q
+					.Term(p => p.Country, "doesnotexist")
+				)
+				.Aggregations(a => a
+					.Terms("new", t => t
+						.Field(p => p.Name)
+					)
+					.Min("first_occurence", min => min
+						.Field(p => p.StartedOn)
+					)
+					.Max("last_occurence", max => max
+						.Field(p => p.StartedOn)
+					)
+				)
+			);
+
+			result.IsValid.Should().BeTrue();
+			result.Aggregations.Count.Should().Be(3);
+		}
+	}
+}