Do not generate parameterless ctors for Scroll and ClearScroll

Author: gmarz

src/CodeGeneration/CodeGeneration.LowLevelClient/Domain/CsharpMethod.cs

@@ -59,16 +59,20 @@ public static CsharpMethod Clone(CsharpMethod method)
 			};
 		}
 
-		private bool IsPartless => this.Url.Parts == null || !this.Url.Parts.Any(); 
-
 		private string MetricPrefix => this.RequestType.Replace("Request", "");
 		private string ClrParamType(string clrType) => clrType.EndsWith("Metrics", StringComparison.OrdinalIgnoreCase)
 			? this.MetricPrefix + clrType.Replace("Metrics", "Metric") : clrType;
 
 		public IEnumerable<Constructor> RequestConstructors()
 		{
 			var ctors = new List<Constructor>();
+
 			if (IsPartless) return ctors;
+
+			// Do not generate ctors for scroll apis
+			// Scroll ids should always be passed as part of the request body and enforced via manual ctors
+			if (IsScroll) return ctors;
+
 			var m = this.RequestType;
 			foreach (var url in this.Url.Paths)
 			{
@@ -272,6 +276,9 @@ public IEnumerable<FluentRouteSetter> GetFluentRouteSetters()
 			return setters;
 		}
 
+
+		private bool IsPartless => this.Url.Parts == null || !this.Url.Parts.Any();
+		private bool IsScroll => this.Url.Parts.All(p => p.Key == "scroll_id");
 		public bool IndicesAndTypes => AllParts.Count() == 2 && AllParts.All(p => p.Type == "list") && AllParts.All(p => new[] { "index", "type" }.Contains(p.Name));
 		public bool IsDocumentPath => AllParts.Count() == 3 && AllParts.All(p => p.Type != "list") && AllParts.All(p => new[] { "index", "type", "id" }.Contains(p.Name));
 		public IEnumerable<ApiUrlPart> AllParts => (this.Url?.Parts?.Values ?? Enumerable.Empty<ApiUrlPart>()).Where(p => !string.IsNullOrWhiteSpace(p.Name));

src/Nest/_Generated/_Requests.generated.cs

@@ -833,11 +833,7 @@ public partial interface IClearScrollRequest : IRequest<ClearScrollRequestParame
 	public partial class ClearScrollRequest  : RequestBase<ClearScrollRequestParameters>, IClearScrollRequest
 	{
 		protected IClearScrollRequest Self => this;
-			/// <summary>/_search/scroll</summary>
-		public ClearScrollRequest() : base(){}
-		
-
-			///<summary>The URL-encoded request definition</summary>
+				///<summary>The URL-encoded request definition</summary>
 		public string Source { get { return Q<string>("source"); } set { Q("source", value); } }
 
 		///<summary>Comma separated list of filters used to reduce the response returned by Elasticsearch</summary>
@@ -4000,11 +3996,7 @@ public partial interface IScrollRequest : IRequest<ScrollRequestParameters>
 	public partial class ScrollRequest  : RequestBase<ScrollRequestParameters>, IScrollRequest
 	{
 		protected IScrollRequest Self => this;
-			/// <summary>/_search/scroll</summary>
-		public ScrollRequest() : base(){}
-		
-
-			///<summary>The URL-encoded request definition</summary>
+				///<summary>The URL-encoded request definition</summary>
 		public string Source { get { return Q<string>("source"); } set { Q("source", value); } }
 
 		///<summary>Comma separated list of filters used to reduce the response returned by Elasticsearch</summary>