Fix 5.x obsolete warnings (#3217)

This commit fixes the compile warnings from the introduction of ObsoleteAttribute to methods and types that are removed in 6.x.

Author: russcam

src/CodeGeneration/DocGenerator/Buildalyzer/Environment/FrameworkEnvironment.cs

@@ -32,8 +32,6 @@ namespace DocGenerator.Buildalyzer.Environment
 {
 	internal class FrameworkEnvironment : BuildEnvironment
 	{
-		private readonly bool _sdkProject;
-
 		public string ToolsPath { get; }
 		public string ExtensionsPath { get; }
 		public string SDKsPath { get; }

src/Nest/Aggregations/Metric/TopHits/TopHitsAggregation.cs

@@ -124,6 +124,7 @@ public TopHitsAggregationDescriptor<T> Highlight(Func<HighlightDescriptor<T>, IH
 		public TopHitsAggregationDescriptor<T> ScriptFields(Func<ScriptFieldsDescriptor, IPromise<IScriptFields>> scriptFieldsSelector) =>
 			Assign(a => a.ScriptFields = scriptFieldsSelector?.Invoke(new ScriptFieldsDescriptor())?.Value);
 
+		[Obsolete("Removed in NEST 6.x")]
 		public TopHitsAggregationDescriptor<T> FielddataFields(Func<FieldsDescriptor<T>, IPromise<Fields>> fields) =>
 			Assign(a => a.FielddataFields = fields?.Invoke(new FieldsDescriptor<T>())?.Value);
 

src/Nest/Document/Multiple/Bulk/BulkResponseItem/BulkDeleteResponseItem.cs

@@ -10,7 +10,6 @@ public class BulkDeleteResponseItem : BulkResponseItemBase
 		public override string Operation { get; internal set; }
 
 		[JsonProperty("found")]
-
 		[Obsolete("Removed in 6.0.")]
 		public bool Found { get; internal set; }
 	}

src/Nest/Indices/IndexSettings/IndexTemplates/PutIndexTemplate/PutIndexTemplateRequest.cs

@@ -43,6 +43,7 @@ public partial class PutIndexTemplateDescriptor
 
 		public PutIndexTemplateDescriptor Version(int version) => Assign(a => a.Version = version);
 
+		[Obsolete("Removed in NEST 6.x.")]
 		public PutIndexTemplateDescriptor Template(string template)=> Assign(a => a.Template = template);
 
 		public PutIndexTemplateDescriptor Settings(Func<IndexSettingsDescriptor, IPromise<IIndexSettings>> settingsSelector) =>

src/Nest/Mapping/Types/Properties.cs

@@ -51,6 +51,7 @@ public partial interface IPropertiesDescriptor<T, out TReturnType>
 		TReturnType Date(Func<DatePropertyDescriptor<T>, IDateProperty> selector);
 		TReturnType Boolean(Func<BooleanPropertyDescriptor<T>, IBooleanProperty> selector);
 		TReturnType Binary(Func<BinaryPropertyDescriptor<T>, IBinaryProperty> selector);
+		[Obsolete("Removed in Elasticsearch 6.0, please consider using the ingest-attachment plugin.")]
 		TReturnType Attachment(Func<AttachmentPropertyDescriptor<T>, IAttachmentProperty> selector);
 		TReturnType Object<TChild>(Func<ObjectTypeDescriptor<T, TChild>, IObjectProperty> selector)
 			where TChild : class;
@@ -99,6 +100,7 @@ public PropertiesDescriptor() : base(new Properties<T>()) { }
 
 		public PropertiesDescriptor<T> Binary(Func<BinaryPropertyDescriptor<T>, IBinaryProperty> selector) => SetProperty(selector);
 
+		[Obsolete("Removed in Elasticsearch 6.0, please consider using the ingest-attachment plugin.")]
 		public PropertiesDescriptor<T> Attachment(Func<AttachmentPropertyDescriptor<T>, IAttachmentProperty> selector) => SetProperty(selector);
 
 		public PropertiesDescriptor<T> Object<TChild>(Func<ObjectTypeDescriptor<T, TChild>, IObjectProperty> selector)

src/Nest/Mapping/Types/PropertyJsonConverter.cs

@@ -66,7 +66,9 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist
 				case FieldType.GeoShape:
 					return jObject.ToObject<GeoShapeProperty>();
 				case FieldType.Attachment:
+#pragma warning disable 618
 					return jObject.ToObject<AttachmentProperty>();
+#pragma warning restore 618
 				case FieldType.Completion:
 					return jObject.ToObject<CompletionProperty>();
 				case FieldType.TokenCount:

src/Nest/Mapping/Visitor/IMappingVisitor.cs

@@ -19,7 +19,9 @@ public interface IMappingVisitor
 		void Visit(IIpProperty property);
 		void Visit(IGeoPointProperty property);
 		void Visit(IGeoShapeProperty property);
+#pragma warning disable 618
 		void Visit(IAttachmentProperty property);
+#pragma warning restore 618
 		void Visit(INumberProperty property);
 		void Visit(ICompletionProperty property);
 		void Visit(IMurmur3HashProperty property);
@@ -64,7 +66,9 @@ public virtual void Visit(IGeoPointProperty property) { }
 
 		public virtual void Visit(IGeoShapeProperty property) { }
 
+#pragma warning disable 618
 		public virtual void Visit(IAttachmentProperty property) { }
+#pragma warning restore 618
 
 		public virtual void Visit(ICompletionProperty property) { }
 

src/Nest/Mapping/Visitor/IPropertyVisitor.cs

@@ -17,7 +17,9 @@ public interface IPropertyVisitor
 		void Visit(IObjectProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute);
 		void Visit(IGeoPointProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute);
 		void Visit(IGeoShapeProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute);
+#pragma warning disable 618
 		void Visit(IAttachmentProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute);
+#pragma warning restore 618
 		void Visit(ICompletionProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute);
 		void Visit(IIpProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute);
 		void Visit(IMurmur3HashProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute);

src/Nest/Mapping/Visitor/MappingWalker.cs

@@ -149,7 +149,9 @@ public void Accept(IProperties properties)
 						});
 						break;
 					case FieldType.Attachment:
+#pragma warning disable 618
 						this.Visit<IAttachmentProperty>(field, t =>
+#pragma warning restore 618
 						{
 							this._visitor.Visit(t);
 							this.Accept(t.Fields);

src/Nest/Mapping/Visitor/NoopPropertyVisitor.cs

@@ -36,9 +36,11 @@ public virtual void Visit(IIpProperty type, PropertyInfo propertyInfo, Elasticse
 		{
 		}
 
+#pragma warning disable 618
 		public virtual void Visit(IAttachmentProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute)
 		{
 		}
+#pragma warning restore 618
 
 		public virtual void Visit(IGeoPointProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute)
 		{
@@ -100,8 +102,10 @@ public void Visit(IProperty type, PropertyInfo propertyInfo, ElasticsearchProper
 			if (type is IKeywordProperty keywordType)
 				Visit(keywordType, propertyInfo, attribute);
 
+#pragma warning disable 618
 			if (type is IAttachmentProperty attachmentType)
 				Visit(attachmentType, propertyInfo, attribute);
+#pragma warning restore 618
 
 			if (type is IGeoShapeProperty geoShapeType)
 				Visit(geoShapeType, propertyInfo, attribute);