Fix #1026: Get endpoint should allow 404

Author: gmarz

src/CodeGeneration/CodeGeneration.LowLevelClient/Overrides/Allow404/ApiEndpointsThatAllow404.cs

@@ -17,7 +17,8 @@ public static class ApiEndpointsThatAllow404
 			"AliasExists",
 			"TemplateExists",
 			"TypeExists",
-			"Exists"
+			"Exists",
+			"Get"
 		};
 	}
 }

src/Elasticsearch.Net/ElasticsearchClient.Generated.cs

@@ -8722,9 +8722,15 @@ public ElasticsearchResponse<T> Get<T>(string index, string type, string id, Fun
 			var url = "{0}/{1}/{2}".F(Encoded(index), Encoded(type), Encoded(id));
 			IRequestParameters requestParams = null;
 
-			if (requestParameters != null)
-			{
-				requestParams = requestParameters(new GetRequestParameters());
+			requestParameters = requestParameters ?? (s => s);
+			var passIn = new GetRequestParameters();
+			requestParams = requestParameters(passIn);
+			if (requestParams.RequestConfiguration == null) 
+					requestParams.RequestConfiguration = new RequestConfiguration { AllowedStatusCodes = new [] { 404 } };
+			else {
+									 if (requestParams.RequestConfiguration.AllowedStatusCodes == null) {
+						requestParams.RequestConfiguration.AllowedStatusCodes =  new [] { 404 };
+					}
 			}
 
 
@@ -8760,9 +8766,15 @@ public Task<ElasticsearchResponse<T>> GetAsync<T>(string index, string type, str
 			var url = "{0}/{1}/{2}".F(Encoded(index), Encoded(type), Encoded(id));
 			IRequestParameters requestParams = null;
 
-			if (requestParameters != null)
-			{
-				requestParams = requestParameters(new GetRequestParameters());
+			requestParameters = requestParameters ?? (s => s);
+			var passIn = new GetRequestParameters();
+			requestParams = requestParameters(passIn);
+			if (requestParams.RequestConfiguration == null) 
+					requestParams.RequestConfiguration = new RequestConfiguration { AllowedStatusCodes = new [] { 404 } };
+			else {
+									 if (requestParams.RequestConfiguration.AllowedStatusCodes == null) {
+						requestParams.RequestConfiguration.AllowedStatusCodes =  new [] { 404 };
+					}
 			}
 
 
@@ -8800,9 +8812,15 @@ public ElasticsearchResponse<DynamicDictionary> Get(string index, string type, s
 			var url = "{0}/{1}/{2}".F(Encoded(index), Encoded(type), Encoded(id));
 			IRequestParameters requestParams = null;
 
-			if (requestParameters != null)
-			{
-				requestParams = requestParameters(new GetRequestParameters());
+			requestParameters = requestParameters ?? (s => s);
+			var passIn = new GetRequestParameters();
+			requestParams = requestParameters(passIn);
+			if (requestParams.RequestConfiguration == null) 
+					requestParams.RequestConfiguration = new RequestConfiguration { AllowedStatusCodes = new [] { 404 } };
+			else {
+									 if (requestParams.RequestConfiguration.AllowedStatusCodes == null) {
+						requestParams.RequestConfiguration.AllowedStatusCodes =  new [] { 404 };
+					}
 			}
 
 
@@ -8840,9 +8858,15 @@ public Task<ElasticsearchResponse<DynamicDictionary>> GetAsync(string index, str
 			var url = "{0}/{1}/{2}".F(Encoded(index), Encoded(type), Encoded(id));
 			IRequestParameters requestParams = null;
 
-			if (requestParameters != null)
-			{
-				requestParams = requestParameters(new GetRequestParameters());
+			requestParameters = requestParameters ?? (s => s);
+			var passIn = new GetRequestParameters();
+			requestParams = requestParameters(passIn);
+			if (requestParams.RequestConfiguration == null) 
+					requestParams.RequestConfiguration = new RequestConfiguration { AllowedStatusCodes = new [] { 404 } };
+			else {
+									 if (requestParams.RequestConfiguration.AllowedStatusCodes == null) {
+						requestParams.RequestConfiguration.AllowedStatusCodes =  new [] { 404 };
+					}
 			}
 
 

src/Elasticsearch.Net/IElasticsearchClient.Generated.cs

@@ -20079,7 +20079,7 @@ public interface IElasticsearchClient
 		///</returns>
 
 		Task<ElasticsearchResponse<DynamicDictionary>> UpdateAsync(string index, string type, string id, object body, Func<UpdateRequestParameters, UpdateRequestParameters> requestParameters = null);
-
+		
 		/// <summary>
 		/// Perform any request you want over the configured IConnection synchronously while taking advantage of the cluster failover.
 		/// </summary>
@@ -20100,6 +20100,6 @@ public interface IElasticsearchClient
 		/// <param name="data">The body of the request, string and byte[] are posted as is other types will be serialized to JSON</param>
 		/// <param name="requestParameters">Optionally configure request specific timeouts, headers</param>
 		/// <returns>A task of ElasticsearchResponse of T where T represents the JSON response body</returns>
-		Task<ElasticsearchResponse<T>> DoRequestAsync<T>(string method, string path, object data = null, IRequestParameters requestParameters = null);
+		Task<ElasticsearchResponse<T>> DoRequestAsync<T>(string method, string path, object data = null, IRequestParameters requestParameters = null);		
 	}
 }

src/Tests/Nest.Tests.Integration/Core/Get/GetTests.cs

@@ -46,5 +46,13 @@ public void GetWithFieldsDeep()
 			Assert.IsNotEmpty(list);
 
 		}
+
+		[Test]
+		public void GetDocumentThatDoesntExist()
+		{
+			var result = this.Client.Get<ElasticsearchProject>("this-doc-id-doesnt-exist");
+			Assert.IsTrue(result.IsValid);
+			Assert.IsFalse(result.Found);
+		}
 	}
 }