Favor long on id parameters fix #570

Mpdreamz · Mpdreamz · commit 5260861d4a7e · 2014-04-08T19:25:02.000+02:00
diff --git a/src/Nest/ConvenienceExtensions/DeleteExtensions.cs b/src/Nest/ConvenienceExtensions/DeleteExtensions.cs
@@ -17,7 +17,7 @@ public static class DeleteExtensions
 		/// <param name="client"></param>
 		/// <param name="id">The id as int of the document you want to delete</param>
 		/// <param name="selector">An optional descriptor to further describe the delete operation</param>
-		public static IDeleteResponse Delete<T>(this IElasticClient client, int id, Func<DeleteDescriptor<T>, DeleteDescriptor<T>> selector = null) where T : class
+		public static IDeleteResponse Delete<T>(this IElasticClient client, long id, Func<DeleteDescriptor<T>, DeleteDescriptor<T>> selector = null) where T : class
 		{
 			selector = selector ?? (s => s);
 			return client.Delete<T>(s => selector(s.Id(id)));
@@ -45,7 +45,7 @@ public static IDeleteResponse Delete<T>(this IElasticClient client, string id, F
 		/// <param name="client"></param>
 		/// <param name="id">The id as int of the document you want to delete</param>
 		/// <param name="selector">An optional descriptor to further describe the delete operation</param>
-		public static Task<IDeleteResponse> DeleteAsync<T>(this IElasticClient client, int id, Func<DeleteDescriptor<T>, DeleteDescriptor<T>> selector = null) where T : class
+		public static Task<IDeleteResponse> DeleteAsync<T>(this IElasticClient client, long id, Func<DeleteDescriptor<T>, DeleteDescriptor<T>> selector = null) where T : class
 		{
 			selector = selector ?? (s => s);
 			return client.DeleteAsync<T>(s => selector(s.Id(id)));
diff --git a/src/Nest/ConvenienceExtensions/GetExtensions.cs b/src/Nest/ConvenienceExtensions/GetExtensions.cs
@@ -28,10 +28,10 @@ public static IGetResponse<T> Get<T>(this IElasticClient client, string id, stri
 		/// </summary>
 		/// <typeparam name="T">The type used to infer the default index and typename</typeparam>
 		/// <param name="client"></param>
-		/// <param name="id">The int id of the document we want the fetch</param>
+		/// <param name="id">The long id of the document we want the fetch</param>
 		/// <param name="index">Optionally override the inferred index name for T</param>
 		/// <param name="type">Optionally override the inferred typename for T</param>
-		public static IGetResponse<T> Get<T>(this IElasticClient client, int id, string index = null, string type = null)
+		public static IGetResponse<T> Get<T>(this IElasticClient client, long id, string index = null, string type = null)
 			where T : class
 		{
 			return client.Get<T>(s => s.Id(id).Index(index).Type(type));
@@ -58,10 +58,10 @@ public static Task<IGetResponse<T>> GetAsync<T>(this IElasticClient client, stri
 		/// </summary>
 		/// <typeparam name="T">The type used to infer the default index and typename</typeparam>
 		/// <param name="client"></param>
-		/// <param name="id">The int id of the document we want the fetch</param>
+		/// <param name="id">The long id of the document we want the fetch</param>
 		/// <param name="index">Optionally override the inferred index name for T</param>
 		/// <param name="type">Optionally override the inferred typename for T</param>
-		public static Task<IGetResponse<T>> GetAsync<T>(this IElasticClient client, int id, string index = null, string type = null)
+		public static Task<IGetResponse<T>> GetAsync<T>(this IElasticClient client, long id, string index = null, string type = null)
 			where T : class
 		{
 			return client.GetAsync<T>(s => s.Id(id).Index(index).Type(type));
diff --git a/src/Nest/ConvenienceExtensions/GetManyExtensions.cs b/src/Nest/ConvenienceExtensions/GetManyExtensions.cs
@@ -39,7 +39,7 @@ public static IEnumerable<IMultiGetHit<T>> GetMany<T>(this IElasticClient client
 		/// <param name="ids">IEnumerable of ids as ints for the documents to fetch</param>
 		/// <param name="index">Optionally override the default inferred index name for T</param>
 		/// <param name="type">Optionally overiide the default inferred typename for T</param>
-		public static IEnumerable<IMultiGetHit<T>> GetMany<T>(this IElasticClient client, IEnumerable<int> ids, string index = null, string type = null)
+		public static IEnumerable<IMultiGetHit<T>> GetMany<T>(this IElasticClient client, IEnumerable<long> ids, string index = null, string type = null)
 			where T : class
 		{
 			return client.GetMany<T>(ids.Select(i => i.ToString(CultureInfo.InvariantCulture)), index, type);
@@ -74,7 +74,7 @@ public static Task<IEnumerable<IMultiGetHit<T>>> GetManyAsync<T>(this IElasticCl
 		/// <param name="ids">IEnumerable of ids as ints for the documents to fetch</param>
 		/// <param name="index">Optionally override the default inferred index name for T</param>
 		/// <param name="type">Optionally overiide the default inferred typename for T</param>
-		public static Task<IEnumerable<IMultiGetHit<T>>> GetManyAsync<T>(this IElasticClient client, IEnumerable<int> ids, string index = null, string type = null)
+		public static Task<IEnumerable<IMultiGetHit<T>>> GetManyAsync<T>(this IElasticClient client, IEnumerable<long> ids, string index = null, string type = null)
 			where T : class
 		{
 			return client.GetManyAsync<T>(ids.Select(i => i.ToString(CultureInfo.InvariantCulture)), index, type);
diff --git a/src/Nest/ConvenienceExtensions/SourceExtensions.cs b/src/Nest/ConvenienceExtensions/SourceExtensions.cs
@@ -4,7 +4,7 @@ namespace Nest
 {
 	/// <summary>
 	/// Provides convenience extension methods that make it easier to get the _source for 
-	/// a given document given a string or int id.
+	/// a given document given a string or long id.
 	/// </summary>
 	public static class SourceExtensions
 	{
@@ -34,7 +34,7 @@ public static T Source<T>(this IElasticClient client, string id, string index =
 		/// <param name="id">id as int of the document we want the _source from</param>
 		/// <param name="index">Optionally override the inferred index name for T</param>
 		/// <param name="type">Optionally override the inferred type name for T</param>
-		public static T Source<T>(this IElasticClient client, int id, string index = null, string type = null)
+		public static T Source<T>(this IElasticClient client, long id, string index = null, string type = null)
 			where T : class
 		{
 			return client.Source<T>(s => s.Id(id).Index(index).Type(type));
@@ -66,7 +66,7 @@ public static Task<T> SourceAsync<T>(this IElasticClient client, string id, stri
 		/// <param name="id">id as int of the document we want the _source from</param>
 		/// <param name="index">Optionally override the inferred index name for T</param>
 		/// <param name="type">Optionally override the inferred type name for T</param>
-		public static Task<T> SourceAsync<T>(this IElasticClient client, int id, string index = null, string type = null)
+		public static Task<T> SourceAsync<T>(this IElasticClient client, long id, string index = null, string type = null)
 			where T : class
 		{
 			return client.SourceAsync<T>(s => s.Id(id).Index(index).Type(type));
diff --git a/src/Nest/ConvenienceExtensions/SourceManyExtensions.cs b/src/Nest/ConvenienceExtensions/SourceManyExtensions.cs
@@ -45,7 +45,7 @@ public static IEnumerable<T> SourceMany<T>(this IElasticClient client, IEnumerab
 		/// <param name="ids">A list of ids as int</param>
 		/// <param name="index">Optionally override the default inferred indexname for T</param>
 		/// <param name="type">Optionally override the default inferred indexname for T</param>
-		public static IEnumerable<T> SourceMany<T>(this IElasticClient client, IEnumerable<int> ids, string index = null, string type = null)
+		public static IEnumerable<T> SourceMany<T>(this IElasticClient client, IEnumerable<long> ids, string index = null, string type = null)
 			where T : class
 		{
 			return client.SourceMany<T>(ids.Select(i => i.ToString(CultureInfo.InvariantCulture)), index, type);
@@ -86,7 +86,7 @@ public static Task<IEnumerable<T>> SourceManyAsync<T>(this IElasticClient client
 		/// <param name="ids">A list of ids as int</param>
 		/// <param name="index">Optionally override the default inferred indexname for T</param>
 		/// <param name="type">Optionally override the default inferred indexname for T</param>
-		public static Task<IEnumerable<T>> SourceManyAsync<T>(this IElasticClient client, IEnumerable<int> ids, string index = null, string type = null)
+		public static Task<IEnumerable<T>> SourceManyAsync<T>(this IElasticClient client, IEnumerable<long> ids, string index = null, string type = null)
 			where T : class
 		{
 			return client.SourceManyAsync<T>(ids.Select(i => i.ToString(CultureInfo.InvariantCulture)), index, type);
diff --git a/src/Nest/DSL/BulkCreateDescriptor.cs b/src/Nest/DSL/BulkCreateDescriptor.cs
@@ -56,7 +56,7 @@ public BulkCreateDescriptor<T> Type(Type type)
 		/// <summary>
 		/// Manually set the id for the newly created object
 		/// </summary>
-		public BulkCreateDescriptor<T> Id(int id)
+		public BulkCreateDescriptor<T> Id(long id)
 		{
 			return this.Id(id.ToString(CultureInfo.InvariantCulture));
 		}
diff --git a/src/Nest/DSL/BulkDeleteDescriptor.cs b/src/Nest/DSL/BulkDeleteDescriptor.cs
@@ -56,7 +56,7 @@ public BulkDeleteDescriptor<T> Type(Type type)
 		/// <summary>
 		/// Manually set the id for the newly created object
 		/// </summary>
-		public BulkDeleteDescriptor<T> Id(int id)
+		public BulkDeleteDescriptor<T> Id(long id)
 		{
 			return this.Id(id.ToString(CultureInfo.InvariantCulture));
 		}
diff --git a/src/Nest/DSL/BulkDescriptor.cs b/src/Nest/DSL/BulkDescriptor.cs
@@ -107,7 +107,7 @@ public BulkDescriptor DeleteMany<T>(IEnumerable<string> ids, Func<BulkDeleteDesc
 		/// </summary>
 		/// <param name="ids">Enumerable of int ids to delete</param>
 		/// <param name="bulkDeleteSelector">A func called on each ids to describe the individual delete operation</param>
-		public BulkDescriptor DeleteMany<T>(IEnumerable<int> ids, Func<BulkDeleteDescriptor<T>, string, BulkDeleteDescriptor<T>> bulkDeleteSelector = null) where T : class
+		public BulkDescriptor DeleteMany<T>(IEnumerable<long> ids, Func<BulkDeleteDescriptor<T>, string, BulkDeleteDescriptor<T>> bulkDeleteSelector = null) where T : class
 		{
 			return this.DeleteMany(ids.Select(i=>i.ToString(CultureInfo.InvariantCulture)), bulkDeleteSelector);
 		}
diff --git a/src/Nest/DSL/BulkIndexDescriptor.cs b/src/Nest/DSL/BulkIndexDescriptor.cs
@@ -56,7 +56,7 @@ public BulkIndexDescriptor<T> Type(Type type)
 		/// <summary>
 		/// Manually set the id for the newly created object
 		/// </summary>
-		public BulkIndexDescriptor<T> Id(int id)
+		public BulkIndexDescriptor<T> Id(long id)
 		{
 			return this.Id(id.ToString(CultureInfo.InvariantCulture));
 		}
diff --git a/src/Nest/DSL/BulkUpdateDescriptor.cs b/src/Nest/DSL/BulkUpdateDescriptor.cs
@@ -75,7 +75,7 @@ public BulkUpdateDescriptor<T, K> Type(Type type)
 		/// <summary>
 		/// Manually set the id for the newly created object
 		/// </summary>
-		public BulkUpdateDescriptor<T, K> Id(int id)
+		public BulkUpdateDescriptor<T, K> Id(long id)
 		{
 			return this.Id(id.ToString(CultureInfo.InvariantCulture));
 		}
diff --git a/src/Nest/DSL/MultiGetDescriptor.cs b/src/Nest/DSL/MultiGetDescriptor.cs
@@ -53,7 +53,7 @@ public MultiGetDescriptor Get<K>(Func<SimpleGetDescriptor<K>, SimpleGetDescripto
 
 		}
 
-		public MultiGetDescriptor GetMany<K>(IEnumerable<int> ids, Func<SimpleGetDescriptor<K>, int, SimpleGetDescriptor<K>> getSelector=null) where K : class
+		public MultiGetDescriptor GetMany<K>(IEnumerable<long> ids, Func<SimpleGetDescriptor<K>, long, SimpleGetDescriptor<K>> getSelector=null) where K : class
 		{
 			getSelector = getSelector ?? ((sg, s) => sg);
 			foreach (var sg in ids.Select(id => getSelector(new SimpleGetDescriptor<K>().Id(id), id)))
diff --git a/src/Nest/DSL/Paths/DocumentPathDescriptor.cs b/src/Nest/DSL/Paths/DocumentPathDescriptor.cs
@@ -62,7 +62,7 @@ public P Type<TAlternative>() where TAlternative : class
 			this._Type = typeof(TAlternative);
 			return (P)this;
 		}
-		public P Id(int id)
+		public P Id(long id)
 		{
 			return this.Id(id.ToString());
 		}
diff --git a/src/Nest/DSL/Query/ExternalFieldDeclarationDescriptor.cs b/src/Nest/DSL/Query/ExternalFieldDeclarationDescriptor.cs
@@ -36,7 +36,7 @@ public ExternalFieldDeclarationDescriptor<T> Id(string id)
 			this._Id = id;
 			return this;
 		}
-		public ExternalFieldDeclarationDescriptor<T> Id(int id)
+		public ExternalFieldDeclarationDescriptor<T> Id(long id)
 		{
 			this._Id = id.ToString(CultureInfo.InvariantCulture);
 			return this;
diff --git a/src/Nest/DSL/SimpleGetDescriptor.cs b/src/Nest/DSL/SimpleGetDescriptor.cs
@@ -46,7 +46,7 @@ public SimpleGetDescriptor<T> Type(Type type)
 			return this;
 		}
 
-		public SimpleGetDescriptor<T> Id(int id)
+		public SimpleGetDescriptor<T> Id(long id)
 		{
 			return this.Id(id.ToString(CultureInfo.InvariantCulture));
 		}
diff --git a/src/Nest/Domain/Responses/MultiGetResponse.cs b/src/Nest/Domain/Responses/MultiGetResponse.cs
@@ -10,15 +10,15 @@ public interface IMultiGetResponse : IResponse
 	{
 		IEnumerable<IMultiGetHit<object>> Documents { get; }
 		MultiGetHit<T> Get<T>(string id) where T : class;
-		MultiGetHit<T> Get<T>(int id) where T : class;
+		MultiGetHit<T> Get<T>(long id) where T : class;
 		T Source<T>(string id) where T : class;
-		T Source<T>(int id) where T : class;
+		T Source<T>(long id) where T : class;
 		IFieldSelection<T> GetFieldSelection<T>(string id) where T : class;
-		IFieldSelection<T> GetFieldSelection<T>(int id) where T : class;
+		IFieldSelection<T> GetFieldSelection<T>(long id) where T : class;
 		IEnumerable<T> SourceMany<T>(IEnumerable<string> ids) where T : class;
-		IEnumerable<T> SourceMany<T>(IEnumerable<int> ids) where T : class;
+		IEnumerable<T> SourceMany<T>(IEnumerable<long> ids) where T : class;
 		IEnumerable<IMultiGetHit<T>> GetMany<T>(IEnumerable<string> ids) where T : class;
-		IEnumerable<IMultiGetHit<T>> GetMany<T>(IEnumerable<int> ids) where T : class;
+		IEnumerable<IMultiGetHit<T>> GetMany<T>(IEnumerable<long> ids) where T : class;
 	}
 
 	[JsonObject]
@@ -38,7 +38,7 @@ public MultiGetHit<T> Get<T>(string id) where T : class
 		{
 			return this.Documents.OfType<MultiGetHit<T>>().FirstOrDefault(m => m.Id == id);
 		}
-		public MultiGetHit<T> Get<T>(int id) where T : class
+		public MultiGetHit<T> Get<T>(long id) where T : class
 		{
 			return this.Get<T>(id.ToString(CultureInfo.InvariantCulture));
 		}
@@ -49,7 +49,7 @@ public T Source<T>(string id) where T : class
 				return null;
 			return multiHit.Source;
 		}
-		public T Source<T>(int id) where T : class
+		public T Source<T>(long id) where T : class
 		{
 			return this.Source<T>(id.ToString(CultureInfo.InvariantCulture));
 		}
@@ -61,7 +61,7 @@ join id in ids on d.Id equals id
 				where d.Found
 				select d.Source;
 		}
-		public IEnumerable<T> SourceMany<T>(IEnumerable<int> ids) where T : class
+		public IEnumerable<T> SourceMany<T>(IEnumerable<long> ids) where T : class
 		{
 			return this.SourceMany<T>(ids.Select(i=>i.ToString(CultureInfo.InvariantCulture)));
 		}
@@ -73,7 +73,7 @@ public IEnumerable<IMultiGetHit<T>> GetMany<T>(IEnumerable<string> ids) where T
 				join id in ids on d.Id equals id
 				select d;
 		}
-		public IEnumerable<IMultiGetHit<T>> GetMany<T>(IEnumerable<int> ids) where T : class
+		public IEnumerable<IMultiGetHit<T>> GetMany<T>(IEnumerable<long> ids) where T : class
 		{
 			return this.GetMany<T>(ids.Select(i=>i.ToString(CultureInfo.InvariantCulture)));
 		}
@@ -84,7 +84,7 @@ public IFieldSelection<T> GetFieldSelection<T>(string id) where T : class
 				return null;
 			return multiHit.FieldSelection;
 		}
-		public IFieldSelection<T> GetFieldSelection<T>(int id) where T : class
+		public IFieldSelection<T> GetFieldSelection<T>(long id) where T : class
 		{
 			return this.GetFieldSelection<T>(id.ToString(CultureInfo.InvariantCulture));
 		}
diff --git a/src/Nest/Domain/Stats/NodeInfo.cs b/src/Nest/Domain/Stats/NodeInfo.cs
@@ -103,7 +103,7 @@ public class NodeInfoProcess
 		[JsonProperty(PropertyName = "refresh_interval")]
 		public int RefreshInterval { get; internal set; }
 		[JsonProperty(PropertyName = "id")]
-		public int Id { get; internal set; }
+		public long Id { get; internal set; }
 		[JsonProperty(PropertyName = "max_file_descriptors")]
 		public int MaxFileDescriptors { get; internal set; }
 	}
diff --git a/src/Tests/Nest.Tests.Integration/Core/Get/GetTests.cs b/src/Tests/Nest.Tests.Integration/Core/Get/GetTests.cs
@@ -21,7 +21,7 @@ public void SimpleGet()
 		[Test]
 		public void SimpleMultiGet()
 		{
-			var elasticSearchProjects = this._client.SourceMany<ElasticsearchProject>(new [] { 4, 5 });
+			var elasticSearchProjects = this._client.SourceMany<ElasticsearchProject>(new long[] { 4, 5 });
 
 			Assert.NotNull(elasticSearchProjects);
 			Assert.IsNotEmpty(elasticSearchProjects);
diff --git a/src/Tests/Nest.Tests.Integration/Core/Suggest/SuggestTests.cs b/src/Tests/Nest.Tests.Integration/Core/Suggest/SuggestTests.cs
@@ -17,6 +17,7 @@ public void TestSuggest()
 			var wrongCountry = country + "x";
 
 			var suggestResults = _client.Suggest<ElasticsearchProject>(s => s
+				.Index<ElasticsearchProject>()
 				.Term("mySuggest", m => m
 					.SuggestMode(SuggestMode.Always)
 					.Text(wrongCountry)
diff --git a/src/Tests/Nest.Tests.Unit/Core/Map/Properties/PropertiesTests.cs b/src/Tests/Nest.Tests.Unit/Core/Map/Properties/PropertiesTests.cs
@@ -201,20 +201,20 @@ public void IPProperty()
 			this.JsonEquals(result.ConnectionStatus.Request, MethodInfo.GetCurrentMethod());
 		}
 
-	    public class Foo
-	    {
-	        public int Id { get; set; }
-            [ElasticProperty(AddSortField = true, SortAnalyzer = "simple")]
-	        public string Name { get; set; }
-	    }
+		public class Foo
+		{
+			public int Id { get; set; }
+			[ElasticProperty(AddSortField = true, SortAnalyzer = "simple")]
+			public string Name { get; set; }
+		}
 
-	    [Test]
-	    public void SortAnalyzeryReadFromAttribute()
-	    {
-            var result = _client.Map<Foo>(m => m.MapFromAttributes());
-            this.JsonEquals(result.ConnectionStatus.Request, MethodInfo.GetCurrentMethod());
-	        
-	    }
+		[Test]
+		public void SortAnalyzeryReadFromAttribute()
+		{
+			var result = _client.Map<Foo>(m => m.MapFromAttributes());
+			this.JsonEquals(result.ConnectionStatus.Request, MethodInfo.GetCurrentMethod());
+
+		}
 
 		[Test]
 		public void GeoPointProperty()
diff --git a/src/Tests/Nest.Tests.Unit/Internals/Inferno/IdLookupTests.cs b/src/Tests/Nest.Tests.Unit/Internals/Inferno/IdLookupTests.cs
@@ -1,4 +1,5 @@
 ﻿using System;
+using System.Globalization;
 using NUnit.Framework;
 using Nest.Resolvers;
 
@@ -12,6 +13,7 @@ internal class AlternateIdClass
 		{
 			public Guid Guid { get; set; }
 		}
+		internal class LongIdClass { public long Id { get; set; } }
 		internal class DoubleIdClass { public double Id { get; set; } }
 		internal class IntIdClass { public int Id { get; set; } }
 		internal class DecimalIdClass { public decimal Id { get; set; } }
@@ -42,28 +44,36 @@ public void TestIntLookup()
 		{
 			var expected = 12;
 			var id = new IdResolver().GetIdFor(new IntIdClass { Id = expected });
-			StringAssert.AreEqualIgnoringCase(expected.ToString(), id);
+			StringAssert.AreEqualIgnoringCase(expected.ToString(CultureInfo.InvariantCulture), id);
 		}
 		[Test]
 		public void TestDecimalLookup()
 		{
 			var expected = 12m;
 			var id = new IdResolver().GetIdFor(new DecimalIdClass { Id = expected });
-			StringAssert.AreEqualIgnoringCase(expected.ToString(), id);
+			StringAssert.AreEqualIgnoringCase(expected.ToString(CultureInfo.InvariantCulture), id);
 		}
 		[Test]
 		public void TestFloatLookup()
 		{
 			var expected = 12f;
 			var id = new IdResolver().GetIdFor(new FloatIdClass { Id = expected });
-			StringAssert.AreEqualIgnoringCase(expected.ToString(), id);
+			StringAssert.AreEqualIgnoringCase(expected.ToString(CultureInfo.InvariantCulture), id);
 		}
+		[Test]
+		public void TestLongLookup()
+		{
+			var expected = long.MaxValue;
+			var id = new IdResolver().GetIdFor(new LongIdClass { Id = expected });
+			StringAssert.AreEqualIgnoringCase(expected.ToString(CultureInfo.InvariantCulture), id);
+		}
+		
 		[Test]
 		public void TestDoubleLookup()
 		{
 			var expected = 12d;
 			var id = new IdResolver().GetIdFor(new DoubleIdClass { Id = expected });
-			StringAssert.AreEqualIgnoringCase(expected.ToString(), id);
+			StringAssert.AreEqualIgnoringCase(expected.ToString(CultureInfo.InvariantCulture), id);
 		}
 		[Test]
 		public void TestCustomLookup()

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ public BulkCreateDescriptor<T> Type(Type type)`
`56`	`56`	`/// <summary>`
`57`	`57`	`/// Manually set the id for the newly created object`
`58`	`58`	`/// </summary>`
`59`		`- public BulkCreateDescriptor<T> Id(int id)`
	`59`	`+ public BulkCreateDescriptor<T> Id(long id)`
`60`	`60`	`{`
`61`	`61`	`return this.Id(id.ToString(CultureInfo.InvariantCulture));`
`62`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ public BulkDeleteDescriptor<T> Type(Type type)`
`56`	`56`	`/// <summary>`
`57`	`57`	`/// Manually set the id for the newly created object`
`58`	`58`	`/// </summary>`
`59`		`- public BulkDeleteDescriptor<T> Id(int id)`
	`59`	`+ public BulkDeleteDescriptor<T> Id(long id)`
`60`	`60`	`{`
`61`	`61`	`return this.Id(id.ToString(CultureInfo.InvariantCulture));`
`62`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ public BulkDescriptor DeleteMany<T>(IEnumerable<string> ids, Func<BulkDeleteDesc`
`107`	`107`	`/// </summary>`
`108`	`108`	`/// <param name="ids">Enumerable of int ids to delete</param>`
`109`	`109`	`/// <param name="bulkDeleteSelector">A func called on each ids to describe the individual delete operation</param>`
`110`		`- public BulkDescriptor DeleteMany<T>(IEnumerable<int> ids, Func<BulkDeleteDescriptor<T>, string, BulkDeleteDescriptor<T>> bulkDeleteSelector = null) where T : class`
	`110`	`+ public BulkDescriptor DeleteMany<T>(IEnumerable<long> ids, Func<BulkDeleteDescriptor<T>, string, BulkDeleteDescriptor<T>> bulkDeleteSelector = null) where T : class`
`111`	`111`	`{`
`112`	`112`	`return this.DeleteMany(ids.Select(i=>i.ToString(CultureInfo.InvariantCulture)), bulkDeleteSelector);`
`113`	`113`	`}`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ public BulkIndexDescriptor<T> Type(Type type)`
`56`	`56`	`/// <summary>`
`57`	`57`	`/// Manually set the id for the newly created object`
`58`	`58`	`/// </summary>`
`59`		`- public BulkIndexDescriptor<T> Id(int id)`
	`59`	`+ public BulkIndexDescriptor<T> Id(long id)`
`60`	`60`	`{`
`61`	`61`	`return this.Id(id.ToString(CultureInfo.InvariantCulture));`
`62`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ public BulkUpdateDescriptor<T, K> Type(Type type)`
`75`	`75`	`/// <summary>`
`76`	`76`	`/// Manually set the id for the newly created object`
`77`	`77`	`/// </summary>`
`78`		`- public BulkUpdateDescriptor<T, K> Id(int id)`
	`78`	`+ public BulkUpdateDescriptor<T, K> Id(long id)`
`79`	`79`	`{`
`80`	`80`	`return this.Id(id.ToString(CultureInfo.InvariantCulture));`
`81`	`81`	`}`