Fix tests

Bulk fluent API now must take a lambda
Fix string mapping tests
Fix build warnings related to unused fields

Author: russcam

src/Nest/Document/Multiple/Bulk/ElasticClient-Bulk.cs

@@ -15,13 +15,13 @@ public partial interface IElasticClient
 		IBulkResponse Bulk(IBulkRequest request);
 
 		/// <inheritdoc/>
-		IBulkResponse Bulk(Func<BulkDescriptor, IBulkRequest> selector = null);
+		IBulkResponse Bulk(Func<BulkDescriptor, IBulkRequest> selector);
 
 		/// <inheritdoc/>
 		Task<IBulkResponse> BulkAsync(IBulkRequest request);
 
 		/// <inheritdoc/>
-		Task<IBulkResponse> BulkAsync(Func<BulkDescriptor, IBulkRequest> selector = null);
+		Task<IBulkResponse> BulkAsync(Func<BulkDescriptor, IBulkRequest> selector);
 
 	}
 

src/Tests/Document/Multiple/Bulk/BulkUrlTests.cs

@@ -11,9 +11,9 @@ public class BulkUrlTests : IUrlTests
 		[U] public async Task Urls()
 		{
 			await POST("/_bulk")
-				.Fluent(c => c.Bulk())
+				.Fluent(c => c.Bulk(s => s))
 				.Request(c => c.Bulk(new BulkRequest()))
-				.FluentAsync(c => c.BulkAsync())
+				.FluentAsync(c => c.BulkAsync(s => s))
 				.RequestAsync(c => c.BulkAsync(new BulkRequest()))
 				;
 

src/Tests/Document/Multiple/Reindex/ReindexApiTests.cs

@@ -27,9 +27,9 @@ public override void Boostrap()
 	[Collection(IntegrationContext.Reindex)]
 	public class ReindexApiTests : SerializationTestBase
 	{
-		private readonly IObservable<IReindexResponse<ILazyDocument>> _reindexManyTypesResult;
-		private readonly IObservable<IReindexResponse<Project>> _reindexSingleTypeResult;
-		private readonly IElasticClient _client;
+		//private readonly IObservable<IReindexResponse<ILazyDocument>> _reindexManyTypesResult;
+		//private readonly IObservable<IReindexResponse<Project>> _reindexSingleTypeResult;
+		//private readonly IElasticClient _client;
 
 		public ReindexApiTests(ReindexCluster cluster, EndpointUsage usage)
 		{

src/Tests/Mapping/Types/Core/String/StringMappingTests.cs

@@ -14,10 +14,7 @@ public class StringTest
 			Index = FieldIndexOption.NotAnalyzed,
 			IndexOptions = IndexOptions.Offsets,
 			NullValue = "na",
-#pragma warning disable 618
-			// Purposely setting this obsolete property to ensure it serializes as position_increment_gap
 			PositionIncrementGap = 5,
-#pragma warning restore 618
 			SearchAnalyzer = "mysearchanalyzer",
 			Similarity = SimilarityOption.BM25,
 			Store = true,
@@ -61,10 +58,15 @@ public class StringMappingTests : TypeMappingTestBase<StringTest>
 				{
 					type = "string"
 				},
-				inferred = new {
+				inferred = new
+				{
 					type = "text",
-					fields = new {
-						keyword = new { type = "keyword" }
+					fields = new
+					{
+						keyword = new
+						{
+							type = "keyword"
+						}
 					}
 				},
 				@char = new
@@ -98,13 +100,18 @@ public class StringMappingTests : TypeMappingTestBase<StringTest>
 			.String(s => s
 				.Name(o => o.Minimal)
 			)
-			.String(s => s
+			.Text(s => s
 				.Name(o => o.Inferred)
+				.Fields(f => f
+					.Keyword(k => k
+						.Name("keyword")
+					)
+				)
 			)
-			.String(s => s
+			.Keyword(s => s
 				.Name(o => o.Char)
 			)
-			.String(s => s
+			.Keyword(s => s
 				.Name(o => o.Guid)
 			);