showcase index type overrides and add additional url test for it on .Get() for #1714

Author: Mpdreamz

src/Elasticsearch.Net/Auditing/Audit.cs

@@ -11,16 +11,16 @@ public class Audit
 		public string Path { get; internal set; }
 		public Exception Exception { get; internal set; }
 
-		public Audit(AuditEvent type, DateTime occured)
+		public Audit(AuditEvent type, DateTime started)
 		{
 			this.Event = type;
-			this.Started = occured;
+			this.Started = started;
 		}
 
 		public override string ToString()
 		{
 			var took = Started - Ended;
-			return $"Node: {Node?.Uri}, Event: {Event.GetStringValue()} NodeAlive: {Node?.IsAlive}, Took: {took.ToString()}";
+			return $"Node: {Node?.Uri}, Event: {Event.GetStringValue()} NodeAlive: {Node?.IsAlive}, Took: {took}";
 		}
 	}
 }

src/Elasticsearch.Net/Configuration/ConnectionConfiguration.cs

@@ -10,9 +10,9 @@ namespace Elasticsearch.Net
 	/// </summary>
 	public class ConnectionConfiguration : ConnectionConfiguration<ConnectionConfiguration>
 	{
-		public static TimeSpan DefaultTimeout = TimeSpan.FromMinutes(1);
-		public static TimeSpan DefaultPingTimeout = TimeSpan.FromSeconds(2);
-		public static TimeSpan DefaultPingTimeoutOnSSL = TimeSpan.FromSeconds(5);
+		public static readonly TimeSpan DefaultTimeout = TimeSpan.FromMinutes(1);
+		public static readonly TimeSpan DefaultPingTimeout = TimeSpan.FromSeconds(2);
+		public static readonly TimeSpan DefaultPingTimeoutOnSSL = TimeSpan.FromSeconds(5);
 
 		/// <summary>
 		/// ConnectionConfiguration allows you to control how ElasticsearchClient behaves and where/how it connects 
@@ -47,6 +47,10 @@ public ConnectionConfiguration(IConnectionPool connectionPool, Func<ConnectionCo
 		public ConnectionConfiguration(IConnectionPool connectionPool, IConnection connection, Func<ConnectionConfiguration, IElasticsearchSerializer> serializerFactory)
 			: base(connectionPool, connection, serializerFactory)
 		{ }
+
+		public void Dispose()
+		{
+		}
 	}
 
 	[Browsable(false)]
@@ -308,6 +312,11 @@ public T BasicAuthentication(string userName, string password)
 		/// <para>Note: HTTP pipelining must also be enabled in Elasticsearch for this to work properly.</para>
 		/// </summary>
 		public T EnableHttpPipelining(bool enabled = true) => Assign(a => a._enableHttpPipelining = enabled);
+
+		public void Dispose()
+		{
+			this._connectionPool?.Dispose();
+		}
 	}
 }
 

src/Elasticsearch.Net/Configuration/IConnectionConfigurationValues.cs

@@ -3,7 +3,7 @@
 
 namespace Elasticsearch.Net
 {
-	public interface IConnectionConfigurationValues
+	public interface IConnectionConfigurationValues : IDisposable
 	{
 		/// <summary> The connection pool to use when talking with elasticsearch </summary>
 		IConnectionPool ConnectionPool { get; }

src/Elasticsearch.Net/ConnectionPool/IConnectionPool.cs

@@ -3,7 +3,7 @@
 
 namespace Elasticsearch.Net
 {
-	public interface IConnectionPool
+	public interface IConnectionPool : IDisposable
 	{
 		/// <summary>
 		/// Returns a readonly constant view of all the nodes in the cluster, this might involve creating copies of the nodes e.g 

src/Elasticsearch.Net/ConnectionPool/SingleNodeConnectionPool.cs

@@ -29,5 +29,9 @@ public SingleNodeConnectionPool(Uri uri, IDateTimeProvider dateTimeProvider = nu
 		}
 
 		public IEnumerable<Node> CreateView(Action<AuditEvent, Node> audit = null) => this.Nodes;
+
+		public void Dispose()
+		{
+		}
 	}
 }

src/Elasticsearch.Net/ConnectionPool/SniffingConnectionPool.cs

@@ -73,5 +73,10 @@ public override IEnumerable<Node> CreateView(Action<AuditEvent, Node> audit = nu
 			}
 		}
 
+		public override void Dispose()
+		{
+			this._readerWriter?.Dispose();
+			base.Dispose();
+		}
 	}
 }

src/Elasticsearch.Net/ConnectionPool/StaticConnectionPool.cs

@@ -97,5 +97,8 @@ public virtual IEnumerable<Node> CreateView(Action<AuditEvent, Node> audit = nul
 			}
 		}
 
+		public virtual void Dispose()
+		{
+		}
 	}
 }

src/Elasticsearch.Net/Elasticsearch.Net.csproj

@@ -23,6 +23,7 @@
     <WarningLevel>4</WarningLevel>
     <UseVSHostingProcess>false</UseVSHostingProcess>
     <Prefer32Bit>false</Prefer32Bit>
+    <CodeAnalysisRuleSet>AllRules.ruleset</CodeAnalysisRuleSet>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>pdbonly</DebugType>
@@ -54,6 +55,7 @@
   <ItemGroup>
     <Compile Include="Configuration\RequestConfiguration.cs" />
     <Compile Include="Exceptions\UnexpectedElasticsearchClientException.cs" />
+    <Compile Include="GlobalSuppressions.cs" />
     <Compile Include="Transport\Pipeline\PipelineException.cs" />
     <Compile Include="Connection\HttpMethod.cs" />
     <Compile Include="Auditing\Audit.cs" />