GetFull does not escape id's properly

Author: Mpdreamz

src/Nest.Connection.Thrift/Properties/AssemblyInfo.cs

@@ -15,7 +15,7 @@
 [assembly: System.Runtime.InteropServices.ComVisible(false)]
 [assembly: System.CLSCompliant(true)]
 [assembly: System.Runtime.InteropServices.Guid("4d165338-2060-4641-8be6-b7aacbdee52d")]
-[assembly: System.Reflection.AssemblyVersion("0.11.0.0")]
-[assembly: System.Reflection.AssemblyFileVersion("0.11.0.0")]
+[assembly: System.Reflection.AssemblyVersion("0.11.1.0")]
+[assembly: System.Reflection.AssemblyFileVersion("0.11.1.0")]
 
 

src/Nest.Dsl.Factory/Properties/AssemblyInfo.cs

@@ -16,7 +16,7 @@
 [assembly: System.Runtime.InteropServices.ComVisible(false)]
 [assembly: System.CLSCompliant(true)]
 [assembly: System.Runtime.InteropServices.Guid("665cc582-c91f-4f6c-924a-614289fa9449")]
-[assembly: System.Reflection.AssemblyVersion("0.11.0.0")]
-[assembly: System.Reflection.AssemblyFileVersion("0.11.0.0")]
+[assembly: System.Reflection.AssemblyVersion("0.11.1.0")]
+[assembly: System.Reflection.AssemblyFileVersion("0.11.1.0")]
 
 

src/Nest.Tests.Unit/Core/Get/GetFullTests.cs

@@ -42,6 +42,16 @@ public void GetUsingDescriptor()
 			StringAssert.EndsWith("/myindex/elasticsearchprojects/404", status.RequestUrl);
 		}
 		[Test]
+		public void GetUsingDescriptorEscapes()
+		{
+			var result = this._client.GetFull<ElasticSearchProject>(g => g
+				.Index("myindex")
+				.Id("myid/with/slashes")
+			);
+			var status = result.ConnectionStatus;
+			StringAssert.EndsWith("/myindex/elasticsearchprojects/myid%252Fwith%252Fslashes", status.RequestUrl);
+		}
+		[Test]
 		public void GetUsingDescriptorWithType()
 		{
 			var result = this._client.GetFull<ElasticSearchProject>(g => g

src/Nest/ElasticClient-GetFull.cs

@@ -29,29 +29,28 @@ public IGetResponse<T> GetFull<T>(string id) where T : class
 			index.ThrowIfNullOrEmpty("Cannot infer default index for current connection.");
 
 			var typeName = this.GetTypeNameFor<T>();
-
-			return this.GetFull<T>(id, this.PathResolver.CreateIndexTypePath(index, typeName));
+			var path = this.PathResolver.CreateIndexTypeIdPath(index, typeName, id);
+			return this._GetFull<T>(path);
 		}
 		/// <summary>
 		/// Gets a document of T by id in the specified index and the specified typename
 		/// </summary>
 		/// <returns>an instance of T</returns>
 		public IGetResponse<T> GetFull<T>(string index, string type, string id) where T : class
 		{
-			return this.GetFull<T>(id, index + "/" + type + "/");
+			var path = this.PathResolver.CreateIndexTypeIdPath(index, type, id);
+			return this._GetFull<T>(path);
 		}
 		/// <summary>
 		/// Gets a document of T by id in the specified index and the specified typename
 		/// </summary>
 		/// <returns>an instance of T</returns>
 		public IGetResponse<T> GetFull<T>(string index, string type, int id) where T : class
 		{
-			return this.GetFull<T>(id.ToString(), index + "/" + type + "/");
-		}
-		private IGetResponse<T> GetFull<T>(string id, string path) where T : class
-		{
-			return this._GetFull<T>(path + id);
+			var path = this.PathResolver.CreateIndexTypeIdPath(index, type, id.ToString());
+			return this._GetFull<T>(path);
 		}
+		
 
 		public IGetResponse<T> GetFull<T>(Action<GetDescriptor<T>> getSelector) where T : class
 		{

src/Nest/Properties/AssemblyInfo.cs

@@ -15,7 +15,7 @@
 [assembly: System.Runtime.InteropServices.ComVisible(false)]
 [assembly: System.CLSCompliant(true)]
 [assembly: System.Runtime.InteropServices.Guid("07E5CFA3-CF5F-4D17-874C-8D5CC6FA3E73")]
-[assembly: System.Reflection.AssemblyVersion("0.11.0.0")]
-[assembly: System.Reflection.AssemblyFileVersion("0.11.0.0")]
+[assembly: System.Reflection.AssemblyVersion("0.11.1.0")]
+[assembly: System.Reflection.AssemblyFileVersion("0.11.1.0")]
 
 

src/Nest/Resolvers/PathResolver.cs

@@ -39,7 +39,7 @@ public string CreateGetPath<T>(GetDescriptor<T> d) where T : class
 			var id = d._Id;
 			id.ThrowIfNullOrEmpty("id");
 
-			var path = string.Format("/{0}/{1}/{2}", index, type.Resolve(this._connectionSettings), id);
+			var path = "/{0}/{1}/{2}".EscapedFormat(index, type.Resolve(this._connectionSettings), id);
 			var urlParams = new Dictionary<string, string>();
 			if (d._Refresh.HasValue)
 				urlParams.Add("refresh", d._Refresh.Value.ToString().ToLower());